Closed Bug 675481 Opened 9 years ago Closed 8 years ago

Space reserved for expand button should be determined at run-time

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 8

People

(Reporter: ttaubert, Assigned: raymondlee)

References

Details

Attachments

(1 file, 1 obsolete file)

Follow-up from bug 673825 comment #5.

We currently reserve 33px of space for the expand button at the bottom of stacked groups. This value (the height of the expand button plus some margin) should be determined at run-time to allow theming.
Attached patch v1 (obsolete) — Splinter Review
Assignee: nobody → raymond
Attachment #551706 - Flags: review?(tim.taubert)
Comment on attachment 551706 [details] [diff] [review]
v1

Review of attachment 551706 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great! Could you please add a little padding to the expand button's height? It's now 24px and we assumed 33px before. So maybe a padding of 9-10px would be good. And please don't forget to add a little comment that tells why we're adding these 9px if that isn't obvious :)
Attachment #551706 - Flags: review?(tim.taubert) → review+
Comment on attachment 551706 [details] [diff] [review]
v1

I forgot to say r=me with the little padding fix but I guess you figured that :)
(In reply to Tim Taubert [:ttaubert] from comment #3)
> Comment on attachment 551706 [details] [diff] [review]
>
> Looks great! Could you please add a little padding to the expand button's
> height? It's now 24px and we assumed 33px before. So maybe a padding of
> 9-10px would be good. And please don't forget to add a little comment that
> tells why we're adding these 9px if that isn't obvious :)
Done
Attachment #551706 - Attachment is obsolete: true
Keywords: checkin-needed
Status: NEW → ASSIGNED
http://hg.mozilla.org/mozilla-central/rev/6137de4b8036
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Whiteboard: [fixed-in-fx-team]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.