Space reserved for expand button should be determined at run-time

RESOLVED FIXED in Firefox 8

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: ttaubert, Assigned: raymondlee)

Tracking

Trunk
Firefox 8

Details

Attachments

(1 attachment, 1 obsolete attachment)

Follow-up from bug 673825 comment #5.

We currently reserve 33px of space for the expand button at the bottom of stacked groups. This value (the height of the expand button plus some margin) should be determined at run-time to allow theming.
(Assignee)

Comment 1

6 years ago
Created attachment 551706 [details] [diff] [review]
v1
Assignee: nobody → raymond
Attachment #551706 - Flags: review?(tim.taubert)
(Assignee)

Comment 2

6 years ago
Passed Try.  http://tbpl.mozilla.org/?tree=Try&rev=fca2473d10d4
Comment on attachment 551706 [details] [diff] [review]
v1

Review of attachment 551706 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great! Could you please add a little padding to the expand button's height? It's now 24px and we assumed 33px before. So maybe a padding of 9-10px would be good. And please don't forget to add a little comment that tells why we're adding these 9px if that isn't obvious :)
Attachment #551706 - Flags: review?(tim.taubert) → review+
Comment on attachment 551706 [details] [diff] [review]
v1

I forgot to say r=me with the little padding fix but I guess you figured that :)
(Assignee)

Comment 5

6 years ago
Created attachment 553093 [details] [diff] [review]
Patch for checkin

(In reply to Tim Taubert [:ttaubert] from comment #3)
> Comment on attachment 551706 [details] [diff] [review]
>
> Looks great! Could you please add a little padding to the expand button's
> height? It's now 24px and we assumed 33px before. So maybe a padding of
> 9-10px would be good. And please don't forget to add a little comment that
> tells why we're adding these 9px if that isn't obvious :)
Done
Attachment #551706 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/fx-team/rev/6137de4b8036
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Status: NEW → ASSIGNED
http://hg.mozilla.org/mozilla-central/rev/6137de4b8036
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Whiteboard: [fixed-in-fx-team]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.