Closed
Bug 675481
Opened 13 years ago
Closed 13 years ago
Space reserved for expand button should be determined at run-time
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 8
People
(Reporter: ttaubert, Assigned: raymondlee)
References
Details
Attachments
(1 file, 1 obsolete file)
2.64 KB,
patch
|
Details | Diff | Splinter Review |
Follow-up from bug 673825 comment #5. We currently reserve 33px of space for the expand button at the bottom of stacked groups. This value (the height of the expand button plus some margin) should be determined at run-time to allow theming.
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → raymond
Attachment #551706 -
Flags: review?(tim.taubert)
Assignee | ||
Comment 2•13 years ago
|
||
Passed Try. http://tbpl.mozilla.org/?tree=Try&rev=fca2473d10d4
Reporter | ||
Comment 3•13 years ago
|
||
Comment on attachment 551706 [details] [diff] [review] v1 Review of attachment 551706 [details] [diff] [review]: ----------------------------------------------------------------- Looks great! Could you please add a little padding to the expand button's height? It's now 24px and we assumed 33px before. So maybe a padding of 9-10px would be good. And please don't forget to add a little comment that tells why we're adding these 9px if that isn't obvious :)
Attachment #551706 -
Flags: review?(tim.taubert) → review+
Reporter | ||
Comment 4•13 years ago
|
||
Comment on attachment 551706 [details] [diff] [review] v1 I forgot to say r=me with the little padding fix but I guess you figured that :)
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to Tim Taubert [:ttaubert] from comment #3) > Comment on attachment 551706 [details] [diff] [review] > > Looks great! Could you please add a little padding to the expand button's > height? It's now 24px and we assumed 33px before. So maybe a padding of > 9-10px would be good. And please don't forget to add a little comment that > tells why we're adding these 9px if that isn't obvious :) Done
Attachment #551706 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 6•13 years ago
|
||
http://hg.mozilla.org/integration/fx-team/rev/6137de4b8036
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Reporter | ||
Updated•13 years ago
|
Status: NEW → ASSIGNED
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/6137de4b8036
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Reporter | ||
Updated•13 years ago
|
Whiteboard: [fixed-in-fx-team]
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•