Last Comment Bug 673825 - Release space at group bottoms that was reserved for the new tab button
: Release space at group bottoms that was reserved for the new tab button
Status: RESOLVED FIXED
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Panorama (show other bugs)
: Trunk
: All All
: -- normal
: Firefox 8
Assigned To: Tim Taubert [:ttaubert]
:
Mentors:
Depends on:
Blocks: 675481
  Show dependency treegraph
 
Reported: 2011-07-24 17:39 PDT by Tim Taubert [:ttaubert]
Modified: 2016-04-12 14:00 PDT (History)
1 user (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1 (2.27 KB, patch)
2011-07-24 18:18 PDT, Tim Taubert [:ttaubert]
raymond: feedback+
Details | Diff | Review
patch v2 (2.47 KB, patch)
2011-07-24 19:02 PDT, Tim Taubert [:ttaubert]
no flags Details | Diff | Review
patch v3 (4.17 KB, patch)
2011-07-25 09:54 PDT, Tim Taubert [:ttaubert]
dietrich: review+
Details | Diff | Review

Description Tim Taubert [:ttaubert] 2011-07-24 17:39:47 PDT
Follow-up from bug 663613 comment #16:

We need to reserve 33px when a group is stacked (for the expand button) but not in normal mode.
Comment 1 Tim Taubert [:ttaubert] 2011-07-24 18:18:32 PDT
Created attachment 548065 [details] [diff] [review]
patch v1

We need to leave a bottom padding (of 33px) only when a group is stacked to reserve space for the expand button. I additionally had to fix the test for bug 610208 because it saved the former tab bounds for comparison at the wrong time.
Comment 2 Raymond Lee [:raymondlee] 2011-07-24 18:55:44 PDT
Comment on attachment 548065 [details] [diff] [review]
patch v1

>     // Make the computed bounds' "padding" and new tab button margin actually be
>     // themeable --OR-- compute this from actual bounds. Bug 586546

Please also update the above comment. f+ with that.
Comment 3 Tim Taubert [:ttaubert] 2011-07-24 19:02:09 PDT
Created attachment 548081 [details] [diff] [review]
patch v2

Comment updated.
Comment 4 Tim Taubert [:ttaubert] 2011-07-25 09:54:44 PDT
Created attachment 548207 [details] [diff] [review]
patch v3

Corrected the patch because it failed to arrange tabs correctly when it wasn't stacked before. That's because .isStacked() didn't return true yet and ._stackArrange() was called with the wrong bounds. So the tabs overlapped the expand button (bizarrely on Mac only).
Comment 5 Dietrich Ayala (:dietrich) 2011-07-29 08:31:34 PDT
Comment on attachment 548207 [details] [diff] [review]
patch v3

Review of attachment 548207 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: browser/base/content/tabview/groupitems.js
@@ +514,5 @@
> +
> +    // make some room for the expand button if we're stacked
> +    let isStacked = (options && options.forceStacked) || this.isStacked();
> +    if (isStacked)
> +      box.height -= 33;

Shouldn't remove the "For new tab button" comment.

Hm, also feels like this should be computed, in the event the expand button is re-themed. Can you file a followup bug for that?
Comment 6 Tim Taubert [:ttaubert] 2011-07-30 23:24:32 PDT
(In reply to comment #5)
> Shouldn't remove the "For new tab button" comment.

Re-added comment that says we currently reserve 33px of space for the expand button.

> Hm, also feels like this should be computed, in the event the expand button
> is re-themed. Can you file a followup bug for that?

Filed bug 675481.
Comment 7 Tim Taubert [:ttaubert] 2011-08-09 10:18:00 PDT
http://hg.mozilla.org/integration/fx-team/rev/248aed2b337d
Comment 8 Tim Taubert [:ttaubert] 2011-08-09 16:40:36 PDT
http://hg.mozilla.org/mozilla-central/rev/248aed2b337d

Note You need to log in before you can comment on or make changes to this bug.