Closed Bug 673825 Opened 8 years ago Closed 8 years ago

Release space at group bottoms that was reserved for the new tab button

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 8

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

Attachments

(1 file, 2 obsolete files)

Follow-up from bug 663613 comment #16:

We need to reserve 33px when a group is stacked (for the expand button) but not in normal mode.
Attached patch patch v1 (obsolete) — Splinter Review
We need to leave a bottom padding (of 33px) only when a group is stacked to reserve space for the expand button. I additionally had to fix the test for bug 610208 because it saved the former tab bounds for comparison at the wrong time.
Attachment #548065 - Flags: feedback?(raymond)
Comment on attachment 548065 [details] [diff] [review]
patch v1

>     // Make the computed bounds' "padding" and new tab button margin actually be
>     // themeable --OR-- compute this from actual bounds. Bug 586546

Please also update the above comment. f+ with that.
Attachment #548065 - Flags: feedback?(raymond) → feedback+
Attached patch patch v2 (obsolete) — Splinter Review
Comment updated.
Attachment #548065 - Attachment is obsolete: true
Attachment #548081 - Flags: review?(dietrich)
Attachment #548081 - Flags: review?(dietrich)
Attached patch patch v3Splinter Review
Corrected the patch because it failed to arrange tabs correctly when it wasn't stacked before. That's because .isStacked() didn't return true yet and ._stackArrange() was called with the wrong bounds. So the tabs overlapped the expand button (bizarrely on Mac only).
Attachment #548081 - Attachment is obsolete: true
Attachment #548207 - Flags: review?(dietrich)
Comment on attachment 548207 [details] [diff] [review]
patch v3

Review of attachment 548207 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: browser/base/content/tabview/groupitems.js
@@ +514,5 @@
> +
> +    // make some room for the expand button if we're stacked
> +    let isStacked = (options && options.forceStacked) || this.isStacked();
> +    if (isStacked)
> +      box.height -= 33;

Shouldn't remove the "For new tab button" comment.

Hm, also feels like this should be computed, in the event the expand button is re-themed. Can you file a followup bug for that?
Attachment #548207 - Flags: review?(dietrich) → review+
Blocks: 675481
(In reply to comment #5)
> Shouldn't remove the "For new tab button" comment.

Re-added comment that says we currently reserve 33px of space for the expand button.

> Hm, also feels like this should be computed, in the event the expand button
> is re-themed. Can you file a followup bug for that?

Filed bug 675481.
http://hg.mozilla.org/mozilla-central/rev/248aed2b337d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.