Last Comment Bug 675500 - Remove --disable-storage
: Remove --disable-storage
Status: RESOLVED FIXED
[inbound]
: dev-doc-complete
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla8
Assigned To: Matheus Kerschbaum
:
Mentors:
Depends on: 669040
Blocks: 675501 678794
  Show dependency treegraph
 
Reported: 2011-07-31 08:24 PDT by Matheus Kerschbaum
Modified: 2011-08-23 12:02 PDT (History)
5 users (show)
khuey: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (28.37 KB, patch)
2011-07-31 08:28 PDT, Matheus Kerschbaum
khuey: review+
Details | Diff | Review
patch (27.25 KB, patch)
2011-08-01 18:58 PDT, Matheus Kerschbaum
matjk7: review+
Details | Diff | Review
patch (27.25 KB, patch)
2011-08-05 20:26 PDT, Matheus Kerschbaum
matjk7: review+
Details | Diff | Review

Description Matheus Kerschbaum 2011-07-31 08:24:37 PDT

    
Comment 1 Matheus Kerschbaum 2011-07-31 08:28:09 PDT
Created attachment 549656 [details] [diff] [review]
patch
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-08-01 09:59:02 PDT
Comment on attachment 549656 [details] [diff] [review]
patch

>diff --git a/netwerk/build.mk b/netwerk/build.mk

Don't bother touching this, netwerk/build.mk is dead code.

>diff --git a/toolkit/toolkit-tiers.mk b/toolkit/toolkit-tiers.mk
>--- a/toolkit/toolkit-tiers.mk
>+++ b/toolkit/toolkit-tiers.mk
>@@ -47,23 +47,22 @@ TIERS += platform
> ifdef NS_TRACE_MALLOC
> tier_platform_dirs = tools/trace-malloc/lib
> endif
> 
> ifdef MOZ_TREE_FREETYPE
> tier_platform_staticdirs += modules/freetype2
> endif
> 
>-tier_platform_dirs += xpcom
>-
> ifndef MOZ_NATIVE_ZLIB
> tier_platform_dirs += modules/zlib
> endif
> 
> tier_platform_dirs += \
>+		xpcom \
> 		modules/libreg \
> 		modules/libpref \
> 		intl \
> 		netwerk \
> 		$(NULL)
> 
> ifdef MOZ_AUTH_EXTENSION
> tier_platform_dirs += extensions/auth

Drop this hunk, it's irrelevant and scary.

r=me
Comment 3 Matheus Kerschbaum 2011-08-01 18:58:22 PDT
Created attachment 549995 [details] [diff] [review]
patch

Review comments addressed.
Comment 4 Matheus Kerschbaum 2011-08-05 20:26:17 PDT
Created attachment 551228 [details] [diff] [review]
patch

Updated to tip.
Comment 5 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-08-08 05:41:53 PDT
http://hg.mozilla.org/mozilla-central/rev/9754cac0194c
Comment 6 Eric Shepherd [:sheppy] 2011-08-23 12:02:56 PDT
Docs updated:

https://developer.mozilla.org/en/Configuring_Build_Options#Other_Not.c2.a0So.c2.a0Commonly_Used_Options

Listed on Firefox 8 for developers.

Note You need to log in before you can comment on or make changes to this bug.