675779 - Favour capital letters for accesskeys in utilityOverlay.xul

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch

(courtesy timeless)

Comment 1

[David :Bienvenu]

Comment on attachment 549948 [details] [diff] [review]
patch

bwinton loves access keys so much more than I do...

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 549948 [details] [diff] [review]
patch

Review of attachment 549948 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me, although I'll admit that I don't have my Windows PC up, so I haven't compiled or tested the patch.  But I trust you to have run the test suites, so r=me with the questions below answered, and the tests passing.

Thanks,
Blake.

::: mail/locales/en-US/chrome/communicator/utilityOverlay.dtd
@@ -27,2 +27,2 @@
> >  <!ENTITY deleteCmd.label          "Delete">
> >  <!ENTITY deleteCmd.accesskey        "d">

Why not "D" here?

@@ -50,4 +50,4 @@
> >  
> >  <!ENTITY quitApplicationCmd.label  "Exit">
> >  <!ENTITY quitApplicationCmd.key    "Q">
> >  <!ENTITY quitApplicationCmd.accesskey  "x">

And why not "X" here?

Comment 3

[Rain [:rain1] (inactive)]

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #2)
> This looks good to me, although I'll admit that I don't have my Windows PC
> up, so I haven't compiled or tested the patch.  But I trust you to have run
> the test suites, so r=me with the questions below answered, and the tests
> passing.
> 
> Thanks,
> Blake.
> 
> ::: mail/locales/en-US/chrome/communicator/utilityOverlay.dtd
> @@ -27,2 +27,2 @@
> > >  <!ENTITY deleteCmd.label          "Delete">
> > >  <!ENTITY deleteCmd.accesskey        "d">
> 
> Why not "D" here?

Because timeless separated it into bug 675783.

> 
> @@ -50,4 +50,4 @@
> > >  
> > >  <!ENTITY quitApplicationCmd.label  "Exit">
> > >  <!ENTITY quitApplicationCmd.key    "Q">
> > >  <!ENTITY quitApplicationCmd.accesskey  "x">
> 
> And why not "X" here?

Because Exit has a small x, I think. I think I might have messed his patch up and changed what should have been small letters into capital ones.

Comment 4

[Rain [:rain1] (inactive)]

Fixed the unnecessary caps: https://hg.mozilla.org/comm-central/rev/3d7a6ee8b730