675812 - css bleed fix for panel/iframe on osx

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Shane Caraveo (:mixedpuppy)]

Attachment: css bleed

On osx, at least in f1, the iframe corners are square, and bleed over the rounded corners of the panel, but only on the left side.  

The fix we used in f1 is to have (roughly) this css:

panel iframe {
  border-radius: 6px;
}
panel .panel-arrowcontent {
  padding: 2px;
}

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Matteo has some experience looking at panel style issues; cc:ing him for his thoughts.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

The URL of the repo for the addon in question:

https://github.com/mozilla/fx-share-addon

Comment 3

[Dave Townsend [:mossop]]

We saw something similar in the add-ons manager, see bug 597927, bug 595656. The fixes we took there ended up getting backed out for perf issues though

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(Pushing all open bugs to the --- milestone for the new triage system)

Comment 5

[Shane Caraveo (:mixedpuppy)]

Attachment: my eyes are bleeding

so I'm just fixing this for fx-share release

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 561527 [details] [diff] [review]
my eyes are bleeding

My, that sure is much nicer. r=myk

Comment 7

[Myk Melez [:myk] [@mykmelez]]

https://github.com/mozilla/addon-sdk/commit/97b79af12284454986b4b87590860ae6911c8564

Comment 8

[Myk Melez [:myk] [@mykmelez]]

https://github.com/mozilla/addon-sdk/commit/0d15d819ef6a8fbdf5100059ad7fa3c3f646dfc4