Closed Bug 675812 Opened 11 years ago Closed 11 years ago

css bleed fix for panel/iframe on osx

Categories

(Add-on SDK Graveyard :: General, defect, P3)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

()

Details

(Whiteboard: [cherry-pick-1.2])

Attachments

(2 files)

Attached image css bleed
On osx, at least in f1, the iframe corners are square, and bleed over the rounded corners of the panel, but only on the left side.  

The fix we used in f1 is to have (roughly) this css:

panel iframe {
  border-radius: 6px;
}
panel .panel-arrowcontent {
  padding: 2px;
}
Matteo has some experience looking at panel style issues; cc:ing him for his thoughts.
Assignee: nobody → zer0
Priority: -- → P3
Target Milestone: --- → 1.1
We saw something similar in the add-ons manager, see bug 597927, bug 595656. The fixes we took there ended up getting backed out for perf issues though
(Pushing all open bugs to the --- milestone for the new triage system)
Target Milestone: 1.1 → ---
so I'm just fixing this for fx-share release
Attachment #561527 - Flags: review?(myk)
Attachment #561527 - Flags: feedback?(zer0)
Comment on attachment 561527 [details] [diff] [review]
my eyes are bleeding

My, that sure is much nicer. r=myk
Attachment #561527 - Flags: review?(myk)
Attachment #561527 - Flags: review+
Attachment #561527 - Flags: feedback?(zer0)
https://github.com/mozilla/addon-sdk/commit/97b79af12284454986b4b87590860ae6911c8564
Assignee: zer0 → mixedpuppy
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [cherry-pick-wanted]
https://github.com/mozilla/addon-sdk/commit/0d15d819ef6a8fbdf5100059ad7fa3c3f646dfc4
Whiteboard: [cherry-pick-wanted] → [cherry-pick-1.2]
Target Milestone: --- → 1.2
You need to log in before you can comment on or make changes to this bug.