Closed
Bug 676831
Opened 13 years ago
Closed 13 years ago
[OGL] GL Reftest on Android
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(1 file)
41.32 KB,
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
We need to get test coverage for opengl reftest on android.
Assignee | ||
Comment 1•13 years ago
|
||
Trying a test on android to get an idea for what state we are at for reftest + talos:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=23fa4d835b88
Assignee | ||
Comment 2•13 years ago
|
||
We also made some test to see where we stand for talos. We didn't notice any significant regression. Some results were +2% which are on the high end of the regression.
The results are suspicious so I ran a patch to force a regression to make sure the test were being executed properly. This appears to be the case as test show a ~270% regression on tp4mobile no chrome and fennecbench zoom. I'm not sure why we didn't see a regression with tp4 mobile.
http://hg.mozilla.org/try/rev/4cca6e24dd2d
Everything looks normal with enable OGL and no regression being forced:
http://hg.mozilla.org/try/rev/1d364e6248ac
http://graphs-new.mozilla.org/graph.html#tests=[[84,23,20],[85,23,20],[70,23,20],[69,23,20]]&sel=none&displayrange=30&datatype=running
(If viewing >30 days from now change the displayrange)
Assignee | ||
Comment 3•13 years ago
|
||
Ran into remote-reftest misreporting success (doesn't block this):
https://bugzilla.mozilla.org/show_bug.cgi?id=685360
Assignee | ||
Comment 4•13 years ago
|
||
For now I flagged all the failing test so that we can enable test coverage for OGL. Of importance is that all canvas/css-gradients/image-element/svg are disable for now.
We will work towards supporting all android reftest but for the time being I suggest that we ignore these test for this configuration and start automated testing to prevent further regressions.
Follow up task will be to remove all occurrences of |Android&&layersOpenGL| in **/reftest.list files.
Assignee | ||
Updated•13 years ago
|
Attachment #560996 -
Flags: review?(joe)
Comment 5•13 years ago
|
||
Comment on attachment 560996 [details] [diff] [review]
Flag Failures
Review of attachment 560996 [details] [diff] [review]:
-----------------------------------------------------------------
We should definitely have at least two followup bugs; I don't think we can release with any skip-if(Android&&layersOpenGL), especially not if they are skipped because they crash, but we should also try to fix all the failures before releasing.
Attachment #560996 -
Flags: review?(joe) → review+
Comment 6•13 years ago
|
||
Assignee: ajuma → bgirard
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Assignee | ||
Updated•13 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 7•13 years ago
|
||
I presume those follow-up bugs were filed?
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•