677027 - Implement conditional forward button for gnomestripe

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Dão Gottwald [:dao]]

Attachment: patch

I was just playing with this and it works surprisingly well even without the keyhole, so I figured I may as well put it up for review.

The button shifts the location bar when it appears, as does the keyhole-dependent implementation for windows and mac in bug 674744. I would normally be concerned about this kind of movement being distracting, but it turns out this isn't a big deal here, since it happens while the page is also changing.

Comment 1

[Dão Gottwald [:dao]]

pushed to ux

Comment 2

[Stephen Horlander [:shorlander]]

Comment on attachment 551255 [details] [diff] [review]
patch

Review of attachment 551255 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good although 300 or 250ms feels a little snappier to me.

I guess there is no way with this approach to avoid shifting the searchBar and the locationBar? Right now that is the only jarring part.

Something Jared and I were talking about in regards to bug 674744 was minimizing the shifting as much as possible. Ideally only the locationBar would slide over to keep the transition as subtle as possible.

Comment 3

[Dão Gottwald [:dao]]

> I guess there is no way with this approach to avoid shifting the searchBar
> and the locationBar? Right now that is the only jarring part.

Well, there is a way: Let the back button consume more space and shrink that to make room for the forward button. I'm not sure at all if that's a better approach, though.

Comment 4

[Stephen Horlander [:shorlander]]

(In reply to Dão Gottwald [:dao] from comment #3)
> I'm not sure at all if that's a better approach, though.

Probably not :)

Comment 5

[Mounir Lamouri (:mounir)]

http://hg.mozilla.org/mozilla-central/rev/0812db89f2f2

Comment 6

[Mounir Lamouri (:mounir)]

Why do we *can't*? test this?

Comment 7

[Siddhartha Dugar [:sdrocking]]

Why do we just have this for Linux and not on all platforms? (Bug 674744)

Comment 8

[Dão Gottwald [:dao]]

(In reply to Mounir Lamouri (:volkmar) from comment #6)
> Why do we *can't*? test this?

This code is doing nothing that we'd need or want to test.

Comment 9

[Matthew Turnbull [Bluefang]]

(In reply to Dão Gottwald [:dao] from comment #0)
> The button shifts the location bar when it appears, as does the
> keyhole-dependent implementation for windows and mac in bug 674744. I would
> normally be concerned about this kind of movement being distracting, but it
> turns out this isn't a big deal here, since it happens while the page is
> also changing.



Just for the record, this *is* distracting, and can be somewhat problematic.

* Every time it pops in or out, it draws my attention to it. As such, it's constantly drawing my attention away from the content area, which, for a browser, seems counter productive. Yes, the page content is changing, but it's still disruptive to the browsing 'flow', as you (I) now refocus/context-switch twice instead of maybe once.

* When I open a blank tab to enter something in the location bar, I usually have already focused on the location bar (or I'm already in the process of doing so). So having it jump to the left is, again, disruptive.

* If, say, you've gone back a few pages to check something, then want to go back to the most recent page, click-spaming the forward button will often result in clicking the identity button (or, in my case, reload).

I can see how this makes sense on a mobile device, but is this necessary, or even useful, on a desktop?

Comment 10

[Henri Sivonen (:hsivonen)]

FWIW, this is rather distracting when reading a Web forum where you open a thread (forward button goes away), go back to list of threads (forward button comes back), open the next thread (forward button goes away), etc.

Comment 11

[Dão Gottwald [:dao]]

Backed out in preparation for the aurora merge, since the followup bugs didn't make it (blocked by bug 682534).

Comment 12

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/80be49be4394

Comment 13

[Matt Brubeck (:mbrubeck)]

Re-landed in Firefox 10:
https://hg.mozilla.org/mozilla-central/rev/80be49be4394