677673 - Bookmark Popup arrowbox should point up in tablet mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

The popup that appears when you "star" a page needs to anchor to the star button in the toolbar when in tablet mode. It is still trying to anchor to the sidebar button.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch v1

This modifies our arrowbox anchorTo method to take a separate parameter giving the position of the popup. When it is passed in, the arrow position is forced, and the popup is moved to an appropriate position. Works well here!

I attempted to always force popups to be inbounds, which works with left, but not always with top. I assume this is because the first time these are shown, the height of the arrowbox is basically window-height.

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 557638 [details] [diff] [review]
Patch v1

FYI: I recently added simpler methods to force position of the arrow. See pointLeftAt in arrowbox.xml. I guess you should replace pointLeftAt with your new stuff?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 557638 [details] [diff] [review]
Patch v1

These changes look good. I like the code reduction. We should update the code Lucas added to use this new approach too. Also, tests? See what desktop does and maybe we could steal the approach.

I'm ok with landing this, but I do want the followup for Lucas' changes and some simple tests.

Comment 4

[Wesley Johnston (:wesj)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/9ca2aaaae7bf

Comment 5

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/9ca2aaaae7bf

Comment 6

[Cristian Nicolae (:xti)]

Attachment: screenshot

It seems that the arrow is missing from the Bookmark Popup on the latest Nightly build. Is this expected?

--
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110927
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1

Comment 7

[Martijn Wargers (dead)]

Yes, I think so, since they removed it intentionally from the search menu (bug 688432).

Comment 8

[Camelia Urian]

Build ID: Mozilla/5.0 (Android;Linux armv7l;rv:9.0a2)Gecko/20111004 Firefox/9.0a2 Fennec/9.0a2
Device: Acer ICONIA A500
OS: Android 3.1

There is no arrow pointing from Bookmark Popup. Popup is displayed in the top right side of the screen.