684397 - [Tablet] Form autocomplete arrowbox has no arrow in Honeycomb theme

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: screenshot

In the honeycomb theme, at least on my desktop trunk build, the form autocomplete popup is missing an arrow pointing to the form field.  This might be helped by the code in bug 677673.

Comment 1

[Matt Brubeck (:mbrubeck)]

Ian, we've intentionally removed arrows from arrowbox popups (like "Page Bookmarked") in the Honeycomb theme.  Are there any popups that should still have arrows?  Here's a list of affected arrowboxes:

* Site/Identity menu
* Form Helper suggestions
* Bookmark star popup
* App/"More" menu
* "Tab opened" notification

Comment 2

[Lucas Rocha (:lucasr)]

Form validation popup is also affected.

Comment 3

[Ian Barlow (:ibarlow)]

Hi Matt

Site ID Menu - No arrow
Bookmark Star popup - No arrow
App/More menu - No arrow

Tab opened notification - Keep the arrow
Form Helper Suggestions - Keep the arrow
Form Validation Popup - Keep the arrow

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This just adds back the arrow styles from the gingerbread/froyo themes, but excludes the arrowboxes mentioned in comment 3.

Comment 5

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 558676 [details] [diff] [review]
patch

Review of attachment 558676 [details] [diff] [review]:
-----------------------------------------------------------------

This patch looks good to me.
However, I guess, the images for the arrows need to be changed. They have a black shadow instead of blue.

Comment 6

[Matt Brubeck (:mbrubeck)]

I'll let Ian file a separate bug if he wants new images/styles for the arrowbox arrows on Honeycomb.

https://hg.mozilla.org/integration/mozilla-inbound/rev/54f6877c35a7

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/54f6877c35a7

Comment 8

[Aaron Train [:aaronmt]]

Samsung Galaxy Tab 10.1 (Android v3.1)
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110909 Firefox/9.0a1 Fennec/9.0a1