Closed Bug 684397 Opened 8 years ago Closed 8 years ago

[Tablet] Form autocomplete arrowbox has no arrow in Honeycomb theme

Categories

(Firefox for Android Graveyard :: General, defect)

Firefox 9
defect
Not set

Tracking

(firefox9 fixed)

VERIFIED FIXED
Firefox 9
Tracking Status
firefox9 --- fixed

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: regression)

Attachments

(2 files)

Attached image screenshot
In the honeycomb theme, at least on my desktop trunk build, the form autocomplete popup is missing an arrow pointing to the form field.  This might be helped by the code in bug 677673.
Ian, we've intentionally removed arrows from arrowbox popups (like "Page Bookmarked") in the Honeycomb theme.  Are there any popups that should still have arrows?  Here's a list of affected arrowboxes:

* Site/Identity menu
* Form Helper suggestions
* Bookmark star popup
* App/"More" menu
* "Tab opened" notification
Keywords: uiwanted
Form validation popup is also affected.
Hi Matt

Site ID Menu - No arrow
Bookmark Star popup - No arrow
App/More menu - No arrow

Tab opened notification - Keep the arrow
Form Helper Suggestions - Keep the arrow
Form Validation Popup - Keep the arrow
Attached patch patchSplinter Review
This just adds back the arrow styles from the gingerbread/froyo themes, but excludes the arrowboxes mentioned in comment 3.
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #558676 - Flags: review?(sriram)
Keywords: uiwanted
Comment on attachment 558676 [details] [diff] [review]
patch

Review of attachment 558676 [details] [diff] [review]:
-----------------------------------------------------------------

This patch looks good to me.
However, I guess, the images for the arrows need to be changed. They have a black shadow instead of blue.
Attachment #558676 - Flags: review?(sriram) → review+
I'll let Ian file a separate bug if he wants new images/styles for the arrowbox arrows on Honeycomb.

https://hg.mozilla.org/integration/mozilla-inbound/rev/54f6877c35a7
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/54f6877c35a7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 9
Samsung Galaxy Tab 10.1 (Android v3.1)
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110909 Firefox/9.0a1 Fennec/9.0a1
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.