Last Comment Bug 684397 - [Tablet] Form autocomplete arrowbox has no arrow in Honeycomb theme
: [Tablet] Form autocomplete arrowbox has no arrow in Honeycomb theme
Status: VERIFIED FIXED
: regression
Product: Fennec Graveyard
Classification: Graveyard
Component: General (show other bugs)
: Firefox 9
: All All
: -- normal (vote)
: Firefox 9
Assigned To: Matt Brubeck (:mbrubeck)
:
Mentors:
Depends on: 677673
Blocks: 655762
  Show dependency treegraph
 
Reported: 2011-09-02 16:21 PDT by Matt Brubeck (:mbrubeck)
Modified: 2013-12-10 10:00 PST (History)
10 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
screenshot (30.61 KB, image/png)
2011-09-02 16:21 PDT, Matt Brubeck (:mbrubeck)
no flags Details
patch (5.88 KB, patch)
2011-09-06 17:20 PDT, Matt Brubeck (:mbrubeck)
sriram.mozilla: review+
Details | Diff | Splinter Review

Description Matt Brubeck (:mbrubeck) 2011-09-02 16:21:58 PDT
Created attachment 557984 [details]
screenshot

In the honeycomb theme, at least on my desktop trunk build, the form autocomplete popup is missing an arrow pointing to the form field.  This might be helped by the code in bug 677673.
Comment 1 Matt Brubeck (:mbrubeck) 2011-09-02 16:30:47 PDT
Ian, we've intentionally removed arrows from arrowbox popups (like "Page Bookmarked") in the Honeycomb theme.  Are there any popups that should still have arrows?  Here's a list of affected arrowboxes:

* Site/Identity menu
* Form Helper suggestions
* Bookmark star popup
* App/"More" menu
* "Tab opened" notification
Comment 2 Lucas Rocha (:lucasr) 2011-09-05 02:35:00 PDT
Form validation popup is also affected.
Comment 3 Ian Barlow (:ibarlow) 2011-09-06 08:29:43 PDT
Hi Matt

Site ID Menu - No arrow
Bookmark Star popup - No arrow
App/More menu - No arrow

Tab opened notification - Keep the arrow
Form Helper Suggestions - Keep the arrow
Form Validation Popup - Keep the arrow
Comment 4 Matt Brubeck (:mbrubeck) 2011-09-06 17:20:05 PDT
Created attachment 558676 [details] [diff] [review]
patch

This just adds back the arrow styles from the gingerbread/froyo themes, but excludes the arrowboxes mentioned in comment 3.
Comment 5 Sriram Ramasubramanian [:sriram] 2011-09-07 13:56:19 PDT
Comment on attachment 558676 [details] [diff] [review]
patch

Review of attachment 558676 [details] [diff] [review]:
-----------------------------------------------------------------

This patch looks good to me.
However, I guess, the images for the arrows need to be changed. They have a black shadow instead of blue.
Comment 6 Matt Brubeck (:mbrubeck) 2011-09-07 14:39:09 PDT
I'll let Ian file a separate bug if he wants new images/styles for the arrowbox arrows on Honeycomb.

https://hg.mozilla.org/integration/mozilla-inbound/rev/54f6877c35a7
Comment 8 Aaron Train [:aaronmt] 2011-09-09 07:02:47 PDT
Samsung Galaxy Tab 10.1 (Android v3.1)
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110909 Firefox/9.0a1 Fennec/9.0a1

Note You need to log in before you can comment on or make changes to this bug.