678140 - Message and folder focus is not shown when using CTRL+up/down arrow key

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[asmo.soinio]

User Agent: Mozilla/5.0 (Windows NT 6.0) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/13.0.782.112 Safari/535.1

Steps to reproduce:

Message or folder list, click on an item. Press and hold control. Press arrow down/up.


Actual results:

Nothing visible happens.

But if you now press SPACE, you can select the next message/folder, i.e. focus has been moved on the arrow key press.


Expected results:

There should be an indication of where the keyboard focus is.

Maybe related: When dragging a message to a folder, there is no visual which indication on the target folder while dragging.

Comment 1

[Jim Porter (:squib)]

Confirming. I suspect this is fairly straightforward. Paenglab, if you want me to take care of this, let me know, but since you've done a lot of good work on the Aero theme, I suspect you'd be able to do it more quickly than me. :)

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Let focus work again

Jim, because you could confirm this bug you have a working Win7 ;) and I think it would be the best you are doing the review.

Comment 3

[Jim Porter (:squib)]

I haven't had a chance to run with this yet, but based on inspection of the code, I think we should be doing this a bit differently. Windows Explorer's focus ring looks pretty much like the border around selected rows; it's not a dotted border anymore. We should probably try to imitate that.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Let focus work again V2

With solid instead dotted border.

Comment 5

[Jim Porter (:squib)]

Comment on attachment 554441 [details] [diff] [review]
Let focus work again V2

Review of attachment 554441 [details] [diff] [review]:
-----------------------------------------------------------------

Except for the comment below, this looks good to me. r+ with that addressed (possibly just with an explanation in this bug of why it's needed).

::: mail/themes/qute/mail/messenger-aero.css
@@ +44,5 @@
>  
>    listitem,
>    treechildren::-moz-tree-row {
>      min-height: 1.7em;
> +    color: -moz-FieldText;

Why this change?

Comment 6

[Richard Marti (:Paenglab)]

When you are for example in the filter dialog  with multiple filters and you move the focus with CTRL arrow down, the selected listitem text becomes highlight color and is no more readable because also the background has the highlight color. The -moz-FieldText is to override this. In Explorer also the text color is always black no matter what state it have.

Comment 7

[Jonathan Protzenko [:protz]]

http://hg.mozilla.org/comm-central/rev/e81e7ba2014a