Closed
Bug 678867
Opened 13 years ago
Closed 11 years ago
Eradicate VPATH abuse from js/src
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla9
People
(Reporter: khuey, Assigned: khuey)
References
Details
Attachments
(1 file)
|
7.54 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
VPATH makes us slow :-/
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #553029 -
Flags: review?(ted.mielczarek)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 553029 [details] [diff] [review]
Part 1: Kill most of it with fire.
Review of attachment 553029 [details] [diff] [review]:
-----------------------------------------------------------------
This doesn't screw up dependency generation nowadays, right? Would be nice if the explicit mkdir wasn't necessary.
Attachment #553029 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
|
|
Assignee | |
Comment 4•13 years ago
|
||
And, since somehow I lost most of the patch the first time:
http://hg.mozilla.org/projects/build-system/rev/e3f681b8147f
|
|
Assignee | |
Comment 5•13 years ago
|
||
|
|
Assignee | |
Comment 6•13 years ago
|
||
Turns out deps are still broken. Patch coming up.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 7•13 years ago
|
||
|
||
Comment 8•11 years ago
|
||
The only remaining VPATH under js/src is in the third-party libffi, so we can close this bug. VPATH has been removed as part of bug 912099 and bug 875013.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 11 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•