678867 - Eradicate VPATH abuse from js/src

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

VPATH makes us slow :-/

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Part 1: Kill most of it with fire.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 553029 [details] [diff] [review]
Part 1: Kill most of it with fire.

Review of attachment 553029 [details] [diff] [review]:
-----------------------------------------------------------------

This doesn't screw up dependency generation nowadays, right? Would be nice if the explicit mkdir wasn't necessary.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/projects/build-system/rev/c5882ebe8499

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

And, since somehow I lost most of the patch the first time:

http://hg.mozilla.org/projects/build-system/rev/e3f681b8147f

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/c5882ebe8499
http://hg.mozilla.org/mozilla-central/rev/e3f681b8147f

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Turns out deps are still broken.  Patch coming up.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/5d5b7df70df0
http://hg.mozilla.org/mozilla-central/rev/f0c4572db260

Comment 8

[Michael Shal [:mshal]]

The only remaining VPATH under js/src is in the third-party libffi, so we can close this bug. VPATH has been removed as part of bug 912099 and bug 875013.