680395 - Eradicate VPATH abuse from js/src, Part 2

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

+++ This bug was initially created as a clone of Bug #678867 +++

VPATH makes us slow :-/

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Eradicate VPATH abuse from js/src.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 554356 [details] [diff] [review]
Eradicate VPATH abuse from js/src.

Review of attachment 554356 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/Makefile.in
@@ +731,5 @@
> +	$(MKDIR) -p yarr
> +	$(MKDIR) -p assembler
> +	$(MKDIR) -p assembler/wtf
> +	$(MKDIR) -p assembler/jit
> +	$(MKDIR) -p assembler/assembler

Can we just stick these all in a variable somewhere and do $(MKDIR) -p $(SOMEDIRS)? (For bonus points, you could probably use $(dir $(CPPSRCS)) and derive this automatically from the sources...)
http://www.gnu.org/software/make/manual/make.html#File-Name-Functions

Comment 3

[Michael Shal [:mshal]]

The only remaining VPATH under js/src is in the third-party libffi, so we can close this bug. VPATH has been removed as part of bug 912099 and bug 875013.