Closed
Bug 680395
Opened 13 years ago
Closed 11 years ago
Eradicate VPATH abuse from js/src, Part 2
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla27
People
(Reporter: khuey, Assigned: khuey)
References
Details
Attachments
(1 file)
|
3.24 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #678867 +++
VPATH makes us slow :-/
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Attachment #554356 -
Flags: review?(ted.mielczarek)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 554356 [details] [diff] [review]
Eradicate VPATH abuse from js/src.
Review of attachment 554356 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/Makefile.in
@@ +731,5 @@
> + $(MKDIR) -p yarr
> + $(MKDIR) -p assembler
> + $(MKDIR) -p assembler/wtf
> + $(MKDIR) -p assembler/jit
> + $(MKDIR) -p assembler/assembler
Can we just stick these all in a variable somewhere and do $(MKDIR) -p $(SOMEDIRS)? (For bonus points, you could probably use $(dir $(CPPSRCS)) and derive this automatically from the sources...)
http://www.gnu.org/software/make/manual/make.html#File-Name-Functions
Attachment #554356 -
Flags: review?(ted.mielczarek) → review+
|
||
Comment 3•11 years ago
|
||
The only remaining VPATH under js/src is in the third-party libffi, so we can close this bug. VPATH has been removed as part of bug 912099 and bug 875013.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Target Milestone: --- → mozilla27
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•