Remove outdated Seamonkey Profile Migrator

RESOLVED FIXED in Firefox 9

Status

()

Firefox
Migration
--
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: marco, Assigned: marco)

Tracking

unspecified
Firefox 9
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Remove nsNetscapeProfileMigratorBase.cpp and nsNetscapeProfileMigratorBase.h.
Move code needed by Seamonkey migrator into nsSeamonkeyProfileMigrator.cpp.
(Assignee)

Comment 1

6 years ago
Created attachment 553208 [details] [diff] [review]
Patch
Attachment #553208 - Flags: review?(khuey)
Attachment #553208 - Flags: review?(benjamin)
(Assignee)

Updated

6 years ago
Attachment #553208 - Flags: review?(gavin.sharp)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 553208 [details] [diff] [review]
Patch

We don't all need to look at this.

I'll review it soon.
Attachment #553208 - Flags: review?(gavin.sharp)
Attachment #553208 - Flags: review?(benjamin)
Comment on attachment 553208 [details] [diff] [review]
Patch

I don't want to move all this code around.  We should get rid of it entirely (by killing the Seamonkey profile migrator).  If we're not willing to do that, then we should just leave it as is.
Attachment #553208 - Flags: review?(khuey) → review-
(Assignee)

Comment 4

6 years ago
I'd like to remove the Seamonkey profile migrator, if I can. Who should decide about this?

Note that removing Seamonkey profile migrator, we can also remove libreg.
(Assignee)

Updated

6 years ago
Summary: Remove Netscape Profile Migrator → Remove Seamonkey Profile Migrator
Based on the mork removal changes I suspect that migrator is really outdated, btw cc-ing Callek
(In reply to Marco Bonardo [:mak] from comment #5)
> Based on the mork removal changes I suspect that migrator is really
> outdated, btw cc-ing Callek

I bet the migrator is VERY outdated, that said I don't want to completely drop it. The ability to import from similar profiles is a big gain for both Firefox and SeaMonkey.

If it is decided (by Module Owner) that the current state of the migrator is bad enough that it must be removed, I'd like an "ok" to re-add it at a future date.

And of course, yes, Mork is outdated here, we have Places for Bookmarks and History now, and Sync support.
Does it actually import modern Seamonkey profiles though?  I would expect it's importing profiles from the suite days ... which isn't exactly useful.

Updated

6 years ago
Assignee: nobody → mar.castelluccio
(Assignee)

Comment 8

6 years ago
It imports profiles from a file saved as a Windows registry file. It's completely different from Firefox and, most probably, modern Seamonkey.
(In reply to Marco Castelluccio from comment #8)
> It imports profiles from a file saved as a Windows registry file. It's
> completely different from Firefox and, most probably, modern Seamonkey.

Yes, I just dug through some code to check what it did exactly, and then with my local computer that never had an "old" suite installed.

And I can confirm with the supported Suite versions this is dead code. And *very* dead code at that. I'll support simply dropping it at that.
(Assignee)

Updated

6 years ago
Summary: Remove Seamonkey Profile Migrator → Remove outdated Seamonkey Profile Migrator
(Assignee)

Comment 10

6 years ago
Created attachment 553518 [details] [diff] [review]
Remove Seamonkey Profile Migrator
Attachment #553208 - Attachment is obsolete: true
Attachment #553518 - Flags: review?(khuey)
kill it!
Attachment #553518 - Flags: review?(khuey) → review+
(Assignee)

Updated

6 years ago
Blocks: 679352
(Assignee)

Comment 12

6 years ago
I need someone that could send this to tryserver, before the checkin.

Comment 13

6 years ago
Try run for b291507659ba is complete.
Detailed breakdown of the results available here:
    http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=b291507659ba
Results (out of 229 total builds):
    success: 218
    warnings: 11
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/Ms2ger@gmail.com-b291507659ba
http://hg.mozilla.org/integration/mozilla-inbound/rev/241af714f92d
http://hg.mozilla.org/mozilla-central/rev/241af714f92d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9
Blocks: 706020
You need to log in before you can comment on or make changes to this bug.