Last Comment Bug 679016 - Remove outdated Seamonkey Profile Migrator
: Remove outdated Seamonkey Profile Migrator
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Migration (show other bugs)
: unspecified
: All All
: -- minor (vote)
: Firefox 9
Assigned To: Marco Castelluccio [:marco]
:
Mentors:
Depends on:
Blocks: 679352 706020
  Show dependency treegraph
 
Reported: 2011-08-15 10:07 PDT by Marco Castelluccio [:marco]
Modified: 2011-11-29 01:29 PST (History)
10 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (39.75 KB, patch)
2011-08-15 10:12 PDT, Marco Castelluccio [:marco]
khuey: review-
Details | Diff | Splinter Review
Remove Seamonkey Profile Migrator (60.61 KB, patch)
2011-08-16 10:23 PDT, Marco Castelluccio [:marco]
khuey: review+
Details | Diff | Splinter Review

Description Marco Castelluccio [:marco] 2011-08-15 10:07:12 PDT
Remove nsNetscapeProfileMigratorBase.cpp and nsNetscapeProfileMigratorBase.h.
Move code needed by Seamonkey migrator into nsSeamonkeyProfileMigrator.cpp.
Comment 1 Marco Castelluccio [:marco] 2011-08-15 10:12:12 PDT
Created attachment 553208 [details] [diff] [review]
Patch
Comment 2 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-08-15 10:14:55 PDT
Comment on attachment 553208 [details] [diff] [review]
Patch

We don't all need to look at this.

I'll review it soon.
Comment 3 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-08-16 06:56:58 PDT
Comment on attachment 553208 [details] [diff] [review]
Patch

I don't want to move all this code around.  We should get rid of it entirely (by killing the Seamonkey profile migrator).  If we're not willing to do that, then we should just leave it as is.
Comment 4 Marco Castelluccio [:marco] 2011-08-16 07:05:05 PDT
I'd like to remove the Seamonkey profile migrator, if I can. Who should decide about this?

Note that removing Seamonkey profile migrator, we can also remove libreg.
Comment 5 Marco Bonardo [::mak] 2011-08-16 07:15:01 PDT
Based on the mork removal changes I suspect that migrator is really outdated, btw cc-ing Callek
Comment 6 Justin Wood (:Callek) 2011-08-16 07:19:45 PDT
(In reply to Marco Bonardo [:mak] from comment #5)
> Based on the mork removal changes I suspect that migrator is really
> outdated, btw cc-ing Callek

I bet the migrator is VERY outdated, that said I don't want to completely drop it. The ability to import from similar profiles is a big gain for both Firefox and SeaMonkey.

If it is decided (by Module Owner) that the current state of the migrator is bad enough that it must be removed, I'd like an "ok" to re-add it at a future date.

And of course, yes, Mork is outdated here, we have Places for Bookmarks and History now, and Sync support.
Comment 7 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-08-16 07:20:48 PDT
Does it actually import modern Seamonkey profiles though?  I would expect it's importing profiles from the suite days ... which isn't exactly useful.
Comment 8 Marco Castelluccio [:marco] 2011-08-16 07:31:59 PDT
It imports profiles from a file saved as a Windows registry file. It's completely different from Firefox and, most probably, modern Seamonkey.
Comment 9 Justin Wood (:Callek) 2011-08-16 07:34:08 PDT
(In reply to Marco Castelluccio from comment #8)
> It imports profiles from a file saved as a Windows registry file. It's
> completely different from Firefox and, most probably, modern Seamonkey.

Yes, I just dug through some code to check what it did exactly, and then with my local computer that never had an "old" suite installed.

And I can confirm with the supported Suite versions this is dead code. And *very* dead code at that. I'll support simply dropping it at that.
Comment 10 Marco Castelluccio [:marco] 2011-08-16 10:23:55 PDT
Created attachment 553518 [details] [diff] [review]
Remove Seamonkey Profile Migrator
Comment 11 :Gavin Sharp [email: gavin@gavinsharp.com] 2011-08-16 18:22:19 PDT
kill it!
Comment 12 Marco Castelluccio [:marco] 2011-08-18 06:47:10 PDT
I need someone that could send this to tryserver, before the checkin.
Comment 13 Mozilla RelEng Bot 2011-08-19 08:30:44 PDT
Try run for b291507659ba is complete.
Detailed breakdown of the results available here:
    http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=b291507659ba
Results (out of 229 total builds):
    success: 218
    warnings: 11
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/Ms2ger@gmail.com-b291507659ba
Comment 15 Ed Morley [:emorley] 2011-08-21 11:39:18 PDT
http://hg.mozilla.org/mozilla-central/rev/241af714f92d

Note You need to log in before you can comment on or make changes to this bug.