67952 - Support for accessing menus by comparing with label attribute too

Status: VERIFIED DUPLICATE of bug 92491

(Core :: XUL, defect, P3)

Description

[Jan Varga [:janv]]

This bug arised from discussion in bug 67731.

Comment 1

[Jan Varga [:janv]]

adding people to CC list

Comment 2

[Jan Varga [:janv]]

Here is my suggested behavior:
1. Acceskey has top priority.
2. If we found only one menu, then we select it and enter it.
3. If we found multiple menus, then we select only first one.
4. User can type next letters to precise his search criteria

I'll attach initial patch.

Comment 3

[Jan Varga [:janv]]

Attachment: initial fix

Comment 4

[:deanis74]

Windows handles duplicate menu access keys, which default to the first 
character if one isn't explicitly defined, differently than what you propose.  
If there are two or more menu items with the same access key, pressing the key 
repeatedly will cycle through the menu items.  There is no incremental search.

Comment 5

[Jan Varga [:janv]]

ok, but do we want windows behavior ?
I prefer incremental search.

Comment 6

[Blake Ross]

I appreciate the work that went into implementing it, although I'm not sure how
necessary incremental search really is.  I think most users would just find the
item they're looking for when it gets to the point that they have to type out
half the word...

Comment 7

[timeless]

incremental search is useful for lists, but for menus i'd rather follow the 
windows behavior.

If you want to implement a useful menu access feature there's the BeOS behavior 
which dynamically assigns access keys to menu items based on a first avaailable 
algorithm. (i think that's probably filed as some other bug... i don't know 
offhand).

Comment 8

[:deanis74]

Good point.  Rather than working around a lack of access keys, it would probably
be better to determine a way of automatically assigning an access key if one
isn't assigned.

Comment 9

[Jan Varga [:janv]]

Ok, it sounds good.

Let's sumarize it:
1. We will dynamically assign access keys to menu items based on a first
   available algorithm. This can be suppressed by setting "noautoaccesskeys"
   attribute ?
2. Menulists will use incremental search.

Comment 10

[Jan Varga [:janv]]

Hmm, it would be probably better to not enable auto access keys by default.

Comment 11

[:deanis74]

*** Bug 42858 has been marked as a duplicate of this bug. ***

Comment 12

[Jesse Ruderman]

*** Bug 105201 has been marked as a duplicate of this bug. ***

Comment 13

[Matthias Versen [:Matti]]

*** Bug 110587 has been marked as a duplicate of this bug. ***

Comment 14

[Jan Varga [:janv]]

*** This bug has been marked as a duplicate of 92491 ***

Comment 15

[:deanis74]

v