682291 - Undoing a closed tab does not increment the count of open tabs in the actionbar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Using the new Tablet UI, in the actionbar we put a count of open tabs in the "show tab" button. The number is inc / dec if you open / close tabs. But it is not inc if you undo a closed tab.

Maybe we need a more fool-proof way of tracking? Can we listen for TabOpen / TabClose events?

Comment 1

[Lucas Rocha (:lucasr)]

Having a look at this one.

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Update button with number of tabs on TabOpen/TabRemove events

Comment 5

[Ed Morley [:emorley]]

Will push to inbound once try goes green:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=179780dcf805

Comment 6

[Ed Morley [:emorley]]

Previous try run failed to actually show any results and build api says that rev is 404 (no idea why), so pushed again:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=19373e00fd85

Comment 7

[Ed Morley [:emorley]]

Ok, so that try push failed to insert into the schedulerdb as well, so I've just pushed this to inbound to save spending any longer on this.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f5dc93ba0a8

Comment 8

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/5f5dc93ba0a8

Comment 9

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110926
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1