682303 - Today build is broken: jemalloc is missing (20110826)

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[[:Aureliano Buendía]]

Updating to today build broke TB with warning because "jemalloc is missing"

Reinstalling yesterday build (Mozilla/5.0 (Windows NT 6.1; rv:9.0a1) Gecko/20110825 Thunderbird/9.0a1) all is fine

Comment 1

[Mark Banner (:standard8)]

Yep, we're removing jemalloc.dll on update when we shouldn't be, investigating as to why.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

Ok, we were removing jemalloc on update when we were not meant to.

This patch makes it so that we only remove jemalloc lib when:

- On linux, all the time, as we used to have a libjemalloc.so but we don't now.
- On Windows only when MOZ_MEMORY isn't defined.
- On Mac only when MOZ_MEMORY_DARWIN isn't defined (the specific definition for Mac).

As our builds define MOZ_MEMORY when appropriate, this should now work correctly.

Comment 3

[David :Bienvenu]

Comment on attachment 556052 [details] [diff] [review]
The fix

haven't tried it, but this looks like it does what is claimed.

Comment 4

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/f66af1873d26

I'll spin up a new nightly as well.

Comment 5

[khagaroth]

Doesn't seem to be fixed for me, got this error with todays Shredder (6c8a909977d3). I got the full update as I didn't update yesterday, so that might be a factor.

Comment 6

[Mark Banner (:standard8)]

Yeah, that doesn't seem fixed, I'm investigating at the moment.

Comment 7

[Mark Banner (:standard8)]

I landed another follow-up which should fix this:

http://hg.mozilla.org/comm-central/rev/27529ca52af4

I'm watching the builds more closely this time, and there's already another windows nightly running.

Comment 8

[Mark Banner (:standard8)]

The nightly finished rebuilding, and I've confirmed update works fine now.