Closed Bug 682537 Opened 8 years ago Closed 8 years ago

[SeaMonkey] Don't remove jemalloc lib when building with MOZ_MEMORY

Categories

(SeaMonkey :: Installer, defect, blocker)

defect
Not set
blocker

Tracking

(Not tracked)

VERIFIED WORKSFORME

People

(Reporter: philip.chee, Assigned: ewong)

References

Details

Attachments

(1 obsolete file)

From Bug 682303 comment 2:

> Ok, we were removing jemalloc on update when we were not meant to.
> 
> This patch makes it so that we only remove jemalloc lib when:
> 
> - On linux, all the time, as we used to have a libjemalloc.so but we don't now.
> - On Windows only when MOZ_MEMORY isn't defined.
> - On Mac only when MOZ_MEMORY_DARWIN isn't defined (the specific definition for Mac).
> 
> As our builds define MOZ_MEMORY when appropriate, this should now work correctly.

I have a copy'n'paste patch but I'm not sure if it does the right thing as I don't understand the installer code. So I'm not taking this patch. Anyone who knows how this works better feel free to take this bug.
Assignee: installer → ewong
Status: NEW → ASSIGNED
Attachment #569917 - Flags: review?(bugspam.Callek)
It looks like this bug was superseded by bug 685480 in the meantime.
R.WorksForMe !?
Severity: normal → blocker
Summary: Don't remove jemalloc lib when building with MOZ_MEMORY → [SeaMonkey] Don't remove jemalloc lib when building with MOZ_MEMORY
Comment on attachment 569917 [details] [diff] [review]
Remove jemalloc lib when conditions are right.

sorry ewong, looks like serge is right, this is now obsolete.
Attachment #569917 - Flags: review?(bugspam.Callek) → review-
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Attachment #569917 - Attachment is obsolete: true
V.WorksForMe, per my comment 2.
Status: RESOLVED → VERIFIED
Depends on: 685480
You need to log in before you can comment on or make changes to this bug.