682537 - [SeaMonkey] Don't remove jemalloc lib when building with MOZ_MEMORY

Status: VERIFIED WORKSFORME

(SeaMonkey :: Installer, defect)

Description

[Philip Chee]

From Bug 682303 comment 2:

> Ok, we were removing jemalloc on update when we were not meant to.
> 
> This patch makes it so that we only remove jemalloc lib when:
> 
> - On linux, all the time, as we used to have a libjemalloc.so but we don't now.
> - On Windows only when MOZ_MEMORY isn't defined.
> - On Mac only when MOZ_MEMORY_DARWIN isn't defined (the specific definition for Mac).
> 
> As our builds define MOZ_MEMORY when appropriate, this should now work correctly.

I have a copy'n'paste patch but I'm not sure if it does the right thing as I don't understand the installer code. So I'm not taking this patch. Anyone who knows how this works better feel free to take this bug.

Comment 1

[Edmund Wong (:ewong)]

Attachment: Remove jemalloc lib when conditions are right.

Comment 2

[Serge Gautherie (:sgautherie)]

It looks like this bug was superseded by bug 685480 in the meantime.
R.WorksForMe !?

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 569917 [details] [diff] [review]
Remove jemalloc lib when conditions are right.

sorry ewong, looks like serge is right, this is now obsolete.

Comment 4

[Serge Gautherie (:sgautherie)]

V.WorksForMe, per my comment 2.