685480 - Port bug 680440 and bug 677501 to c-c

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Port bug 680440 and bug 677501 to c-c

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 559083 [details] [diff] [review]
Port bug 680440 and bug 677501 to c-c

A quick skim vs the dep bugs looks good here, I didn't verify character by character on these changes though. So just f+ for now.

Adding Mark to the review list, since he is pushing this to try, he can review before me possibly too. Only one review is necessary for this to land (in sync with the b-s merge)

Thanks.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Also port bug 584474, bug 644987 and bug 683875

Comment 4

[Mike Hommey [:glandium]]

Both patches are being tested on try:
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=5a8ad6c8c34d

Comment 5

[Mike Hommey [:glandium]]

*sigh* the windows build started so late that it picked a different commit from b-s, one that has bug 685798 landed, and that failed to build on that c-c try because I had reverted the c-c part of that bug because the b-s commit that was being picked before didn't have it. So we still don't have a windows result :(

Respinning.
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=c30295b18eac

Comment 6

[Mike Hommey [:glandium]]

Attachment: Also port bug 584474, bug 644987 and bug 683875

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 560344 [details] [diff] [review]
Also port bug 584474, bug 644987 and bug 683875

This should be the one, fixing linking problems on windows due to how expand_libs did change some things.
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=2194841463ef

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 560344 [details] [diff] [review]
Also port bug 584474, bug 644987 and bug 683875

Ok, I've not looked at this in precise detail, but it looks fine, especially with the try build being green.

Comment 9

[Justin Wood (:Callek)]

Landed as: http://hg.mozilla.org/comm-central/rev/5359e5422f12 and http://hg.mozilla.org/comm-central/rev/eb19b4c513e0

(In reply to Mark Banner (:standard8) from comment #8)
> Comment on attachment 560344 [details] [diff] [review]
> Also port bug 584474, bug 644987 and bug 683875
> 
> Ok, I've not looked at this in precise detail, but it looks fine, especially
> with the try build being green.

Followed by:

http://hg.mozilla.org/comm-central/rev/8094d209fa88

(I clobbered SeaMonkey win builders just in case)