If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Port bug 680440 and bug 677501 to c-c

RESOLVED FIXED in Thunderbird 9.0

Status

MailNews Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
Thunderbird 9.0
Dependency tree / graph
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird9 fixed, seamonkey2.6 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 559083 [details] [diff] [review]
Port bug 680440 and bug 677501 to c-c
Attachment #559083 - Flags: review?(bugspam.Callek)
Comment on attachment 559083 [details] [diff] [review]
Port bug 680440 and bug 677501 to c-c

A quick skim vs the dep bugs looks good here, I didn't verify character by character on these changes though. So just f+ for now.

Adding Mark to the review list, since he is pushing this to try, he can review before me possibly too. Only one review is necessary for this to land (in sync with the b-s merge)

Thanks.
Attachment #559083 - Flags: review?(mbanner)
Attachment #559083 - Flags: review?(bugspam.Callek)
Attachment #559083 - Flags: feedback+
(Assignee)

Comment 3

6 years ago
Created attachment 560154 [details] [diff] [review]
Also port bug 584474, bug 644987 and bug 683875
Attachment #560154 - Flags: review?(mbanner)
(Assignee)

Comment 4

6 years ago
Both patches are being tested on try:
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=5a8ad6c8c34d
(Assignee)

Updated

6 years ago
Attachment #560154 - Flags: feedback?(bugspam.Callek)
(Assignee)

Comment 5

6 years ago
*sigh* the windows build started so late that it picked a different commit from b-s, one that has bug 685798 landed, and that failed to build on that c-c try because I had reverted the c-c part of that bug because the b-s commit that was being picked before didn't have it. So we still don't have a windows result :(

Respinning.
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=c30295b18eac
(Assignee)

Comment 6

6 years ago
Created attachment 560344 [details] [diff] [review]
Also port bug 584474, bug 644987 and bug 683875
Attachment #560344 - Flags: review?(mbanner)
(Assignee)

Updated

6 years ago
Attachment #560154 - Attachment is obsolete: true
Attachment #560154 - Flags: review?(mbanner)
Attachment #560154 - Flags: feedback?(bugspam.Callek)
(Assignee)

Comment 7

6 years ago
Comment on attachment 560344 [details] [diff] [review]
Also port bug 584474, bug 644987 and bug 683875

This should be the one, fixing linking problems on windows due to how expand_libs did change some things.
http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=2194841463ef
Attachment #560344 - Flags: feedback?(bugspam.Callek)
Assignee: nobody → mh+mozilla
Component: Build Config → Build Config
Product: SeaMonkey → MailNews Core
QA Contact: build-config → build-config
Attachment #559083 - Flags: review?(mbanner)
Attachment #559083 - Flags: review?(bugspam.Callek)
Attachment #559083 - Flags: review+
Comment on attachment 560344 [details] [diff] [review]
Also port bug 584474, bug 644987 and bug 683875

Ok, I've not looked at this in precise detail, but it looks fine, especially with the try build being green.
Attachment #560344 - Flags: review?(mbanner) → review+
Landed as: http://hg.mozilla.org/comm-central/rev/5359e5422f12 and http://hg.mozilla.org/comm-central/rev/eb19b4c513e0

(In reply to Mark Banner (:standard8) from comment #8)
> Comment on attachment 560344 [details] [diff] [review]
> Also port bug 584474, bug 644987 and bug 683875
> 
> Ok, I've not looked at this in precise detail, but it looks fine, especially
> with the try build being green.

Followed by:

http://hg.mozilla.org/comm-central/rev/8094d209fa88

(I clobbered SeaMonkey win builders just in case)
Status: NEW → RESOLVED
Last Resolved: 6 years ago
status-seamonkey2.6: --- → fixed
status-thunderbird9: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0

Updated

6 years ago
Attachment #560344 - Flags: feedback?(bugspam.Callek)
Depends on: 696455
Flags: in-testsuite-
Version: unspecified → Trunk
Depends on: 696572
No longer depends on: 696455
Blocks: 682537
Blocks: 716395
You need to log in before you can comment on or make changes to this bug.