682741 - version number in the about box is not properly aligned in a right-to-left language

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Amir Aharoni]

Attachment: about-aurora-rtl-bug.png

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0a2) Gecko/20110828 Firefox/8.0a2
Build ID: 20110828042010

Steps to reproduce:

Used the Hebrew localized version of Firefox (Aurora), pressed Help->About, and looked at the About box.


Actual results:

The version number didn't appear correctly aligned. The closing parenthesis appeared on the wrong side, because it was defined as right-to-left.


Expected results:

The version number line should have been defined as left-to-right so that the closing parenthesis would appear at the correct end.

Comment 1

[Bill Gianopoulos [:WG9s]]

On the other hand, one might wonder exactly what the point of these parenthesis are in the first place.

Comment 2

[:Margaret Leibovic]

I reproduced this with Force RTL.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Hi Ahmed, what's the expected format of the string with the build date here in RTL (or should it depend on the language) and how should the final string look like? At the moment, "(2015-11-04) 45.0a1" is what I use in my patch.

Comment 4

[Ahmed Nefzaoui [:Nefzaoui]]

(In reply to Sebastian H. [:aryx][:archaeopteryx] from comment #3)
> Hi Ahmed, what's the expected format of the string with the build date here
> in RTL (or should it depend on the language) and how should the final string
> look like? At the moment, "(2015-11-04) 45.0a1" is what I use in my patch.

Given the Aurora logo is written in latin, I would suggest to force-LTR the version+builddate string so if it initially is
45.0a1 (2015-11-04) in LTR it should look the same in RTL. The reason for that is because we're in a non-RTL context so the user will continue reading what's after the logo the same way the read "Aurora", i.e. in LTR.
Moreover and more importantly, numbers are always read and written left-to-right in RTL environments.
So in short, I suggest the sequence of version + (build date) should stay LTR.
Thanks!

Comment 5

[Tomer Cohen :tomer]

chrome://browser/content/aboutDialog.xul - It's #version that has to be hardcoded for LTR. Please keep in mind that changing its direction does also change the paragraph alignment, so the version string won't be displayed below the wordmark (chrome://branding/content/about-wordmark.svg), and I suggest making sure that the version would be just below the wordmark.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: fx-682741-aboutDialogRtlVersion-v1.patch

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot: about dialog in Arabic with patch applied

Comment 8

[:Gijs (he/him)]

Comment on attachment 8683660 [details] [diff] [review]
fx-682741-aboutDialogRtlVersion-v1.patch

Review of attachment 8683660 [details] [diff] [review]:
-----------------------------------------------------------------

The screenshot looks like there's still margin on the element which means the right-hand-side doesn't quite line up with the other elements. Does margin-right: 0; fix that? (or padding-right; or more generally: can we fix that while we're here? :-) )

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot: about dialog in Arabic with patch applied, v2

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: fx-682741-aboutDialogRtlVersion-v2.patch

Now uses margin-right: 0; to align the text.

Comment 11

[:Gijs (he/him)]

Comment on attachment 8683705 [details] [diff] [review]
fx-682741-aboutDialogRtlVersion-v2.patch

Review of attachment 8683705 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

r=me

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2460ffa59bb6

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2460ffa59bb6

Comment 14

[Cornel Ionce [:noni] [Hubs QA]]

Confirming the fix using the Hebrew locale and the en-US one by creating a "intl.uidirection.en" and setting it's value to rtl.

Verified with latest Nightly, build ID: 20151120030227 on Windows 10 x64, Mac OS X 10.9.5 and Ubuntu 12.04 x86..