683133 - Installing/uninstalling an add-on or changing locale crashes Fennec on restart [ @0x82911cdc]

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This bug was filed from the Socorro interface and is 
report bp-3e20b126-07d1-4757-913e-243682110830 .
============================================================= 

This crash happend after installing adblock plus and restarting the browser.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This crash happened on my new Asus Transformer tablet with a fresh profile. Not sure if this could be locale dependent because others don't see the crash and my locale is set to 'de'.

Steps I did:
1. Install Nightly the first time ('de' is active)
2. Open the Add-ons Manager and install Adblock
3. Restart the browser

After step 3 the browser crashed.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Same happened now when I tried to uninstall Adblock. The browser crashed right after the restart. I haven't changed the locale.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Should we morph this bug into "Fennec crashes on any restart" ?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We have two cases now. So lets morph the summary accordingly.

Comment 6

[Doug Turner (:dougt)]

henrik, can you send me a logcat?  can you try a debug build (and send the logcat of that?)

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I'm new to Android. So I would need some more information how to achieve that. Thanks.

Comment 8

[Aaron Train [:aaronmt]]

Attachment: pid 725 (Nightly 08/30) log

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I do not  have older builds of Firefox Mobile installed on my device. Does that crash happen for anyone on Aurora, Beta, or even Release?

Comment 10

[Aaron Train [:aaronmt]]

(In reply to Henrik Skupin (:whimboo) from comment #9)
> I do not  have older builds of Firefox Mobile installed on my device. Does
> that crash happen for anyone on Aurora, Beta, or even Release?

Unable to reproduce on Aurora (08/31), nor Beta (7.0b4-build1)

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Would be nice to get the regression range for this crash then.

Comment 12

[Aaron Train [:aaronmt]]

Using STR:
1. Locale change from 'Automatic detection' -> 'DE'

Last known good: Aug 29th, 20110829055008
http://hg.mozilla.org/mozilla-central/rev/33031c875984

First known bad: Aug 30th, 20110830032952
http://hg.mozilla.org/mozilla-central/rev/e6591ea9b27b

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=33031c875984&tochange=e6591ea9b27b

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks like it has been caused by the landing of the Type Inference patches. David and Brian, could you please check?

Comment 14

[Brian Hackett [Laid off!]]

What happens on a debug build, and what is the stack?

Comment 15

[Aaron Train [:aaronmt]]

(In reply to Brian Hackett from comment #14)
> What happens on a debug build, and what is the stack?
I can't reproduce this in a debug build.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Brian, is there a way to turn of TI via a preference?

Comment 17

[Brian Hackett [Laid off!]]

Currently, TI is always off on ARM (working on fixing that, bug 669715).  There are supporting changes to the VM though that are not pref'able.  To figure out whether one of these is the problem, I need more information about where the crash is occurring.  Can you get a stack?

Comment 18

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: logcat

received crash : https://crash-stats.mozilla.com/report/index/6f729417-73ca-4c32-9706-dbfd82110901
Using: http://hg.mozilla.org/mozilla-central/rev/005bce677a00 
From : http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-central-android/1314757654/

This is on a HTC Thunderbolt; Android 2.2

Comment 19

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: logcat debug

Assertions in logcat for debug build
Build used : http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-central-linux-android-debug/1314780479/
Android : 2.2 Thunderbolt

Comment 20

[Aaron Train [:aaronmt]]

Simpler STR: Disable Feedback extension, reboot.

Comment 21

[(not currently active) Ted Mielczarek]

Attachment: Stack scan

I don't know if this is useful, but I ran the dump in comment 0 through this tool:
http://hg.mozilla.org/users/tmielczarek_mozilla.com/dump-lookup/

Which simply looks at every address on the stack of the crashing thread and prints those that are within loaded modules, filling in source information if available.

Comment 22

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I can't seem to reproduce the crash with the given STR with the latest nightly
Mozilla/5.0 (Android; Linux armv7I; rv:9.0a1) Gecko/20110907 Firefox/9.0a1 Fennec/9.0a1

Toshiba Thrive 3.1, HTC Flyer 2.3

Comment 23

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Same here. Has another TM merge fixed that issue?

Comment 24

[Brian Hackett [Laid off!]]

Does this still crash with the 9/6 nightly?  Before the 9/7 nightly there was a merge from the JM branch to m-c that pulled in a bunch of TI bug fixes, it would be nice if one of those also fixed this bug.

Comment 25

[Andreea Pod]

Not reproducible anymore starting with build: Mozilla /5.0 (Android;Linux armv7l;rv:9.0a1) Gecko/20110905 Firefox/9.0a1 Fennec/9.0a1
Device: LG Optimus 2X (Andriud 2.2)

Comment 26

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Andreea. That would give us the following changesets:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a351ae35f2c4&tochange=2bb8c0b664cf

Brian, anything you could imagine which has been fixed this crash?

Closing as WFM for now unless we know which patch fixed it.