683400 - SandboxDump should flush stderr after writing output

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: flush stderr after writing dump() output to it.

When a script in an XPConnect sandbox calls dump(), the string is written to stderr but that stream is not flushed.  This is a problem when the program output is redirected and stderr is buffered - the string may not appear in the output until after the buffer is full or the program terminates.  We are seeing this problem in Jetpack via bug 665250.

Note that bug 489938 added the flush to nsGlobalWindow.cpp, so dump() called from content is already flushed.

Attaching a single line patch to flush stderr after writing the output.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 557051 [details] [diff] [review]
flush stderr after writing dump() output to it.

Requesting review from Blake as the module owner.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Thanks Blake - can you recommend someone to offer sr?  And please excuse my ignorance of the current process, but after an sr, is the next step for me to just push it to mozilla-central?

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Been told in #developers that an sr isn't required on this bug, so once my hg account gets reactivated I'll push it to mozilla-incoming.

Comment 4

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/891362a930b0

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/891362a930b0

Comment 6

[Ed Morley [:emorley]]

Not sure if this or bug 687696 is responsible for the recent Ts regression:

https://groups.google.com/forum/#!topic/mozilla.dev.tree-management/WOlX-ghe0H4

http://graphs-new.mozilla.org/graph.html#tests=[[54,63,14],[54,63,15]]&sel=1316423909867.185,1316699577328&displayrange=7&datatype=running