The default bug view has changed. See this FAQ.

Sign NSS libraries from packager.mk

RESOLVED FIXED in mozilla9

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla9
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
For some reason that is beyond me, osx64 crashes in shlibsign when it happens from security/manager when jemalloc is enabled *and* bug 680440 is applied. As bug 680440 will land and jemalloc is going to be enabled, this is going to be a problem. It turns out shlibsign does *not* crash when called from packager.mk.

We actually also have code for signing in packager.mk, because we need to on universal builds, and we also need to on builds where we strip the binaries. In the end, we just can completely get rid of the signing in security/manager and unconditionally sign in packager.mk.
(Assignee)

Comment 1

6 years ago
Created attachment 557098 [details] [diff] [review]
Always sign NSS libraries from packager.mk

Testing this on try:
http://tbpl.allizom.org/?usebuildbot=1&tree=Try&rev=d2406ac8bc34
Attachment #557098 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 2

6 years ago
Created attachment 557105 [details] [diff] [review]
Always sign NSS libraries from packager.mk

The part actually avoiding the chk creation from nss was missing.
http://tbpl.allizom.org/?usebuildbot=1&tree=Try&rev=d0cb5651b586
Attachment #557105 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

6 years ago
Attachment #557098 - Attachment is obsolete: true
Attachment #557098 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 3

6 years ago
Created attachment 557317 [details] [diff] [review]
Always sign NSS libraries from packager.mk

Refreshed against current m-c
Attachment #557317 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

6 years ago
Attachment #557105 - Attachment is obsolete: true
Attachment #557105 - Flags: review?(ted.mielczarek)
Comment on attachment 557317 [details] [diff] [review]
Always sign NSS libraries from packager.mk

Review of attachment 557317 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/manager/Makefile.in
@@ +234,5 @@
>  # Disable building of the test programs in security/nss/lib/zlib
>  DEFAULT_GMAKE_FLAGS += PROGRAMS=
>  
> +# Disable creating .chk files. They will be generated from packager.mk
> +DEFAULT_GMAKE_FLAGS += CHECKLOC=

Can you put a comment here about how we should use the stuff from bug 681624 if it lands?
Attachment #557317 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → mh+mozilla
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/projects/build-system/rev/d5c28f481dc3
Whiteboard: fixed-in-bs
https://hg.mozilla.org/mozilla-central/rev/d5c28f481dc3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla9

Updated

5 years ago
Depends on: 706042

Updated

5 years ago
No longer depends on: 706042
Depends on: 694353
You need to log in before you can comment on or make changes to this bug.