683441 - Sign NSS libraries from packager.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

For some reason that is beyond me, osx64 crashes in shlibsign when it happens from security/manager when jemalloc is enabled *and* bug 680440 is applied. As bug 680440 will land and jemalloc is going to be enabled, this is going to be a problem. It turns out shlibsign does *not* crash when called from packager.mk.

We actually also have code for signing in packager.mk, because we need to on universal builds, and we also need to on builds where we strip the binaries. In the end, we just can completely get rid of the signing in security/manager and unconditionally sign in packager.mk.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Always sign NSS libraries from packager.mk

Testing this on try:
http://tbpl.allizom.org/?usebuildbot=1&tree=Try&rev=d2406ac8bc34

Comment 2

[Mike Hommey [:glandium]]

Attachment: Always sign NSS libraries from packager.mk

The part actually avoiding the chk creation from nss was missing.
http://tbpl.allizom.org/?usebuildbot=1&tree=Try&rev=d0cb5651b586

Comment 3

[Mike Hommey [:glandium]]

Attachment: Always sign NSS libraries from packager.mk

Refreshed against current m-c

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 557317 [details] [diff] [review]
Always sign NSS libraries from packager.mk

Review of attachment 557317 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/manager/Makefile.in
@@ +234,5 @@
>  # Disable building of the test programs in security/nss/lib/zlib
>  DEFAULT_GMAKE_FLAGS += PROGRAMS=
>  
> +# Disable creating .chk files. They will be generated from packager.mk
> +DEFAULT_GMAKE_FLAGS += CHECKLOC=

Can you put a comment here about how we should use the stuff from bug 681624 if it lands?

Comment 5

[Mike Hommey [:glandium]]

http://hg.mozilla.org/projects/build-system/rev/d5c28f481dc3

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/d5c28f481dc3