Clean up jemalloc linkage

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 attachment, 7 obsolete attachments)

There are currently four different ways jemalloc can be linked against (basically, one for each tier-1 platform), and none of them use the same hooks and variables.
Depends on: 680373
Assignee: nobody → mh+mozilla
Created attachment 554425 [details] [diff] [review]
Clean up jemalloc linkage

Testing this patch on try: http://tbpl.allizom.org/?usebuildbot=1&tree=Try&rev=36608887cdac
Created attachment 554445 [details] [diff] [review]
Clean up jemalloc linkage

This one should work better
http://tbpl.allizom.org/?usebuildbot=1&tree=Try&rev=05a3cf10577e
Attachment #554425 - Attachment is obsolete: true
Created attachment 554480 [details] [diff] [review]
Clean up jemalloc linkage
Attachment #554445 - Attachment is obsolete: true
Depends on: 680848
No longer depends on: 680848
Depends on: 681588
Created attachment 555747 [details] [diff] [review]
Clean up jemalloc linkage
Attachment #555747 - Flags: review?(khuey)
Attachment #554480 - Attachment is obsolete: true
Created attachment 555754 [details] [diff] [review]
Clean up jemalloc linkage
Attachment #555754 - Flags: review?(khuey)
Attachment #555747 - Attachment is obsolete: true
Attachment #555747 - Flags: review?(khuey)
Created attachment 555755 [details] [diff] [review]
Clean up jemalloc linkage
Attachment #555755 - Flags: review?(khuey)
Attachment #555754 - Attachment is obsolete: true
Attachment #555754 - Flags: review?(khuey)
Created attachment 555766 [details] [diff] [review]
Clean up jemalloc linkage
Attachment #555766 - Flags: review?(khuey)
Attachment #555755 - Attachment is obsolete: true
Attachment #555755 - Flags: review?(khuey)
Blocks: 678977

Comment 8

6 years ago
Comment on attachment 555766 [details] [diff] [review]
Clean up jemalloc linkage

This is a lovely cleanup. I was just rooting through some of this stuff to try to solve some linker issues on bug 414946, and this would have saved me quite some time and mental energy.
Depends on: 683441
Comment on attachment 555766 [details] [diff] [review]
Clean up jemalloc linkage

I looked hard for something to complain about, but it's so much better than the gunk we have no that I couldn't really come up with anything.

r=me
Attachment #555766 - Flags: review?(khuey) → review+
Created attachment 557321 [details] [diff] [review]
Clean up jemalloc linkage

Refreshed against m-c (only context changes)
Attachment #555766 - Attachment is obsolete: true
http://hg.mozilla.org/projects/build-system/rev/805e28e85577
Whiteboard: fixed-in-bs
http://hg.mozilla.org/mozilla-central/rev/805e28e85577
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
The whole b-s merge backed out of m-c for causing bustage:
http://hg.mozilla.org/mozilla-central/rev/472716252ea3

https://tbpl.mozilla.org/?usebuildbot=1&rev=e5815c156b6c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: fixed-in-bs
The backout was backed out on b-s.
Whiteboard: fixed-in-bs
Blocks: 685480
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Depends on: 706042
You need to log in before you can comment on or make changes to this bug.