Closed Bug 680440 Opened 9 years ago Closed 9 years ago

Clean up jemalloc linkage

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 file, 7 obsolete files)

There are currently four different ways jemalloc can be linked against (basically, one for each tier-1 platform), and none of them use the same hooks and variables.
Depends on: 680373
Assignee: nobody → mh+mozilla
Attachment #554425 - Attachment is obsolete: true
Attached patch Clean up jemalloc linkage (obsolete) — Splinter Review
Attachment #554445 - Attachment is obsolete: true
Depends on: 680848
No longer depends on: 680848
Depends on: 681588
Attached patch Clean up jemalloc linkage (obsolete) — Splinter Review
Attachment #555747 - Flags: review?(khuey)
Attachment #554480 - Attachment is obsolete: true
Attached patch Clean up jemalloc linkage (obsolete) — Splinter Review
Attachment #555754 - Flags: review?(khuey)
Attachment #555747 - Attachment is obsolete: true
Attachment #555747 - Flags: review?(khuey)
Attached patch Clean up jemalloc linkage (obsolete) — Splinter Review
Attachment #555755 - Flags: review?(khuey)
Attachment #555754 - Attachment is obsolete: true
Attachment #555754 - Flags: review?(khuey)
Attached patch Clean up jemalloc linkage (obsolete) — Splinter Review
Attachment #555766 - Flags: review?(khuey)
Attachment #555755 - Attachment is obsolete: true
Attachment #555755 - Flags: review?(khuey)
Comment on attachment 555766 [details] [diff] [review]
Clean up jemalloc linkage

This is a lovely cleanup. I was just rooting through some of this stuff to try to solve some linker issues on bug 414946, and this would have saved me quite some time and mental energy.
Depends on: 683441
Comment on attachment 555766 [details] [diff] [review]
Clean up jemalloc linkage

I looked hard for something to complain about, but it's so much better than the gunk we have no that I couldn't really come up with anything.

r=me
Attachment #555766 - Flags: review?(khuey) → review+
Refreshed against m-c (only context changes)
Attachment #555766 - Attachment is obsolete: true
The whole b-s merge backed out of m-c for causing bustage:
http://hg.mozilla.org/mozilla-central/rev/472716252ea3

https://tbpl.mozilla.org/?usebuildbot=1&rev=e5815c156b6c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: fixed-in-bs
The backout was backed out on b-s.
Whiteboard: fixed-in-bs
Blocks: 685480
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Depends on: 706042
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.