685537 - [HKb] Fn key + key is not working properly on Desire Z's Android keyboard

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Carla Nadastean]

Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110908 Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire Z
OS: Android 2.3

Steps to reproduce:
1. Open Fennec app.
2. Use the HKb to browse to a website which name contains special characters or numbers. 
For the special characters or number use the Fn key + special character key.

Expected Result:
Special characters and numbers are inserted when using Fn key.

Actual Result:
Special characters and numbers can't be inserted using Fn key.

NOTE:
Bug is only reproducible in Fennec app. Fn key works properly in other app. (e.g Twitter)

Comment 1

[Carla Nadastean]

Bug not reproducible with:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110904
Firefox/9.0a1 Fennec/9.0a1
http://hg.mozilla.org/mozilla-central/rev/a351ae35f2c4

Bug reproducible with:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110905
Firefox/9.0a1 Fennec/9.0a1
http://hg.mozilla.org/mozilla-central/rev/2bb8c0b664cf

Comment 2

[Aaron Train [:aaronmt]]

Likely bug 676195

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a351ae35f2c4&tochange=2bb8c0b664cf

Comment 4

[Makoto Kato [:m_kato]]

It seems that function key define is from API LV11....  I think HTC desire Z sends custom key code for fn key.

Carla, could you put the log when you press fn key (and  Fn key + special character key) using http://code.google.com/p/adosbox/downloads/detail?name=KeyCodeRecorder.apk?

Comment 5

[Carla Nadastean]

Here are the results when I press Fn key only:

KeyEvent{action=0 code=57 repeat=0 meta=18 scancode=56 mFlags=8}
KeyEvent{action=1 code=57 repeat=0 meta=0 scancode=56 mFlags=8}


Here are the results when I press Fn key + H key (for special character "*"):

KeyEvent{action=0 code=57 repeat=0 meta=18 scancode=56 mFlags=8}
KeyEvent{action=0 code=36 repeat=0 meta=18 scancode=35 mFlags=8}
*KeyEvent{action=1 code=36 repeat=0 meta=18 scancode=35 mFlags=8}
KeyEvent{action=1 code=57 repeat=0 meta=0 scancode=56 mFlags=8}

Comment 6

[Makoto Kato [:m_kato]]

(In reply to Carla Nadastean from comment #5)
> Here are the results when I press Fn key only:
> 
> KeyEvent{action=0 code=57 repeat=0 meta=18 scancode=56 mFlags=8}
> KeyEvent{action=1 code=57 repeat=0 meta=0 scancode=56 mFlags=8}
> 
> 
> Here are the results when I press Fn key + H key (for special character "*"):
> 
> KeyEvent{action=0 code=57 repeat=0 meta=18 scancode=56 mFlags=8}
> KeyEvent{action=0 code=36 repeat=0 meta=18 scancode=35 mFlags=8}
> *KeyEvent{action=1 code=36 repeat=0 meta=18 scancode=35 mFlags=8}
> KeyEvent{action=1 code=57 repeat=0 meta=0 scancode=56 mFlags=8}

Thanks, Carla.  It seems that desire z uses ALT key code for Fn key.  On Android 2.2 (Milestone) works ALT key after IME fix.  It is strength.

One more question.  What's selected keyboard?  If installing another IME such as OpenWnn, is it same result on Nightly?

Comment 7

[Makoto Kato [:m_kato]]

Carla, could you test ftp://ftp.mozilla.org/pub/firefox/try-builds/[e-mail]-34d9f31d6527/try-android/fennec-9.0a1.en-US.android-arm.apk?

Comment 8

[Andreea Pod]

(In reply to Makoto Kato from comment #7)
> Carla, could you test
> ftp://ftp.mozilla.org/pub/firefox/try-builds/[e-mail]-
> 34d9f31d6527/try-android/fennec-9.0a1.en-US.android-arm.apk?

Makoto, using that build all works as expected and also using OpenWnn IME.

Comment 9

[Camelia Urian]

(In reply to Makoto Kato from comment #7)
> Carla, could you test
> ftp://ftp.mozilla.org/pub/firefox/try-builds/[e-mail]-
> 34d9f31d6527/try-android/fennec-9.0a1.en-US.android-arm.apk?

I verified build on Motorola DROID2 - Android 2.3, which has ALT key for numbers and special characters. There is one scenario when issue is still reproducing.
Steps:
1. Start Fennec with a clear profile in portrait mode.
2. Tap URL bar and rotate to landscape.
3. Go to www.google.com
4. Tap on search field, hold ALT key pressed and type any number or special character.
 RESULT: Nothing happens - no character is inserted.

5. Press "ALT-Lock".
6. Type any number or special character
 RESULT: Letter is inserted instead of number or special character

Note: 
 After rotating to portrait and back to landscape, both ALT and ALT-Lock keys work correctly.




When keeping ALT key pressed and typing a number nothing happens

Comment 10

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 560529 [details] [diff] [review]
fix

Thanks!

Comment 12

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ceafc572c5ad

Comment 13

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/ceafc572c5ad

Comment 14

[Makoto Kato [:m_kato]]

Comment on attachment 560529 [details] [diff] [review]
fix

requesting for bug 676195.  This is needed to approve bug 676195.

Comment 15

[Camelia Urian]

Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110922 Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire Z
OS: Android 2.3

Verified this on above environment:

1. Open Fennec with a clean profile and go to www.google.com
2. Tap text field and use HKB for the next steps.
3. Type "abc"
4. Press and hold FN key and numbers or special characters(for eg:123)

Actual results: "123" is displayed before "abc": 123abc
Expected results: "123" is displayed after "abc": "abc123"

5. Move cursor at the end (after "123abc") and type some letters, for eg: "def".

Actual results: "d" is type after "c", then cursor jumps after "a", so now you have displayed: "123aefbcd"

6. Move cursor again to the end and use FN key to type "456

Actual results:  Cursor jumps after the last typed number "3", so now you have displayed: "123456aefbcd"


Notes: 
 - Every time you move cursor at the end of the typed string, after pressing one letter cursor is jumped somewhere in the middle of the string, and if typing a number/special character, cursor is jumped after the previously typed number/special character.

 - SHIFT key is also not working. When pressing SHIFT+letter ->lower case letter is displayed. I'm not sure if this is a new issue, or related to same bug.

Comment 16

[Makoto Kato [:m_kato]]

(In reply to Camelia Urian from comment #15)
> Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110922
> Firefox/9.0a1 Fennec/9.0a1
> Device: HTC Desire Z
> OS: Android 2.3
> 
> Verified this on above environment:
> 
> 1. Open Fennec with a clean profile and go to www.google.com
> 2. Tap text field and use HKB for the next steps.
> 3. Type "abc"
> 4. Press and hold FN key and numbers or special characters(for eg:123)
> 
> Actual results: "123" is displayed before "abc": 123abc
> Expected results: "123" is displayed after "abc": "abc123"
> 
> 5. Move cursor at the end (after "123abc") and type some letters, for eg:
> "def".
> 
> Actual results: "d" is type after "c", then cursor jumps after "a", so now
> you have displayed: "123aefbcd"
> 
> 6. Move cursor again to the end and use FN key to type "456
> 
> Actual results:  Cursor jumps after the last typed number "3", so now you
> have displayed: "123456aefbcd"
> 
> 
> Notes: 
>  - Every time you move cursor at the end of the typed string, after pressing
> one letter cursor is jumped somewhere in the middle of the string, and if
> typing a number/special character, cursor is jumped after the previously
> typed number/special character.
> 
>  - SHIFT key is also not working. When pressing SHIFT+letter ->lower case
> letter is displayed. I'm not sure if this is a new issue, or related to same
> bug.

This is another issue and isn't related to meta key issue.  When key event by onKeyDown occurs during composing, composing string isn't commited at this time, this issue occurs.  Before my fix, this will occurs.

Please file new bug.

Comment 17

[Makoto Kato [:m_kato]]

Camelia, after filing bugs, please assign it to me.

Comment 18

[Camelia Urian]

Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110923 Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire Z
OS: Android 2.3

I was able to reproduce issue with the following steps:

1. Start Fennec with a clear profile in portrait mode.
2. Rotate to landscape and use HKB for the next steps.
3. Go to www.google.com
4. Tap on search field, hold FN key pressed and type any number or special character.
 RESULT: Nothing happens - no character is inserted.

5. Press "FN" twice to lock FN key.
6. Type any number or special character
 RESULT: Letter is inserted instead of number or special character

Note: 
  - After rotating to portrait and back to landscape, FN key works but bug #688737 is reproducing.
  - When FN key is not working, SHIFT key is working, and after rotating device to portrait and back to landscape  SHIFT key is not working anymore.

Comment 19

[Makoto Kato [:m_kato]]

Camelia, could you put the log using comment #4's way when you type repro step?  Also what IME do you use?

Desire Z has customized keyboard.  This is *not reproduced* on my milestone and other ARM/x86 development board.

Comment 20

[Makoto Kato [:m_kato]]

Also, Desire Z seems to have a bug for KeyListener class.  If meta key is working well as other Android devices, this hack isn't needed.

Comment 21

[Camelia Urian]

Carla Nadastean(reporter) 2 weeks ago

Here are the results when I press Fn key only:

KeyEvent{action=0 code=57 repeat=0 meta=18 scancode=56 mFlags=8}
KeyEvent{action=1 code=57 repeat=0 meta=0 scancode=56 mFlags=8}

Here are the results when I press Fn key + T key (for  "5"):

KeyEvent{action=0 code=57 repeat=0 meta=18 scancode=56 mFlags=8}
KeyEvent{action=0 code=48 repeat=0 meta=18 scancode=20 mFlags=8}
*KeyEvent{action=1 code=48 repeat=0 meta=18 scancode=20 mFlags=8}
KeyEvent{action=1 code=57 repeat=0 meta=0 scancode=56 mFlags=8}

Comment 22

[Camelia Urian]

Please disregard 1st line from previous comment.

Also we were able to reproduce issue as described in comment 18 on Motorola DROID2 - Android 2.3 with same Fennec build.

Comment 23

[Makoto Kato [:m_kato]]

(In reply to Camelia Urian from comment #21)
> Carla Nadastean(reporter) 2 weeks ago
> 
> Here are the results when I press Fn key only:
> 
> KeyEvent{action=0 code=57 repeat=0 meta=18 scancode=56 mFlags=8}
> KeyEvent{action=1 code=57 repeat=0 meta=0 scancode=56 mFlags=8}
> 
> Here are the results when I press Fn key + T key (for  "5"):
> 
> KeyEvent{action=0 code=57 repeat=0 meta=18 scancode=56 mFlags=8}
> KeyEvent{action=0 code=48 repeat=0 meta=18 scancode=20 mFlags=8}
> *KeyEvent{action=1 code=48 repeat=0 meta=18 scancode=20 mFlags=8}
> KeyEvent{action=1 code=57 repeat=0 meta=0 scancode=56 mFlags=8}

This log is invalid for you step.  I need step 4-6 log of comment #18.  The lock state is difference.

Comment 24

[Makoto Kato [:m_kato]]

Camelia, could you test http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-397f45e838b5/try-android/fennec-9.0a1.en-US.android-arm.apk?

Comment 25

[Makoto Kato [:m_kato]]

Comment on attachment 560529 [details] [diff] [review]
fix

cancel approval-aurora since I have to consider meta lock state again.

Comment 26

[Camelia Urian]

Device: HTC Desire Z
OS: Android 2.3

Makoto, I tried your build, here are the results:

1. Start Fennec with a clear profile in portrait mode.
2. Rotate to landscape and use HKB for the next steps.
3. Go to www.google.com
4. Tap on search field, hold FN key pressed and type any number or special character.
 RESULT: Nothing happens - no character is inserted.

5. Press "FN" twice to lock FN key.
6. Type any number or special character
 RESULT: Letter is inserted instead of number or special character

Note: 
  - After rotating to portrait and back to landscape, FN key working correctly
  - When FN key is not working, SHIFT key is working, and after rotating device to portrait and back to landscape  SHIFT key is not working anymore.
  - FN key lock and SHIFT key lock do not work at all.

Comment 27

[Makoto Kato [:m_kato]]

Camelia, I have created new test build. Could you test the following package for this?

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-a4a0e8b25490/try-android/fennec-10.0a1.en-US.android-arm.apk

Comment 28

[Camelia Urian]

Device: HTC Desire Z
OS: Android 2.3

Makoto, I tried your build, here are the results:

1. Start Fennec with a clear profile in portrait mode.
2. Rotate to landscape and use HKB for the next steps.
3. Go to www.google.com
4. Tap on search field, hold FN key pressed and type any number or special character.
 RESULT: Letter is inserted instead of number or special character.

5. Press "FN" twice to lock FN key.
6. Type any number or special character
 RESULT: Letter is inserted instead of number or special character

4. Hold SHIFT key pressed (or press SHIFT key twice)and type any letter.
 RESULT: Lower case letter is inserted instead of upper case letter.

Notes: 
 - Rotating device to portrait and back to landscape, does NOT make FN and SHIFT key work.
 - Using SYM key to insert a special character makes both FN/SHIFT(and FN/SHIFT lock) keys work correctly. After rotating device to portrait and back to landscape FN/SHIFT keys stop working. Using SYM key again will make FN/SHIFT keys work...

Comment 29

[Makoto Kato [:m_kato]]

Camelia, thanks for testing.  Humm, about looking log, this keyevent hasn't software flag.  And I cannot reproduce this on my milestone (2.2 and CM7 2.3)... It is strange.

What IME/keyboard do you use for reproducing?  Although I ask you at comment #19, you doesn't answer it.

If using OpenWnn or Shimeji, can you reproduce it?

Comment 30

[Camelia Urian]

I used device default keyboard(Touch Input) for steps from comment 28.

I tried using OpenWnn/Flick IME and issue did not reproduce.

Comment 31

[Makoto Kato [:m_kato]]

Thanks.

TextWatcher doesn't work on Desire Z's default keyboard.  So Fennec cannot handle meta and other special key well.  This is bug of desire z's android.

http://stackoverflow.com/questions/6997519/desire-z-with-2-3-3-textwatcher-not-working-bug-in-stock-keyboard

When I tested on Milestone, emulator and some devices except to Desire Z, it works well.  I am investigating a workaround for Desire Z.

Comment 32

[Makoto Kato [:m_kato]]

Today I get Desire Z, then I start to debug.  Touch Input is too buggy for input method implementation.

- HTC Touch Input can use Input method, but, when it sends text by commitText, text without meta state.  So meta state is ignore on Touch Input.
- When I install other IME, it works fine.

Although I am still investigating this for workaround of HTC's bug, we may add blacklist for Touch Input.

Comment 33

[Makoto Kato [:m_kato]]

Attachment: fix v2

Comment 34

[Makoto Kato [:m_kato]]

Attachment: fix v2.1

Comment 35

[Alex Pakhotin (:alexp)]

Comment on attachment 566740 [details] [diff] [review]
fix v2.1


>+        if (!mComposing &&
>+            text != null && text.length() == 1 &&
>+            newCursorPosition == 1) {
>+            // When using HTC touch input, text parameter may be incorrect
>+            // since it has no meta key state (shift, alt or etc).
>+            // So we have to send key event to getting correct text.
>+            if (mKeyCharMap == null)
>+                mKeyCharMap = KeyCharacterMap.load(KeyCharacterMap.BUILT_IN_KEYBOARD);
>+            char[] chars = new char[1];
>+            chars[0] = text.charAt(0);
>+            KeyEvent[] events = mKeyCharMap.getEvents(chars);
>+            if (events != null) {
>+                for (int i = 0; i < events.length; i++)
>+                    sendKeyEvent(events[i]);
>+                return true;
>+            }
>+        }

This code looks too hacky to me, and has some issues:
- KeyCharacterMap.load() may throw an exception, which is not caught here.
- Also, that load function is called for any IME at the beginning of a composition. If it fails (and exception is handled), this will be happening on every composition. If the KeyCharacterMap was loaded successfully, the mKeyCharMap.getEvents() again will be called on every composition regardless of the IME used. None of these calls and checks is really needed for all IME's except only the HTC Desire Z hardware keyboard, so I think we should try to look for another workaround.

Comment 36

[Makoto Kato [:m_kato]]

(In reply to Alex Pakhotin (:alexp) from comment #35)
> Comment on attachment 566740 [details] [diff] [review] [diff] [details] [review]
> fix v2.1
> 
> 
> >+        if (!mComposing &&
> >+            text != null && text.length() == 1 &&
> >+            newCursorPosition == 1) {
> >+            // When using HTC touch input, text parameter may be incorrect
> >+            // since it has no meta key state (shift, alt or etc).
> >+            // So we have to send key event to getting correct text.
> >+            if (mKeyCharMap == null)
> >+                mKeyCharMap = KeyCharacterMap.load(KeyCharacterMap.BUILT_IN_KEYBOARD);
> >+            char[] chars = new char[1];
> >+            chars[0] = text.charAt(0);
> >+            KeyEvent[] events = mKeyCharMap.getEvents(chars);
> >+            if (events != null) {
> >+                for (int i = 0; i < events.length; i++)
> >+                    sendKeyEvent(events[i]);
> >+                return true;
> >+            }
> >+        }
> 
> This code looks too hacky to me, and has some issues:
> - KeyCharacterMap.load() may throw an exception, which is not caught here.
> - Also, that load function is called for any IME at the beginning of a
> composition. If it fails (and exception is handled), this will be happening
> on every composition. If the KeyCharacterMap was loaded successfully, the
> mKeyCharMap.getEvents() again will be called on every composition regardless
> of the IME used. None of these calls and checks is really needed for all
> IME's except only the HTC Desire Z hardware keyboard, so I think we should
> try to look for another workaround.

This idea is used by BaseInputConnection.commitText on Android 2.3.  I use another approach that uses blacklist.

Comment 37

[Makoto Kato [:m_kato]]

Attachment: fix v3

Comment 38

[Alex Pakhotin (:alexp)]

Comment on attachment 567988 [details] [diff] [review]
fix v3

>+    public static boolean isBlacklistHKBIME()
>+    {
>+        // When using HTC touch inpu with hardware keyboardt, commitText is
>+        // called with invalid string that has no meta state.

Fix the comment: // When using HTC touch input with hardware keyboard, commitText is

>+        // So we disable IME for it.
>+        String current = Settings.Secure.getString(GeckoApp.surfaceView.getContext().getContentResolver(), Settings.Secure.DEFAULT_INPUT_METHOD);
>+        if (current.equals("com.htc.android.htcime/.HTCIMEService"))
>+            return true;

Does that Settings.Secure.getString() call always return the "com.htc.android.htcime/.HTCIMEService" string on Desire Z, or only when the hardware keyboard is being used?
I mean - wouldn't it be possible to get that string once and save the comparison result to a static boolean flag?

>         if (isPreIme && mIMEState != IME_STATE_DISABLED &&
>-            (event.getMetaState() & KeyEvent.META_ALT_ON) == 0)
>+            !GeckoInputConnection.isBlacklistHKBIME())
>             // Let active IME process pre-IME key events
>             return false;

How does this change affect other keyboards, for which that check for KeyEvent.META_ALT_ON was used?

Comment 39

[Alex Pakhotin (:alexp)]

Comment on attachment 560529 [details] [diff] [review]
fix

>-        if (isPreIme && mIMEState != IME_STATE_DISABLED)
>+        if (isPreIme && mIMEState != IME_STATE_DISABLED &&
>+            (event.getMetaState() & KeyEvent.META_ALT_ON) == 0)
>             // Let active IME process pre-IME key events
>             return false;

I don't understand what is being checked here. If we want to check if the ALT mode is on, I guess it has to be "not equal":
            (event.getMetaState() & KeyEvent.META_ALT_ON) != 0)

Jim, Makoto, could you clarify please?

Comment 40

[Makoto Kato [:m_kato]]

(In reply to Alex Pakhotin (:alexp) from comment #39)
> Comment on attachment 560529 [details] [diff] [review] [diff] [details] [review]
> fix
> 
> >-        if (isPreIme && mIMEState != IME_STATE_DISABLED)
> >+        if (isPreIme && mIMEState != IME_STATE_DISABLED &&
> >+            (event.getMetaState() & KeyEvent.META_ALT_ON) == 0)
> >             // Let active IME process pre-IME key events
> >             return false;
> 
> I don't understand what is being checked here. If we want to check if the
> ALT mode is on, I guess it has to be "not equal":
>             (event.getMetaState() & KeyEvent.META_ALT_ON) != 0)
> 
> Jim, Makoto, could you clarify please?

Although this is workaround for this bug, I wants to remove since adding HTC touch to blacklist.  This isn't good fix due to comment #28.

Comment 41

[Makoto Kato [:m_kato]]

(In reply to Alex Pakhotin (:alexp) from comment #38)
> Comment on attachment 567988 [details] [diff] [review] [diff] [details] [review]
> fix v3
> 
> >+    public static boolean isBlacklistHKBIME()
> >+    {
> >+        // When using HTC touch inpu with hardware keyboardt, commitText is
> >+        // called with invalid string that has no meta state.
> 
> Fix the comment: // When using HTC touch input with hardware keyboard,
> commitText is
> 
> >+        // So we disable IME for it.
> >+        String current = Settings.Secure.getString(GeckoApp.surfaceView.getContext().getContentResolver(), Settings.Secure.DEFAULT_INPUT_METHOD);
> >+        if (current.equals("com.htc.android.htcime/.HTCIMEService"))
> >+            return true;
> 
> Does that Settings.Secure.getString() call always return the
> "com.htc.android.htcime/.HTCIMEService" string on Desire Z, or only when the
> hardware keyboard is being used?

This value depends current selected IME.  Also, this check for blacklist is for onKeyDown only, no effect on software keyborad.


> I mean - wouldn't it be possible to get that string once and save the
> comparison result to a static boolean flag?

Can we get observe when changing IME?


> >         if (isPreIme && mIMEState != IME_STATE_DISABLED &&
> >-            (event.getMetaState() & KeyEvent.META_ALT_ON) == 0)
> >+            !GeckoInputConnection.isBlacklistHKBIME())
> >             // Let active IME process pre-IME key events
> >             return false;
> 
> How does this change affect other keyboards, for which that check for
> KeyEvent.META_ALT_ON was used?

This is back out of previous fix.

Comment 42

[Alex Pakhotin (:alexp)]

(In reply to Makoto Kato from comment #40)
> Although this is workaround for this bug, I wants to remove since adding HTC
> touch to blacklist.  This isn't good fix due to comment #28.

Seems like that fix was just incorrect. I tried to check for the ALT meta state properly, as suggested in the comment #39, and it fixed the issue.
I am also not sure if the bug is really HTC-specific. The same problem with ALT key happened on Motorola Droid Pro and Droid 3 (bug 699792). I guess the same fix would help for the Desire Z.

Carla, are you still watching this bug, and do you still have the Desire Z?

Comment 43

[Camelia Urian]

Alex I am watching this bug, and I have the HTC Desire Z. On what build should I verify this?

Comment 44

[Alex Pakhotin (:alexp)]

(In reply to Camelia Urian from comment #43)
> Alex I am watching this bug, and I have the HTC Desire Z. On what build
> should I verify this?

Excellent! Could you please test the latest nightly from our new birch branch: http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-birch-android/

Thanks!

Comment 45

[Camelia Urian]

Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111121 Firefox/11.0a1 Fennec/11.0a1 - Native build
Device: HTC Desire Z
OS: Android 2.3

- FN key + key is not working, letters are inserted instead of numbers/special characters(eg: FN key+"y" should display "6", but it displayes "y")
- FN key LOCK - works correctly
- SHIFT Key and SHIFT LOCK - work correctly.

Comment 46

[Alex Pakhotin (:alexp)]

Thank you Camelia.

(In reply to Camelia Urian from comment #45)
> 
> - FN key + key is not working, letters are inserted instead of
> numbers/special characters(eg: FN key+"y" should display "6", but it
> displayes "y")
> - FN key LOCK - works correctly

Well, this sounds like an improvement. At least the locked FN works now.
I don't know what's wrong with the FN+key though. Seems like FN key on Desire Z is the same as the ALT on Motorola, and ALT+key works on Motorola.

By the way, how do you use FN+key? Do you hold FN while pressing another key, or press FN first, then another key? On Motorola both methods work. Holding ALT while pressing other keys enters the alternative characters, and pressing ALT before another key alternates only that one key pressed after the ALT.

Comment 47

[Camelia Urian]

Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111122 Firefox/11.0a1 Fennec/11.0a1 - Native build
Device: HTC Desire Z
OS: Android 2.3

Hi Alex

 - holding FN key while pressing another key - does not work:letter is inserted in place of character. 
 - pressing FN key, releasing it and press another key - works correctly
 - FN key lock works correctly
 - SHIFT key and SHIFT lock work correctly.

I also verified on Motorola Droid 2 and both ALT(both methods) and SHIFT work correctly.

Comment 48

[Alex Pakhotin (:alexp)]

Comment on attachment 567988 [details] [diff] [review]
fix v3

Clearing the review request.
The code changed since the patch was submitted, it now seems to work on other devices, and even partially on Desire Z.
If a fix will still be needed, it will have to be updated to the latest code and tested with other devices.

Comment 49

[cectlovers]

Hello,

I just want to say that this bug came back again.

It's appear again 2 update ago.

The FN and SHIFT keys works in address bar but not in website form.

If in a website form I press sym key to show special characters and press back (soft touch key) then the FH/SHIFT keys work
.
If I select another form, also in the same page FN key or Shift key doesn't work again.

Please help me!

Comment 50

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to cectlovers from comment #49)
> Hello,
> 
> I just want to say that this bug came back again.
> 
> It's appear again 2 update ago.
> 
> The FN and SHIFT keys works in address bar but not in website form.
> 
> If in a website form I press sym key to show special characters and press
> back (soft touch key) then the FH/SHIFT keys work
> .
> If I select another form, also in the same page FN key or Shift key doesn't
> work again.
> 
> Please help me!

Hi, I filed Bug 859452 for this issue. Thanks!

Comment 51

[Kevin Brosnan [Ex-Mozilla]]

Closing this.