859452 - FN and SHIFT keys not working on Desire Z

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

From Bug 685537 comment 49:

It's appear again 2 update ago.

The FN and SHIFT keys works in address bar but not in website form.

If in a website form I press sym key to show special characters and press back (soft touch key) then the FH/SHIFT keys work
.
If I select another form, also in the same page FN key or Shift key doesn't work again.

Comment 1

[Teodora Vermesan (:TeoVermesan)]

Good build: 01.11.2012
Bad build:  02.11.2012
Pushlog: 
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5bd5bb168eb1&tochange=556b9cfb269f	

The tinderbox inbound builds are missing since the issue is older than one month.

Comment 2

[Aaron Train [:aaronmt]]

Bug 805162 stands out like a sore thumb.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Teodora Vermesan (:TeoVermesan) from comment #1)
> Good build: 01.11.2012
> Bad build:  02.11.2012
> Pushlog: 
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=5bd5bb168eb1&tochange=556b9cfb269f	
> 
> The tinderbox inbound builds are missing since the issue is older than one
> month.

Hi Teodora, since you have a Desire Z, can you get the logcat of this Nightly while trying to use Fn and Shift keys? Thank you!

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-bef374b207fd/try-android/fennec-23.0a1.en-US.android-arm.apk

Comment 5

[Teodora Vermesan (:TeoVermesan)]

Attachment: Logs

I saved the logs while I was reproducing the bug. Please let me know if you need additional info regarding this bug.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Teodora Vermesan (:TeoVermesan) from comment #5)
> Created attachment 735668 [details]
> Logs
> 
> I saved the logs while I was reproducing the bug. Please let me know if you
> need additional info regarding this bug.

Can you get the logs using the Nightly in comment 4? It has more logging than a normal Nightly.

Thanks!

Comment 7

[Teodora Vermesan (:TeoVermesan)]

Attachment: Log

I've attached the logs with the given build. Please let me know if you need another information regarding this.

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Teodora Vermesan (:TeoVermesan) from comment #7)
> Created attachment 735750 [details]
> Log
> 
> I've attached the logs with the given build. Please let me know if you need
> another information regarding this.

Thank you! That was very useful. Can you try again using this build?

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-0e920791009e/try-android/fennec-23.0a1.en-US.android-arm.apk

Comment 9

[Teodora Vermesan (:TeoVermesan)]

I'm not able to reproduce the bug on the given build, but I'm able to reproduce it on the latest Nightly(2013-04-10). Please let me know if I can I try using another build.

Comment 10

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Send characters as keys when using HTC Touch Input (v1)

HTC Touch Input has the weird (and IMO wrong) behavior that, even if meta keys are pressed, the IME will call InputConnection.commitText() with the base character (i.e. without meta keys applied). In that case we have to convert the character back to a key event and let the TextKeyListener take care of applying meta keys.

Comment 11

[Chris Peterson [:cpeterson]]

Comment on attachment 738533 [details] [diff] [review]
Send characters as keys when using HTC Touch Input (v1)

Review of attachment 738533 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

::: mobile/android/base/GeckoInputConnection.java
@@ +637,5 @@
> +        if (InputMethods.shouldCommitCharAsKey(mCurrentInputMethod) &&
> +            text.length() == 1 && newCursorPosition > 0) {
> +            // mPluginInputConnection is a BaseInputConnection that commits text as keys;
> +            // here we are borrowing its ability to send keys
> +            return mPluginInputConnection.commitText(text, newCursorPosition);

As we discussed in IRC, let's rename mPluginInputConnection to something related to sending key events instead of IME events, such as mKeyInputConnection or mKeyEventInputConnection.

Comment 12

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Send characters as keys when using HTC Touch Input (v1)

Patch for checkin.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a520eb3b34ae

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a520eb3b34ae