685666 - test/mozmill/Makefile.in relies on target-specific variables being propagated to dependencies

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Which pymake doesn't do (because it's racy and otherwise nasty).  Luckily, afaict there's no reason for this code to use them.

Tagging jhammel for f? just to make sure there was no intent behind this originally.

Comment 1

[Jeff Hammel]

Comment on attachment 559259 [details] [diff] [review]
Patch

I'm not really sure enough about make to sensibly give feedback, but I can tell you what I was trying to do.  Essentially, if PKG_STAGE is defined then it should be overridden for stage-package.  I'm not sure if this does this.

OTOH, mozmill is ticketed to be removed from m-c in its current incarnation anyway: https://bugzilla.mozilla.org/show_bug.cgi?id=676078 . So you could just wipe the stage-package rule entirely and that would be fine.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/d0a370cc7c85