Closed Bug 685666 Opened 9 years ago Closed 9 years ago

test/mozmill/Makefile.in relies on target-specific variables being propagated to dependencies

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla10

People

(Reporter: khuey, Assigned: khuey)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Which pymake doesn't do (because it's racy and otherwise nasty).  Luckily, afaict there's no reason for this code to use them.

Tagging jhammel for f? just to make sure there was no intent behind this originally.
Attachment #559259 - Flags: review?(ted.mielczarek)
Attachment #559259 - Flags: feedback?(jhammel)
Comment on attachment 559259 [details] [diff] [review]
Patch

I'm not really sure enough about make to sensibly give feedback, but I can tell you what I was trying to do.  Essentially, if PKG_STAGE is defined then it should be overridden for stage-package.  I'm not sure if this does this.

OTOH, mozmill is ticketed to be removed from m-c in its current incarnation anyway: https://bugzilla.mozilla.org/show_bug.cgi?id=676078 . So you could just wipe the stage-package rule entirely and that would be fine.
Attachment #559259 - Flags: feedback?(jhammel) → feedback+
Attachment #559259 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/d0a370cc7c85
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.