686008 - cfx xpi shouldn't include vim temporary files

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[David Illsley]

As with bug 565176 but for vim users, I've noticed that vim temporary files are being included in xpis e.g. .panel.js.swp

These files then cause warnings on amo, which is frustrating

Comment 1

[Brian Warner [:warner :bwarner]]

Attachment: ignore .swp files when building the XPI

Does this patch fix the problem? Is ".swp" the only suffix that vim creates?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 559572 [details] [diff] [review]
ignore .swp files when building the XPI

Code looks good, r=myk.

David: anything else we should look out for?

Comment 3

[David Illsley]

Not that I'm aware of, but the AMO warning is as follows, so might be worth just excluding all hidden files (or speaking to the AMO guys):

Hidden files and folders flagged

Warning: Hidden files and folders difficult the review process and can contain sensitive information about the system that generated the XPI. Please modify the packaging process so that these files aren't included.
resources/jid0-iwogeuibasgv3uv3pial5mthuvq-at-jetpack-tubecheckinfo-data/.panel.js.swp

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Hmm, I wouldn't want to difficult the review process (unnecessarily), so I'm game to exclude hidden files generally.

Comment 5

[Brian Warner [:warner :bwarner]]

Attachment: ignore all hidden files, refactor utility routine, add tests

by "hidden" I'll assume they mean anything starting with a period.

Here's a new patch which hides those too, factors the two filtering routines (XPI generation and data/ directory scanning) into a single utility function, and adds a quick test.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 559593 [details] [diff] [review]
ignore all hidden files, refactor utility routine, add tests

>+IGNORED_DIRS = [".svn", ".hg", "defaults"]

.git?

Comment 7

[Brian Warner [:warner :bwarner]]

Landed in https://github.com/mozilla/addon-sdk/commit/d98f1d0af8bdb97e3c8af2b7f1a80f027fc67126 . I took the liberty of factoring out the filter_dirnames() function too, and included .git in that list. (.git doesn't usually matter because .git is only at the top-level, and the only directories that get copied are under data/ , so filter_dirnames() is really just for revision-control systems that spread their metadata out in each directory like SVN).