The default bug view has changed. See this FAQ.

Remove trailing spaces from mail header string entities and adjust the padding to compensate.

RESOLVED FIXED in Thunderbird 24.0

Status

Thunderbird
Message Reader UI
--
trivial
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: Thomas D. (currently busy elsewhere; needinfo?me), Assigned: Paenglab)

Tracking

Trunk
Thunderbird 24.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment)

A small leftover/followup on bug 478468, comment 74 and 75:

Looking at this...

> +<!ENTITY toField3.label "To ">
> +<!ENTITY fromField3.label "From ">
> +<!ENTITY senderField3.label "Sender ">
> +<!ENTITY organizationField3.label "Organization ">
> +<!ENTITY replyToField3.label "Reply to ">

... I still have this question:

(In reply to Thomas D. from comment #66)
> Likewise, do we want spaces in the labels? (suppose not). Does not having
> the spaces or colons affect other localizations, like RTL languages?

Iow, what's the point of having trailing spaces inside a label, which more often than not will have to be trimmed by the code and replaced by colons?

Expected: The spaces in those entities should be removed, and the code be adjusted accordingly if necessary.
Summary: Remove spaces from mail header string entities → Remove trailing spaces from mail header string entities
Summary: Remove trailing spaces from mail header string entities → Remove trailing spaces from mail header string entities and adjust the padding to compensate.
Whiteboard: [good first bug]

Updated

6 years ago
Assignee: nobody → abhishekkumarsingh.cse
Status: NEW → ASSIGNED
abhishekkumarsingh, are you going to work on this?
Flags: needinfo?(abhishekkumarsingh.cse)

Comment 2

4 years ago
(In reply to Thomas D. from comment #1)
> abhishekkumarsingh, are you going to work on this?

Hi Thomas,

I won't be handling it due to lack of time. Please feel free to work on this bug.

cheers,
Flags: needinfo?(abhishekkumarsingh.cse)
(Assignee)

Comment 3

4 years ago
Created attachment 745637 [details] [diff] [review]
remove the space

Trailing spaces removed. To compensate the gap I gave .headerName a 3px margin at the end.
Assignee: abhishekkumarsingh.cse → richard.marti
Attachment #745637 - Flags: ui-review?(bwinton)
Attachment #745637 - Flags: review?(bwinton)
Comment on attachment 745637 [details] [diff] [review]
remove the space

Yep.  Sorry about the wait time for the review.
r=me, ui-r=me.
Attachment #745637 - Flags: ui-review?(bwinton)
Attachment #745637 - Flags: ui-review+
Attachment #745637 - Flags: review?(bwinton)
Attachment #745637 - Flags: review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/2e455a3aafa8
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0

Updated

3 years ago
Depends on: 934874
You need to log in before you can comment on or make changes to this bug.