Last Comment Bug 686427 - Remove trailing spaces from mail header string entities and adjust the padding to compensate.
: Remove trailing spaces from mail header string entities and adjust the paddin...
Status: RESOLVED FIXED
[good first bug]
:
Product: Thunderbird
Classification: Client Software
Component: Message Reader UI (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 24.0
Assigned To: Richard Marti (:Paenglab)
:
:
Mentors:
Depends on: 934874
Blocks: 478468
  Show dependency treegraph
 
Reported: 2011-09-13 01:13 PDT by Thomas D. (needinfo?me)
Modified: 2014-08-21 04:32 PDT (History)
8 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
remove the space (12.08 KB, patch)
2013-05-05 05:35 PDT, Richard Marti (:Paenglab)
bwinton: review+
bwinton: ui‑review+
Details | Diff | Splinter Review

Description Thomas D. (needinfo?me) 2011-09-13 01:13:15 PDT
A small leftover/followup on bug 478468, comment 74 and 75:

Looking at this...

> +<!ENTITY toField3.label "To ">
> +<!ENTITY fromField3.label "From ">
> +<!ENTITY senderField3.label "Sender ">
> +<!ENTITY organizationField3.label "Organization ">
> +<!ENTITY replyToField3.label "Reply to ">

... I still have this question:

(In reply to Thomas D. from comment #66)
> Likewise, do we want spaces in the labels? (suppose not). Does not having
> the spaces or colons affect other localizations, like RTL languages?

Iow, what's the point of having trailing spaces inside a label, which more often than not will have to be trimmed by the code and replaced by colons?

Expected: The spaces in those entities should be removed, and the code be adjusted accordingly if necessary.
Comment 1 Thomas D. (needinfo?me) 2013-04-21 05:43:28 PDT
abhishekkumarsingh, are you going to work on this?
Comment 2 Abhishek Singh 2013-05-05 04:13:23 PDT
(In reply to Thomas D. from comment #1)
> abhishekkumarsingh, are you going to work on this?

Hi Thomas,

I won't be handling it due to lack of time. Please feel free to work on this bug.

cheers,
Comment 3 Richard Marti (:Paenglab) 2013-05-05 05:35:07 PDT
Created attachment 745637 [details] [diff] [review]
remove the space

Trailing spaces removed. To compensate the gap I gave .headerName a 3px margin at the end.
Comment 4 Blake Winton (:bwinton) (:☕️) 2013-06-16 12:34:48 PDT
Comment on attachment 745637 [details] [diff] [review]
remove the space

Yep.  Sorry about the wait time for the review.
r=me, ui-r=me.
Comment 5 Ryan VanderMeulen [:RyanVM] 2013-06-18 08:26:26 PDT
https://hg.mozilla.org/comm-central/rev/2e455a3aafa8

Note You need to log in before you can comment on or make changes to this bug.