Closed
Bug 686427
Opened 14 years ago
Closed 12 years ago
Remove trailing spaces from mail header string entities and adjust the padding to compensate.
Categories
(Thunderbird :: Message Reader UI, defect)
Thunderbird
Message Reader UI
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 24.0
People
(Reporter: thomas8, Assigned: Paenglab)
References
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
12.08 KB,
patch
|
bwinton
:
review+
bwinton
:
ui-review+
|
Details | Diff | Splinter Review |
A small leftover/followup on bug 478468, comment 74 and 75:
Looking at this...
> +<!ENTITY toField3.label "To ">
> +<!ENTITY fromField3.label "From ">
> +<!ENTITY senderField3.label "Sender ">
> +<!ENTITY organizationField3.label "Organization ">
> +<!ENTITY replyToField3.label "Reply to ">
... I still have this question:
(In reply to Thomas D. from comment #66)
> Likewise, do we want spaces in the labels? (suppose not). Does not having
> the spaces or colons affect other localizations, like RTL languages?
Iow, what's the point of having trailing spaces inside a label, which more often than not will have to be trimmed by the code and replaced by colons?
Expected: The spaces in those entities should be removed, and the code be adjusted accordingly if necessary.
Reporter | ||
Updated•14 years ago
|
Summary: Remove spaces from mail header string entities → Remove trailing spaces from mail header string entities
Updated•14 years ago
|
Summary: Remove trailing spaces from mail header string entities → Remove trailing spaces from mail header string entities and adjust the padding to compensate.
Updated•14 years ago
|
Whiteboard: [good first bug]
![]() |
||
Updated•14 years ago
|
Assignee: nobody → abhishekkumarsingh.cse
Status: NEW → ASSIGNED
Reporter | ||
Comment 1•12 years ago
|
||
abhishekkumarsingh, are you going to work on this?
Flags: needinfo?(abhishekkumarsingh.cse)
Comment 2•12 years ago
|
||
(In reply to Thomas D. from comment #1)
> abhishekkumarsingh, are you going to work on this?
Hi Thomas,
I won't be handling it due to lack of time. Please feel free to work on this bug.
cheers,
Flags: needinfo?(abhishekkumarsingh.cse)
Assignee | ||
Comment 3•12 years ago
|
||
Trailing spaces removed. To compensate the gap I gave .headerName a 3px margin at the end.
Assignee: abhishekkumarsingh.cse → richard.marti
Attachment #745637 -
Flags: ui-review?(bwinton)
Attachment #745637 -
Flags: review?(bwinton)
Comment 4•12 years ago
|
||
Comment on attachment 745637 [details] [diff] [review]
remove the space
Yep. Sorry about the wait time for the review.
r=me, ui-r=me.
Attachment #745637 -
Flags: ui-review?(bwinton)
Attachment #745637 -
Flags: ui-review+
Attachment #745637 -
Flags: review?(bwinton)
Attachment #745637 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
You need to log in
before you can comment on or make changes to this bug.
Description
•