686427 - Remove trailing spaces from mail header string entities and adjust the padding to compensate.

Status: RESOLVED FIXED

Description

[Thomas D. (currently busy elsewhere)]

A small leftover/followup on bug 478468, comment 74 and 75:

Looking at this...

> +<!ENTITY toField3.label "To ">
> +<!ENTITY fromField3.label "From ">
> +<!ENTITY senderField3.label "Sender ">
> +<!ENTITY organizationField3.label "Organization ">
> +<!ENTITY replyToField3.label "Reply to ">

... I still have this question:

(In reply to Thomas D. from comment #66)
> Likewise, do we want spaces in the labels? (suppose not). Does not having
> the spaces or colons affect other localizations, like RTL languages?

Iow, what's the point of having trailing spaces inside a label, which more often than not will have to be trimmed by the code and replaced by colons?

Expected: The spaces in those entities should be removed, and the code be adjusted accordingly if necessary.

Comment 1

[Thomas D. (currently busy elsewhere)]

abhishekkumarsingh, are you going to work on this?

Comment 2

[Abhishek Singh]

(In reply to Thomas D. from comment #1)
> abhishekkumarsingh, are you going to work on this?

Hi Thomas,

I won't be handling it due to lack of time. Please feel free to work on this bug.

cheers,

Comment 3

[Richard Marti (:Paenglab)]

Created attachment 745637 [details] [diff] [review]
remove the space

Trailing spaces removed. To compensate the gap I gave .headerName a 3px margin at the end.

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 745637 [details] [diff] [review]
remove the space

Yep.  Sorry about the wait time for the review.
r=me, ui-r=me.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/2e455a3aafa8