Closed Bug 686671 Opened 10 years ago Closed 10 years ago

Reduce border radii of the url bar, search bar and toolbar buttons on the navigation toolbar

Categories

(Firefox :: Theme, enhancement)

All
Windows 7
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 9

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: polish)

Attachments

(2 files)

Attached patch patchSplinter Review
These should probably be completely square on Windows 8. In the meantime, I think we should reduce the radii for all Windows versions, as it looks sleeker and will ease the transition to the Windows 8 look.
Attachment #560157 - Flags: review?(shorlander)
Attached image screenshot
Comment on attachment 560157 [details] [diff] [review]
patch

Review of attachment 560157 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #560157 - Flags: review?(shorlander) → review+
http://hg.mozilla.org/mozilla-central/rev/145d437bebcf
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9
Will the hover appearance of small toolbar buttons be adjusted to match as well?
Maybe you should also reduce the border radii of search bar in the Library and the border radii of buttons and search bar in the Add-ons manager for more consistency
(In reply to solcroft from comment #4)
> Will the hover appearance of small toolbar buttons be adjusted to match as
> well?

These are native toolbar buttons, which AFAIK were already less round than the custom style.

(In reply to Valerio from comment #5)
> Maybe you should also reduce the border radii of search bar in the Library
> and the border radii of buttons and search bar in the Add-ons manager for
> more consistency

Feel free to file new bugs on this. Also, patches are welcome.
Blocks: 638526
Bug 638688 may be closed
(In reply to Dão Gottwald [:dao] from comment #6)
> (In reply to solcroft from comment #4)
> > Will the hover appearance of small toolbar buttons be adjusted to match as
> > well?
> 
> These are native toolbar buttons, which AFAIK were already less round than
> the custom style.

They currently have a border radius of 3px, if I'm not mistaken. According to the patch code, the urlbar and toolbar buttons are being reduced to 2.5px.
Will this be pushed to Firefox 8 Aurora?
(In reply to sdrocking from comment #9)
> Will this be pushed to Firefox 8 Aurora?

I wouldn't expect this to be approved for landing on Aurora.
Attachment #560157 - Flags: approval-mozilla-aurora?
Attachment #560157 - Flags: approval-mozilla-aurora?
For what it's worth (and it's not much I guess), this looks worse than before.
Why are we going back to Windows 95 style square buttons????

Did we lose our funding for modern looking apps?
We still have to deal with the **** small buttons having lost Firefox's style.

What is up with this stuff lately?
You need to log in before you can comment on or make changes to this bug.