Reduce border radii of the url bar, search bar and toolbar buttons on the navigation toolbar

RESOLVED FIXED in Firefox 9

Status

()

Firefox
Theme
--
enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

({polish})

Trunk
Firefox 9
All
Windows 7
polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Created attachment 560157 [details] [diff] [review]
patch

These should probably be completely square on Windows 8. In the meantime, I think we should reduce the radii for all Windows versions, as it looks sleeker and will ease the transition to the Windows 8 look.
Attachment #560157 - Flags: review?(shorlander)
(Assignee)

Comment 1

6 years ago
Created attachment 560159 [details]
screenshot
Comment on attachment 560157 [details] [diff] [review]
patch

Review of attachment 560157 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #560157 - Flags: review?(shorlander) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/mozilla-central/rev/145d437bebcf
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9

Comment 4

6 years ago
Will the hover appearance of small toolbar buttons be adjusted to match as well?

Comment 5

6 years ago
Maybe you should also reduce the border radii of search bar in the Library and the border radii of buttons and search bar in the Add-ons manager for more consistency
(Assignee)

Comment 6

6 years ago
(In reply to solcroft from comment #4)
> Will the hover appearance of small toolbar buttons be adjusted to match as
> well?

These are native toolbar buttons, which AFAIK were already less round than the custom style.

(In reply to Valerio from comment #5)
> Maybe you should also reduce the border radii of search bar in the Library
> and the border radii of buttons and search bar in the Add-ons manager for
> more consistency

Feel free to file new bugs on this. Also, patches are welcome.
(Assignee)

Updated

6 years ago
Blocks: 638526
Bug 638688 may be closed

Comment 8

6 years ago
(In reply to Dão Gottwald [:dao] from comment #6)
> (In reply to solcroft from comment #4)
> > Will the hover appearance of small toolbar buttons be adjusted to match as
> > well?
> 
> These are native toolbar buttons, which AFAIK were already less round than
> the custom style.

They currently have a border radius of 3px, if I'm not mistaken. According to the patch code, the urlbar and toolbar buttons are being reduced to 2.5px.
Will this be pushed to Firefox 8 Aurora?
(Assignee)

Comment 10

6 years ago
(In reply to sdrocking from comment #9)
> Will this be pushed to Firefox 8 Aurora?

I wouldn't expect this to be approved for landing on Aurora.
(Assignee)

Updated

6 years ago
Attachment #560157 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

6 years ago
Attachment #560157 - Flags: approval-mozilla-aurora?

Comment 11

6 years ago
For what it's worth (and it's not much I guess), this looks worse than before.
Why are we going back to Windows 95 style square buttons????

Did we lose our funding for modern looking apps?
We still have to deal with the **** small buttons having lost Firefox's style.

What is up with this stuff lately?
You need to log in before you can comment on or make changes to this bug.