The default bug view has changed. See this FAQ.

XHR POST in worker with null body and upload load event listener leads to Assertion failure: GetPrivate(aCx, aObj), at c:/dev/mozilla-central/dom/workers/XMLHttpRequest.cpp:319

VERIFIED FIXED in Firefox 9

Status

()

Core
DOM
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: khuey, Assigned: Ben Turner (not reading bugmail, use the needinfo flag!))

Tracking

(4 keywords)

unspecified
mozilla9
qawanted, regression, verified-aurora, verified-beta
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox8- wontfix, firefox9+ fixed, firefox10 fixed)

Details

(Whiteboard: [inbound][qa!])

Attachments

(2 attachments)

http://people.mozilla.org/~khuey/bugs/ww1/test.html

Result:
Assertion failure: GetPrivate(aCx, aObj), at c:/dev/mozilla-central/dom/workers/XMLHttpRequest.cpp:319
Blocks: 687221

Updated

6 years ago
tracking-firefox9: ? → +
Ben, this looks like a regression from your bindings work in worker. Can you have a look?
Assignee: nobody → bent.mozilla
Created attachment 571815 [details] [diff] [review]
Patch, v1

This fixes us. We were targeting the wrong object.
Attachment #571815 - Flags: review?(mrbkap)
status-firefox10: --- → affected
status-firefox8: --- → affected
tracking-firefox10: --- → ?
tracking-firefox8: --- → ?

Updated

6 years ago
Attachment #571815 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e9dcc5e18cd
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/3e9dcc5e18cd
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
status-firefox10: affected → fixed
tracking-firefox10: ? → ---
Target Milestone: mozilla10 → ---
Comment on attachment 571815 [details] [diff] [review]
Patch, v1

I'd really like to get this into branches before we merge, this bug prevents xhr.upload events from working correctly (not sure how common they are used, but it's certainly supposed to work) and may cause a crash.
Attachment #571815 - Flags: approval-mozilla-beta?
Attachment #571815 - Flags: approval-mozilla-aurora?

Comment 6

5 years ago
[triage comment]
Did this work in Firefox 7 or has it always been broken? We'll take this on aurora, but don't think we'd rebuild Firefox 8 for this.

Updated

5 years ago
Attachment #571815 - Flags: approval-mozilla-beta?
Attachment #571815 - Flags: approval-mozilla-beta-
Attachment #571815 - Flags: approval-mozilla-aurora?
Attachment #571815 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/f95e13ba4a58
status-firefox9: affected → fixed

Comment 8

5 years ago
On Mac, when I clicked the link I ran into https://crash-stats.mozilla.com/report/index/bp-3056188e-e11c-41ad-b670-ebebf2111110
Was that in a build after this fix went in?
Reading the crash report, the answer is no, that report is from 8.
Keywords: qawanted
Blocks: 701537
(In reply to Alex Keybl [:akeybl] from comment #8)
> On Mac, when I clicked the link I ran into
> https://crash-stats.mozilla.com/report/index/bp-3056188e-e11c-41ad-b670-
> ebebf2111110

Here are similar crash reports from my Macbook Air running Firefox 8.

https://crash-stats.mozilla.com/report/index/bp-aac5b65f-1558-43f0-a778-ccce92111110
https://crash-stats.mozilla.com/report/index/bp-7f074c1c-8690-49a1-9927-823f82111110
Created attachment 573695 [details] [diff] [review]
test
Attachment #573695 - Flags: review?(bent.mozilla)
Attachment #573695 - Flags: review?(bent.mozilla) → review+
Checked in text:

https://hg.mozilla.org/mozilla-central/rev/1374294a6119
Comment on attachment 571815 [details] [diff] [review]
Patch, v1

[Triage Comment]
Approving for beta now that we're considering this for inclusion in an 8.0.1. Please land there ASAP so that we can make sure it's all green and won't cause any surprises when landing on release.
Attachment #571815 - Flags: approval-mozilla-beta- → approval-mozilla-beta+
This was landed on mozilla-aurora before the last merge so it is on mozilla-beta now already. Did you mean for me to land this on mozilla-release?
I pushed the test to aurora and beta:

https://hg.mozilla.org/releases/mozilla-aurora/rev/232e47a8bf1d
https://hg.mozilla.org/releases/mozilla-beta/rev/aaa88890a7b9

Still need to know if the original patch and test should land on mozilla-release.
Attachment #571815 - Flags: approval-mozilla-release?
No longer blocks: 701537

Updated

5 years ago
tracking-firefox8: ? → -
Comment on attachment 571815 [details] [diff] [review]
Patch, v1

[Triage Comment]
Denying for release as we are no longer considering shipping 8.0.1 to all Firefox users - it will be a targeted release for those who are, or could potentially be, affected by bug 700835 or bug 691271.
Attachment #571815 - Flags: approval-mozilla-release? → approval-mozilla-release-
Whiteboard: [inbound] → [inbound][qa+]

Comment 18

5 years ago
The dom/workers/test/test_xhr.html test is passing on all OSs:
https://tbpl.mozilla.org/php/getParsedLog.php?id=7486419&full=1&branch=mozilla-beta
https://tbpl.mozilla.org/php/getParsedLog.php?id=7485706&full=1&branch=mozilla-beta
https://tbpl.mozilla.org/php/getParsedLog.php?id=7485702&full=1&branch=mozilla-beta
https://tbpl.mozilla.org/php/getParsedLog.php?id=7484677&full=1&branch=mozilla-beta

https://tbpl.mozilla.org/php/getParsedLog.php?id=7514037&full=1&branch=mozilla-aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=7514307&full=1&branch=mozilla-aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=7515902&full=1&branch=mozilla-aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=7515919&full=1&branch=mozilla-aurora

https://tbpl.mozilla.org/php/getParsedLog.php?id=7526482&full=1&branch=mozilla-inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=7526962&full=1&branch=mozilla-inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=7526932&full=1&branch=mozilla-inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=7526950&full=1&branch=mozilla-inbound

Comment 19

5 years ago
Verified as fixed on:
Mozilla/5.0 (Windows NT 5.1; rv:9.0) Gecko/20100101 Firefox/9.0 (20111116091359)
Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111121 Firefox/10.0a2
Mozilla/5.0 (Windows NT 5.1; rv:11.0a1) Gecko/20111121 Firefox/11.0a1

Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20100101 Firefox/9.0 (20111116091359)
Mozilla/5.0 (Windows NT 6.1; rv:10.0a2) Gecko/20111121 Firefox/10.0a2
Mozilla/5.0 (Windows NT 6.1; rv:11.0a1) Gecko/20111121 Firefox/11.0a1

Mozilla/5.0 (X11; Linux i686; rv:9.0) Gecko/20100101 Firefox/9.0 (20111116091359)
Mozilla/5.0 (X11; Linux i686; rv:10.0a2) Gecko/20111121 Firefox/10.0a2
Mozilla/5.0 (X11; Linux i686; rv:11.0a1) Gecko/20111121 Firefox/11.0a1

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0 (20111116091359)
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0a2) Gecko/20111121 Firefox/10.0a2
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0a1) Gecko/20111121 Firefox/11.0a1

The test from comment 0 was used and no issues reproduced.
Status: RESOLVED → VERIFIED
Keywords: verified-aurora, verified-beta
Whiteboard: [inbound][qa+] → [inbound][qa!]
status-firefox8: affected → wontfix
Flags: in-testsuite+
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.