687220 - XHR POST in worker with null body and upload load event listener leads to Assertion failure: GetPrivate(aCx, aObj), at c:/dev/mozilla-central/dom/workers/XMLHttpRequest.cpp:319

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://people.mozilla.org/~khuey/bugs/ww1/test.html

Result:
Assertion failure: GetPrivate(aCx, aObj), at c:/dev/mozilla-central/dom/workers/XMLHttpRequest.cpp:319

Comment 1

[Johnny Stenback (:jst)]

Ben, this looks like a regression from your bindings work in worker. Can you have a look?

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

This fixes us. We were targeting the wrong object.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e9dcc5e18cd

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3e9dcc5e18cd

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 571815 [details] [diff] [review]
Patch, v1

I'd really like to get this into branches before we merge, this bug prevents xhr.upload events from working correctly (not sure how common they are used, but it's certainly supposed to work) and may cause a crash.

Comment 6

[LegNeato]

[triage comment]
Did this work in Firefox 7 or has it always been broken? We'll take this on aurora, but don't think we'd rebuild Firefox 8 for this.

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f95e13ba4a58

Comment 8

[Alex Keybl [:akeybl]]

On Mac, when I clicked the link I ran into https://crash-stats.mozilla.com/report/index/bp-3056188e-e11c-41ad-b670-ebebf2111110

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Was that in a build after this fix went in?

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Reading the crash report, the answer is no, that report is from 8.

Comment 11

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Alex Keybl [:akeybl] from comment #8)
> On Mac, when I clicked the link I ran into
> https://crash-stats.mozilla.com/report/index/bp-3056188e-e11c-41ad-b670-
> ebebf2111110

Here are similar crash reports from my Macbook Air running Firefox 8.

https://crash-stats.mozilla.com/report/index/bp-aac5b65f-1558-43f0-a778-ccce92111110
https://crash-stats.mozilla.com/report/index/bp-7f074c1c-8690-49a1-9927-823f82111110

Comment 12

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: test

Comment 13

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in text:

https://hg.mozilla.org/mozilla-central/rev/1374294a6119

Comment 14

[Alex Keybl [:akeybl]]

Comment on attachment 571815 [details] [diff] [review]
Patch, v1

[Triage Comment]
Approving for beta now that we're considering this for inclusion in an 8.0.1. Please land there ASAP so that we can make sure it's all green and won't cause any surprises when landing on release.

Comment 15

[Ben Turner (not reading bugmail, use the needinfo flag!)]

This was landed on mozilla-aurora before the last merge so it is on mozilla-beta now already. Did you mean for me to land this on mozilla-release?

Comment 16

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I pushed the test to aurora and beta:

https://hg.mozilla.org/releases/mozilla-aurora/rev/232e47a8bf1d
https://hg.mozilla.org/releases/mozilla-beta/rev/aaa88890a7b9

Still need to know if the original patch and test should land on mozilla-release.

Comment 17

[Alex Keybl [:akeybl]]

Comment on attachment 571815 [details] [diff] [review]
Patch, v1

[Triage Comment]
Denying for release as we are no longer considering shipping 8.0.1 to all Firefox users - it will be a targeted release for those who are, or could potentially be, affected by bug 700835 or bug 691271.

Comment 18

[Ioana (away)]

The dom/workers/test/test_xhr.html test is passing on all OSs:
https://tbpl.mozilla.org/php/getParsedLog.php?id=7486419&full=1&branch=mozilla-beta
https://tbpl.mozilla.org/php/getParsedLog.php?id=7485706&full=1&branch=mozilla-beta
https://tbpl.mozilla.org/php/getParsedLog.php?id=7485702&full=1&branch=mozilla-beta
https://tbpl.mozilla.org/php/getParsedLog.php?id=7484677&full=1&branch=mozilla-beta

https://tbpl.mozilla.org/php/getParsedLog.php?id=7514037&full=1&branch=mozilla-aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=7514307&full=1&branch=mozilla-aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=7515902&full=1&branch=mozilla-aurora
https://tbpl.mozilla.org/php/getParsedLog.php?id=7515919&full=1&branch=mozilla-aurora

https://tbpl.mozilla.org/php/getParsedLog.php?id=7526482&full=1&branch=mozilla-inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=7526962&full=1&branch=mozilla-inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=7526932&full=1&branch=mozilla-inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=7526950&full=1&branch=mozilla-inbound

Comment 19

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (Windows NT 5.1; rv:9.0) Gecko/20100101 Firefox/9.0 (20111116091359)
Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111121 Firefox/10.0a2
Mozilla/5.0 (Windows NT 5.1; rv:11.0a1) Gecko/20111121 Firefox/11.0a1

Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20100101 Firefox/9.0 (20111116091359)
Mozilla/5.0 (Windows NT 6.1; rv:10.0a2) Gecko/20111121 Firefox/10.0a2
Mozilla/5.0 (Windows NT 6.1; rv:11.0a1) Gecko/20111121 Firefox/11.0a1

Mozilla/5.0 (X11; Linux i686; rv:9.0) Gecko/20100101 Firefox/9.0 (20111116091359)
Mozilla/5.0 (X11; Linux i686; rv:10.0a2) Gecko/20111121 Firefox/10.0a2
Mozilla/5.0 (X11; Linux i686; rv:11.0a1) Gecko/20111121 Firefox/11.0a1

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0 (20111116091359)
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0a2) Gecko/20111121 Firefox/10.0a2
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0a1) Gecko/20111121 Firefox/11.0a1

The test from comment 0 was used and no issues reproduced.