Closed Bug 687287 Opened 10 years ago Closed 10 years ago

[Regression][Tablet] Close is misaligned on tabs in tablet mode

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 9

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(1 file, 1 obsolete file)

Regression caused by my patch for bug 686857.
Also improves the clickable area of close button on inactive tabs.
Attachment #560734 - Flags: review?(mark.finkle)
Comment on attachment 560734 [details] [diff] [review]
Fix alignment of close button on inactive tabs

The changes to updateTabletLayout are for tablet and phones. Did you test on phones to make sure the changes don't break anything?
Just a tiny 1px improvement for better alignment.
Attachment #560734 - Attachment is obsolete: true
Attachment #560734 - Flags: review?(mark.finkle)
Attachment #560894 - Flags: review?(mark.finkle)
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 560734 [details] [diff] [review]
> Fix alignment of close button on inactive tabs
> 
> The changes to updateTabletLayout are for tablet and phones. Did you test on
> phones to make sure the changes don't break anything?

Yes, I tested on all tablet/phone theme combinations. The phone themes are not relying on forced width of close container and are not affected by this patch.
Attachment #560894 - Flags: review?(mark.finkle) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/aada4d669948
Assignee: nobody → lucasr.at.mozilla
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [inbound]
Duplicate of this bug: 687517
Duplicate of this bug: 687479
Duplicate of this bug: 687473
Blocks: 687468
https://hg.mozilla.org/mozilla-central/rev/aada4d669948
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 9
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110922
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.