Closed
Bug 687287
Opened 14 years ago
Closed 14 years ago
[Regression][Tablet] Close is misaligned on tabs in tablet mode
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 9
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.72 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Regression caused by my patch for bug 686857.
|
Assignee | |
Comment 1•14 years ago
|
||
Also improves the clickable area of close button on inactive tabs.
Attachment #560734 -
Flags: review?(mark.finkle)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 560734 [details] [diff] [review]
Fix alignment of close button on inactive tabs
The changes to updateTabletLayout are for tablet and phones. Did you test on phones to make sure the changes don't break anything?
|
|
Assignee | |
Comment 3•14 years ago
|
||
Just a tiny 1px improvement for better alignment.
Attachment #560734 -
Attachment is obsolete: true
Attachment #560734 -
Flags: review?(mark.finkle)
Attachment #560894 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Comment 4•14 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 560734 [details] [diff] [review]
> Fix alignment of close button on inactive tabs
>
> The changes to updateTabletLayout are for tablet and phones. Did you test on
> phones to make sure the changes don't break anything?
Yes, I tested on all tablet/phone theme combinations. The phone themes are not relying on forced width of close container and are not affected by this patch.
|
|
||
Updated•14 years ago
|
Attachment #560894 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 5•14 years ago
|
||
Assignee: nobody → lucasr.at.mozilla
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [inbound]
|
||
Comment 9•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 9
|
||
Comment 10•14 years ago
|
||
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110922
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•