687324 - "Shift+Click" on "Compose Message To" menu item does not trigger non-default format for composition: toggle Plain text vs. HTML (mail header contacts' context menu)

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Hong Xu]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20100101 Firefox/6.0.2
Build ID: 20110902133214

Steps to reproduce:

1. The default message format should be set to html, but not plain text;
2. Hold the shift key and press left mouse key on "Compose Message To" menu item poping up from the "from line".



Actual results:

The message was set to "html" format.


Expected results:

The message should be set to "plain text" format.

Comment 1

[Hong Xu]

Besides, "Shift + Left Mouse Key" on the "Write" button of the toolbar or the "reply" button works as expected.

Comment 2

[Ludovic Hirlimann [:Usul]]

Is this a regression ?

Does it happens in safe-mode (see http://support.mozillamessaging.com/en-US/kb/Safe-Mode) ?

Comment 3

[Hong Xu]

This is not a regression. It still happens in safe-mode.

Comment 4

[Hong Xu]

I don't think it should be an enhancement since I remember that old version thunderbird (maybe 3.0 ?) has this feature but someday I found it disappears. It should be "normal".

Comment 5

[Thomas D. (:thomas8)]

See Bug 672475 Comment 7 for an overview of current behaviour and outstanding bugs

Comment 6

[Thomas D. (:thomas8)]

Attachment: Patch V.1: Enable Shift modifier for "Compose Message To" (msg header context menu)

Jim, if you may assist here with a 2-minute-review, followup of bug 975816 comment 30 where you already reviewed the very same thing, just in a different corner of the UI.

Neil, do you want this for SeaMonkey, too? (included in current patch)

Comment 7

[[e-mail]]

Comment on attachment 8419282 [details] [diff] [review]
Patch V.1: Enable Shift modifier for "Compose Message To" (msg header context menu)

r=me by code inspection.

Comment 8

[Jim Porter (:squib)]

Comment on attachment 8419282 [details] [diff] [review]
Patch V.1: Enable Shift modifier for "Compose Message To" (msg header context menu)

Review of attachment 8419282 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! rs=me

Comment 9

[Thomas D. (:thomas8)]

Jim, Neil, thanks for the reviews :)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/17cf0c79b4fe