687412 - "Save Event" dialog pops up when closing an unmodified event

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Tristan Miller]

In Thunderbird's Event pane, I double-click on an event.  This opens an "Edit Event" dilaog.  I then close this dialog without making any changes.  This produces the following dialog:

Save Event
Event has not been saved.  Do you want to save the event?
[Don't Save] [Cancel] [Save]

Since I did not make any modifications to the event, I should not be prompted to save it.

I am using Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.21) Gecko/20110831 Lightning/1.0b2 Thunderbird/3.1.13.

Perhaps this is related to, or a recurrence of, Bug 419807.

Comment 1

[Stefan Sitter [:ssitter]]

Does this happen with the current release too, i.e. Lightning 1.0b5 + Thunderbird 6?

If yes, maybe some property of the event has been corrected in the background. I suggest to copy the event before and after and compare the iCalendar representation.

Comment 2

[Tristan Miller]

Lightning 1.0b2 is the latest stable release which I'm able to install on my 64-bit system (see Bug 455683), so I'm afraid I can't test with anything newer.

Comment 3

[Stefan Sitter [:ssitter]]

I don't see how Bug 455683 affects you. Lightning 1.0b5 does support 64-bit Thunderbird 6 builds. You can get it from https://addons.mozilla.org/thunderbird/addon/lightning/versions/1.0b5

Comment 4

[Tristan Miller]

It does, but we're still using Thunderbird 3.x at my place of work.  I'll see if I can install the latest version and test it on my home machine.

Comment 5

[Tristan Miller]

Confirming problem also occurs with Thunderbird 6.0.2 and Lightning 1.05b.

Stefan, I'm not sure what you mean by "copy the event before and after and compare the iCalendar representation".  Am I correct in thinking you want me to do the following steps?

1. Copy the event to the clipboard.
2. Paste it into a text editor to get an iCal representation
3. Open the event
4. Close the event, and when the dialog appears click on "Save"
5. Copy the event to the clipboard
6. Paste it into a text editor to get an iCal representation

If so, here is the difference between the two iCal versions:

$ diff task1.txt task2.txt
20c20
< DTSTAMP:20110919T141506Z
---
> DTSTAMP:20110919T141555Z
47a48
> X-MOZ-SEND-INVITATIONS:TRUE

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Ok, so it seems to be the notify attendees checkbox. Is that visible for you? What calendar type do you have selected when creating the new event?

Comment 7

[Tristan Miller]

Philipp, some of the events I open have the "Notify attendees" checkbox visible and checked, and others do not have any "Notify attendees" checkbox at all.  In both cases, I get the unwanted "Save Event" dialog when closing the event without making any changes.

To answer your second question, I am not creating any events.  The events I am opening were created by other people on a shared CalDAV calendar.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Tristan, does it also happen when editing events on a local calendar? Could you enable calendar.debug.log and calendar.debug.log.verbose and let me know which DAV Options the caldav server supports? (i.e calendar-auto-schedule). You get this info when first connecting to the caldav server after startup.

Comment 9

[Tristan Miller]

Philipp, I enabled those logging settings.  Is this the portion of the log you're interested in?

CalDAV: send: OPTIONS http://localhost:1080/users/miller%40tk.informatik.tu-darmstadt.de/
CalDAV: DAV header: 1, calendar-access, calendar-schedule, calendarserver-private-events, addressbook
CalDAV: Calendar UKP generally supports calendar-schedule

If not, let me know more specifically what I should be looking for and I'll post it.

I can't reproduce the problem with a local calendar; it happens only with the CalDAV one.

Comment 10

[Felix Möller]

I wanted to report the very same issue, as I experience it on my Apple calendar server from current trunk.

The headers are as follows:
DAV	1, access-control, calendar-access, calendar-schedule, calendar-auto-schedule, calendar-availability, inbox-availability, calendar-proxy, calendarserver-private-events, calendarserver-private-comments, calendarserver-sharing, calendarserver-sharing-no-scheduling, calendar-query-extended, addressbook, extended-mkcol, calendarserver-principal-property-search

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

So this likely has to do with the way the X-MOZ-SEND-INVITATIONS property is set. It should be trivial to fix, but you need someone with time and access to a such server to fix it. I don't have either.

Felix, if you feel like fixing this, start looking here:

http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog.js#2267

and here:

http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog.js#445

and here:
http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog.js#3094

The property should likely be ignored while comparing changes, or be serialized correctly.

Comment 12

[Felix Möller]

Can somebody provide a way to reproduce this? I have experienced this before myself, however, I cannot make it occur with current lightning.

Does it maybe just happen if the events were created with an older version of Lightning?

Comment 13

[Tristan Miller]

In my case, the events were created on a Microsoft Exchange server with Microsoft Outlook.  I'm reading them in Thunderbird+Lightning through the DavMail Exchange-to-CalDav gateway.

Comment 14

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Felix, please check the conditions in the source code I linked. The notify attendees row needs to be visible and then maybe some combination of having an identity set, or maybe that calendar.itip.send pref, who knows :)

Comment 15

[Stan King]

Hello, all.  I see this behavior each and every time I try to close an event I've viewed.  It happens both for events created within lightning, as well as those I create by clicking on a .ics attachment in an incoming e-mail message.

I'd be happy to gather and provide any information that might help get to the bottom of this.

I'm using Thunderbird 8 and Lightning 1.0 (updated 11/19/2011) on Fedora 15 for x86_64.
Long form of the package IDs:

thunderbird-8.0-2.fc15.x86_64
thunderbird-lightning-1.0-1.fc15.x86_64

Comment 16

[marcel]

I can confirm this bug with Lightning 1.1 in TB 9 on Win7. The behavior is correct for local calendars. It's incorrect (i.e. as reported) for events on CalDAV (Zimbra) that I was invited to. For events on CalDAV that I added myself the behavior is also correct.
The only thing reported in the console is 
Warning: Use of getAttributeNode() is deprecated. Use getAttribute() instead.
Source File: chrome://calendar/content/calendar-event-dialog.xul
Line: 0

Comment 18

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

This patch takes care by ignoring that property. I've also noticed that in some cases, the CN property of the organizer is also changed, so I've taken this out by default too. I know the organizer shouldn't have this prop at all, but thats another bug.

Comment 19

[Matthew Mecca [:mmecca]]

Comment on attachment 721669 [details] [diff] [review]
Fix - v1

Looks good. r=mmecca

Comment 20

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central changeset 4053e929957f