688520 - Kick off a sync on "Add a Device"

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Philipp von Weitershausen [:philikon]]

Single device users only sync once an hour (on Firefox <=7 only once a day), so when they add their second device, their most recent data may not be present on the server yet. We should simply kick off a sync when the user opens the "Add a Device" wizard and starts entering numbers.

Comment 1

[Richard Newman [:rnewman]]

*waits patiently for the inevitable time that some user figures out that this is a Sync Now button in disguise* :D

Comment 2

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/services/services-central/rev/95bee1fc8117

The next Services QA train will probably not make the Aurora cut-off, but I'm hopefull we can convince release drivers to allow this to go into Aurora (9) and Beta (8).

Comment 3

[Philipp von Weitershausen [:philikon]]

(In reply to Philipp von Weitershausen [:philikon] from comment #2)
> https://hg.mozilla.org/services/services-central/rev/95bee1fc8117
> 
> The next Services QA train will probably not make the Aurora cut-off, but
> I'm hopefull we can convince release drivers to allow this to go into Aurora
> (9) and Beta (8).

Bah, wrong bug :(

Comment 4

[Philipp von Weitershausen [:philikon]]

(In reply to Richard Newman [:rnewman] from comment #1)
> *waits patiently for the inevitable time that some user figures out that
> this is a Sync Now button in disguise* :D

I'm not too worried about this, tbh. Yes, with bug 675817 we want to disable "Sync Now" in primary UI (do the Google Docs thing where it just says "Synced"). But we'll still have a Sync Now button in prefs or so, I think.

Comment 5

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 6

[Richard Newman [:rnewman]]

(In reply to Philipp von Weitershausen [:philikon] from comment #4)

> I'm not too worried about this, tbh.

Yeah, just a wry observation. See some Mac users and their religious use of Repair Permissions… :D

Comment 7

[Richard Newman [:rnewman]]

Comment on attachment 561858 [details] [diff] [review]
v1

Review of attachment 561858 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/syncAddDevice.js
@@ +61,5 @@
>  
>      this.throbber = document.getElementById("add-device-throbber");
>      this.errorRow = document.getElementById("errorRow");
> +
> +    // Kick off a sync. That way the server has the most recent data from this

"will have the most...", no?

Comment 8

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/services/services-central/rev/adb4b1d6a712

Comment 9

[Tracy Walker [:tracy]]

verified with s-c that the add a device link kicks off a sync

Comment 10

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/mozilla-central/rev/adb4b1d6a712

Comment 11

[Tony Chung [:tchung]]

Verified on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0a1) Gecko/20111007 Firefox/10.0a1
and Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/201101007 Firefox/9.0a1 Fennec/9.0a1