688694 - Make Account Settings dialog wider for Windows 7 after bug 567280

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: screen shot

After bug 567280 (which introduced scroll bars to the content area of the MailNews Account Settings dialog), the dialog is not wide enough for some panes on Windows 7 (with default font settings) anymore, namely:

* Copies & Folders
* Composition & Addressing
* Return Receipts
* Server Settings (News)
* Synchronization and Storage (News)

As a consequence, horizontal scroll bars appear, which doesn't look nice.

From a glance it looks like the last one, Sync and Storage, needs the most extra space, so if we fix this one (see attached screen shot), the rest should be OK, too.

Please prioritize in case this has l10n impact (we only have a few days left until the Aurora uplift!).

Note: The Copies & Folders pane also has vertical scroll bars, but that's OK since we can hardly reduce the contents (esp. without affecting TB!) and expected behavior after bug 567280.

Comment 1

[Philip Chee]

> From a glance it looks like the last one, Sync and Storage, needs the most extra
> space, so if we fix this one (see attached screen shot), the rest should be OK, too.
Putting a flex=1 on the <checkbox id="nntp.removeBody" allows that pane to shrink horizontally enough for the horizontal scroll bar to disappear.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Attachment: re-sync dialog width and height with TB [Checkin: comment 5]

This all comes down to bug 660893 (port bug 654402), only now we'd have to port the width change, too. Doing that would fix that bug and this one in one go. The fact that it didn't happen already makes me sad, and I think I'm going to unassign from that other bug soon, too, if we don't get this done until the Aurora uplift (starting then it's too late because it has an l10n impact).

The complete MailNews Account Manager is shared with TB, only the dimensions (l10n) are not because mailnews/ has no locales directory. If it had, we wouldn't have this discussion and two bugs.

Now with the scroll bars, I hope Neil' "solution" of persisting the dialog size is finally off the table. It's simply a very bad UX to have scroll bars shown, and it doesn't matter to me much whether it's OK on Modern and/or Linux. Win7 is broken by default, and that is probably what most people are using nowadays.

Phil, changing the shared code XUL for the checkbox/label may solve this one issue (haven't checked, but sounds logical) but all the other panes would need fixing, too, and I don't think it's worth the effort to try to convince the TB devs that something that is already fixed for them needs further tweaks. You'd have to come up with a patch that fixes all panes *and* gets accepted by the TB devs before SM 2.6 ships (i.e. probably before the Aurora uplift since if I were a TB dev I probably wouldn't accept such changes afterwards even if l10n was not affected).

I'm attaching a patch to get us back in sync with TB regarding the default sizes now. If it gets rejected, I'll unassign myself again.

Comment 3

[[e-mail]]

Comment on attachment 562221 [details] [diff] [review]
re-sync dialog width and height with TB [Checkin: comment 5]

It's a little bit wider than I'd have liked but not too wide and since we're changing the height anyway...

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 562221 [details] [diff] [review]
re-sync dialog width and height with TB [Checkin: comment 5]

http://hg.mozilla.org/comm-central/rev/2083b65f57d3

Comment 6

[Philip Chee]

Comment on attachment 562221 [details] [diff] [review]
re-sync dialog width and height with TB [Checkin: comment 5]

Sorry for the late feedback.