68879 - Biff doesn't clear

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[scottputterman]

WinNT 2001021408 IMAP

Biff should clear on the account level and the taskbar when I acknowledge it.  The
 ways it acknowledges it is by doing something like reading a message or doing
Get Messages.  Get Messages clears biff just fine, but I'm finding that even
after I read all of my new messages in a folder, the account level biff
indicator and the taskbar indicator both stay turned on.

Comment 1

[scottputterman]

nominating for nsbeta1 because it makes me think I have new mail when I really
don't.

Comment 2

[scottputterman]

marking nsbeta1+ and moving to mozilla0.9

Comment 3

[fenella]

Assign to Sheela

Comment 4

[Sheela Ravindran]

adding to main biff tracking bug

Comment 5

[scottputterman]

moving to mozilla0.9.1

Comment 6

[scottputterman]

*** Bug 75628 has been marked as a duplicate of this bug. ***

Comment 7

[[e-mail] (gone - use [e-mail] instead)]

I swear this worked a day or two before the mail/news branch merged.  I think
Bhuvan fixed a leak that made this work. 

Comment 8

[[e-mail] (gone - use [e-mail] instead)]

Just to note: this is broken with POP3, too, so seems no to be protocol specific.

Comment 9

[Sheela Ravindran]

Still seeing this on 2001-04-19-08 builds. Biff arrow stays at the account level
and taskbar after all the messages are read on mac and linux for both imap and
pop accounts. However windows imap is fine but not pop account.  

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Sheela, even after reading all new messages in my IMAP account, biff still
doesn't clear until I do a GetMsg.  Suresh can confirm this also (we looked
briefly at this problem yesterday)

Comment 11

[scottputterman]

Windows imap doesn't work for me either. 

Comment 12

[laurel]

*** Bug 62087 has been marked as a duplicate of this bug. ***

Comment 13

[Håkan Waara]

I'm not sure, but I don't think it's networking specific. 

Still not workin btw, when I do GetMsgs and then read all new - the biff
indicator is still on the account until I press GetMsgs and I don't have any
emails left to download.

Comment 14

[[e-mail] (gone - use [e-mail] instead)]

*** Bug 67834 has been marked as a duplicate of this bug. ***

Comment 15

[Andreas Premstaller]

67834<68879

<wonder>
from: http://www.mozilla.org/quality/help/bugzilla-helper.html
> [...]
> Step 2. Search for your bug.
> [...]

is this valid only for dummy non-netscape employees?
</wonder>

Comment 16

[Eric Vaandering (no email)]

When starting a new navigator window, the biff state is set right for that
window, while the others still show unread messages

Comment 17

[scottputterman]

suresh says he has a fix so reassigning.

Comment 18

[Suresh]

Attachment: patch to fix this!

Comment 19

[Suresh]

Oh wait! I found a case where this breaks again :( Ignore my previous patch. New
patch on its way...

Comment 20

[Suresh]

Attachment: new patch attached

Comment 21

[Suresh]

Adding racham for review.

Comment 22

[racham]

Suresh,

Things I noticed are that you may want to revisit the indentation and also
making the portion of the code you didn't really modify untouched AND optimize
the code in nsMsgFolderDataSource.cpp to use to get the folder in question and
then to execute the common code block.

bhuvan

Comment 23

[Suresh]

Attachment: updated patch

Comment 24

[racham]

Indentation still seems to be little off. Please take care of that.

Make sure you run some sample tests to validate the optimizations you did are
working the way they are expected to.

r=bhuvan

Comment 25

[David :Bienvenu]

It would be better to replace 
+    else if((changedFlags & MSG_FLAG_READ) || (changedFlags & MSG_FLAG_REPLIED)
+     || (changedFlags & MSG_FLAG_FORWARDED) || (changedFlags &
MSG_FLAG_IMAP_DELETED)
+     || (changedFlags & MSG_FLAG_NEW) || (changedFlags & MSG_FLAG_OFFLINE))

with else if (changedFlags & (MSG_FLAG_READ|MSG_FLAG_REPLIED...))

also, indentation/tabs seem messed up, especially in the second part of the patch.

Comment 26

[Suresh]

Attachment: Updated patch.

Comment 27

[David :Bienvenu]

Not MSG_FLAG_READ || MSG_FLAG_REPLIED || MSG_FLAG_FORWARDED
+      || MSG_FLAG_IMAP_DELETED || MSG_FLAG_NEW || MSG_FLAG_OFFLINE)

,
MSG_FLAG_READ | MSG_FLAG_REPLIED | ...

you want the bitwise Or, '|', not the logical Or, ||

Comment 28

[Suresh]

Attachment: updated patch!

Comment 29

[David :Bienvenu]

sr=bienvenu.

For future reference, you don't need the extra ()'s in something like this:

if ((a | b))

if (a | b) is fine.

Comment 30

[Suresh]

I checked in yesterday!

Comment 31

[Sheela Ravindran]

verified,
2001051710 win98
2001051708 mac
2001051708 linux

Comment 32

[Sheela Ravindran]

*** Bug 80527 has been marked as a duplicate of this bug. ***