688860 - Cannot switch spell check language with multiple compose windows open

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Jesper Kristensen]

Attachment: patch

In investigating bug 687319 I found this.

Steps to reproduce:
1. Have two dictionaries installed, for example the built in en-US plus https://addons.mozilla.org/da/firefox/addon/dansk-ordbog/
2. Have two compose windows open
3. Switch focus between the main editing area of the two windows a couple of times
4. Try to switch between dictionaries a couple of times

Expected result: Selected language changes
Actual result: Selected language gets stuck

Possibly related to bug 338427 and/or bug 591780.

Comment 1

[Philip Chee]

Normally you need a suite peer for the suite part of that patch, but I guess Standard8's r+ would be good enough for us here.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 562153 [details] [diff] [review]
patch

Sorry for the delay in getting to this. It looks fine.

Thanks for the patch.

Comment 3

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/aa5b97afb1f2

Comment 4

[Philip Chee]

Attachment: Suite bustage fix.

Error: gSpellChecker is not defined
Source file: chrome://messenger/content/messengercompose/MsgComposeCommands.js
Line: 2219
 ----------
Error: gSpellChecker is not defined
Source file: chrome://messenger/content/messengercompose/MsgComposeCommands.js
Line: 2207

Suite should switch to InlineSpellChecker.jsm eventually. Meanwhile this is a minimal bustage fix. I'll take a review from any suite/mailnews peer whoever gets to it first.

Comment 5

[[e-mail]]

Comment on attachment 577855 [details] [diff] [review]
Suite bustage fix.

In the Compose window the variable might have been called sSpellChecker ;-) (although it might in future be possible to declare the spell checker in an editor overlay in which case it would be gSpellChecker again...)

Comment 6

[Philip Chee]

Comment on attachment 577855 [details] [diff] [review]
Suite bustage fix.

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/58cf9351cc23

Apologies to Jesper Kristensen for not spotting this earlier.