Closed Bug 688860 Opened 8 years ago Closed 8 years ago
Cannot switch spell check language with multiple compose windows open
In investigating bug 687319 I found this. Steps to reproduce: 1. Have two dictionaries installed, for example the built in en-US plus https://addons.mozilla.org/da/firefox/addon/dansk-ordbog/ 2. Have two compose windows open 3. Switch focus between the main editing area of the two windows a couple of times 4. Try to switch between dictionaries a couple of times Expected result: Selected language changes Actual result: Selected language gets stuck Possibly related to bug 338427 and/or bug 591780.
Attachment #562153 - Flags: review?(mbanner)
Normally you need a suite peer for the suite part of that patch, but I guess Standard8's r+ would be good enough for us here.
Comment on attachment 562153 [details] [diff] [review] patch Sorry for the delay in getting to this. It looks fine. Thanks for the patch.
Attachment #562153 - Flags: review?(mbanner) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
Error: gSpellChecker is not defined Source file: chrome://messenger/content/messengercompose/MsgComposeCommands.js Line: 2219 ---------- Error: gSpellChecker is not defined Source file: chrome://messenger/content/messengercompose/MsgComposeCommands.js Line: 2207 Suite should switch to InlineSpellChecker.jsm eventually. Meanwhile this is a minimal bustage fix. I'll take a review from any suite/mailnews peer whoever gets to it first.
Comment on attachment 577855 [details] [diff] [review] Suite bustage fix. In the Compose window the variable might have been called sSpellChecker ;-) (although it might in future be possible to declare the spell checker in an editor overlay in which case it would be gSpellChecker again...)
Attachment #577855 - Flags: review?(neil) → review+
Comment on attachment 577855 [details] [diff] [review] Suite bustage fix. Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/58cf9351cc23 Apologies to Jesper Kristensen for not spotting this earlier.
You need to log in before you can comment on or make changes to this bug.