The default bug view has changed. See this FAQ.

Cannot switch spell check language with multiple compose windows open

RESOLVED FIXED in Thunderbird 11.0

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: Jesper Kristensen, Assigned: Jesper Kristensen)

Tracking

Trunk
Thunderbird 11.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Created attachment 562153 [details] [diff] [review]
patch

In investigating bug 687319 I found this.

Steps to reproduce:
1. Have two dictionaries installed, for example the built in en-US plus https://addons.mozilla.org/da/firefox/addon/dansk-ordbog/
2. Have two compose windows open
3. Switch focus between the main editing area of the two windows a couple of times
4. Try to switch between dictionaries a couple of times

Expected result: Selected language changes
Actual result: Selected language gets stuck

Possibly related to bug 338427 and/or bug 591780.
Attachment #562153 - Flags: review?(mbanner)

Comment 1

6 years ago
Normally you need a suite peer for the suite part of that patch, but I guess Standard8's r+ would be good enough for us here.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Comment on attachment 562153 [details] [diff] [review]
patch

Sorry for the delay in getting to this. It looks fine.

Thanks for the patch.
Attachment #562153 - Flags: review?(mbanner) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/aa5b97afb1f2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0

Comment 4

5 years ago
Created attachment 577855 [details] [diff] [review]
Suite bustage fix.

Error: gSpellChecker is not defined
Source file: chrome://messenger/content/messengercompose/MsgComposeCommands.js
Line: 2219
 ----------
Error: gSpellChecker is not defined
Source file: chrome://messenger/content/messengercompose/MsgComposeCommands.js
Line: 2207

Suite should switch to InlineSpellChecker.jsm eventually. Meanwhile this is a minimal bustage fix. I'll take a review from any suite/mailnews peer whoever gets to it first.
Attachment #577855 - Flags: review?(neil)
Attachment #577855 - Flags: review?(mnyromyr)

Comment 5

5 years ago
Comment on attachment 577855 [details] [diff] [review]
Suite bustage fix.

In the Compose window the variable might have been called sSpellChecker ;-) (although it might in future be possible to declare the spell checker in an editor overlay in which case it would be gSpellChecker again...)
Attachment #577855 - Flags: review?(neil) → review+

Comment 6

5 years ago
Comment on attachment 577855 [details] [diff] [review]
Suite bustage fix.

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/58cf9351cc23

Apologies to Jesper Kristensen for not spotting this earlier.
Attachment #577855 - Flags: review?(mnyromyr)

Updated

5 years ago
Duplicate of this bug: 700631

Updated

4 years ago
Duplicate of this bug: 716506
You need to log in before you can comment on or make changes to this bug.