Closed Bug 21432 Opened 20 years ago Closed 8 years ago

Implement Print Preview and Print Setup / Page Setup as in the browser

Categories

(SeaMonkey :: Composer, defect)

defect
Not set

Tracking

(seamonkey2.6 fixed)

RESOLVED FIXED
seamonkey2.6
Tracking Status
seamonkey2.6 --- fixed

People

(Reporter: mcafee, Assigned: iann_bugzilla)

References

Details

(Keywords: polish, Whiteboard: composer++)

Attachments

(2 files, 1 obsolete file)

Print|Preview brings up Print|Setup, AND Print|Setup is showing up
as a huge page.
Assignee: beppe → cmanske
assigning to Charley so he can take a look
Status: NEW → ASSIGNED
Target Milestone: M14
Do whatever the browser does, which is currently not much!
Summary: Print|Preview brings up Print|Setup → Implement Print Preview and Print Setup as in the browser
bugs have been filed to fix the browser version of this.
*** Bug 10664 has been marked as a duplicate of this bug. ***
Target Milestone: M14 → M16
moving to m16 and cc dcone.

Don -- can you tell me when the infrastructure will be in for Print/Print
Preview?
Blocks: 17006
Moving bugs I know I won't get to in M16
Target Milestone: M16 → M17
http://bugzilla.mozilla.org/show_bug.cgi?id=20943 says that this feature (Print 
Preview) is out for Seamonkey.
setting to future along with browser print preview and print setup
Depends on: 20943
Target Milestone: M17 → Future
*** Bug 47208 has been marked as a duplicate of this bug. ***
Is this going to be in since http://bugzilla.mozilla.org/show_bug.cgi?id=20943 
is marked mozilla0.8?   Do we need similar bugs for mail?

Thanks.
If 20943 is fixed, then it is very easy for me to do the editor version, since
it simply involves requesting a file save before calling the browser's print
methods.
Setting our milestone to 0.9
Target Milestone: Future → mozilla0.9
Whiteboard: DEPENDS
Adding status to track important bugs that will be fixed automatically or with
minimum work once dependent bug is fixed.
Related bugs have been futured. Changing this as well. Too bad! 
Target Milestone: mozilla0.9 → Future
spam composer change
Component: Editor: Core → Editor: Composer
Blocks: 103890
Would it be sensible to put print preview into its own editor tab?
Now that Bug 20943 has been fixed, can this be retargeted?
*** Bug 163395 has been marked as a duplicate of this bug. ***
*** Bug 163396 has been marked as a duplicate of this bug. ***
Keywords: nsbeta1, polish
Whiteboard: DEPENDS
Target Milestone: Future → ---
If this is easy to do, let's do it!  It would be a big win for home users.  nsbeta1+

(I like the separate tab idea -- would that be much more difficult?)
Keywords: nsbeta1nsbeta1+
It's not easy, last time I looked, else I would have fixed it long ago!
Composer triage team: nsbeta1-
Keywords: nsbeta1+nsbeta1-
Guys:
THIS IS ABOUT PRINTING, BUT I CAN'T FIGURE OUT HOW TO FIND THE RIGHT SPOT, SO
YOU CAN REEASSIGN IT.
I can't figure out how to get an answer to this question, so I am reporting it
to Bugzilla in the hope of getting an answer (BTW Bugzilla is somewhat
counterintuitive, but far be it from me if this works for you and not the users
of the Mozilla browser who encounter problems . . .)

THIS IS A MAJOR ISSUE TO ME.

I need to print the content of some web pages, but Version 1.3 does not let me
PRINT and it cannot find the printer.  (I can't even get it to "print" to Adobe
Acrobat.)  Please let me know when you have a patch for this problem or if there
is another way I can print from my browser again.  

Until then, I will have to use (ugh) Micro$oft's Internet Exploiter.  (And I
really HATE to use it, so - please, PLEASE - let me know when you fix the
Mozilla browser so that I can print from it.)

IF THIS HAS GONE TO THE WRONG GROUP(which I assume), PLEASE FORWARD IT TO THE
RIGHT GROUP.

Thanks,
Hope
please don't editorialize
Assignee: cmanske → composer
Status: ASSIGNED → NEW
hope@spamcop.net,
Please file a bug and log your problem there including build number, reproduce
steps and other necessary informations. thanks!
Keywords: helpwanted
OS: Linux → All
Hardware: PC → All
Summary: Implement Print Preview and Print Setup as in the browser → Implement Print Preview and Print Setup / Page Setup as in the browser
*** Bug 194465 has been marked as a duplicate of this bug. ***
Whiteboard: composer++
Attachment #131557 - Flags: superreview?(rbs)
Attachment #131557 - Flags: review?(brade)
Comment on attachment 131557 [details] [diff] [review]
Add File / Page Setup

r=brade
Attachment #131557 - Flags: review?(brade) → review+
Comment on attachment 131557 [details] [diff] [review]
Add File / Page Setup

sr=rbs
Attachment #131557 - Flags: superreview?(rbs) → superreview+
Comment on attachment 131557 [details] [diff] [review]
Add File / Page Setup

Requesting approval because this provides some of the functionality of bug
159798 blocking bug 218324 (1.5 wish list) but is already checked into the
trunk.
Attachment #131557 - Flags: approval1.5?
Page Setup fix checked in, leaving bug open for Print Preview.
How much testing has been done on this? Without having resolved this bug and
gotten it verified on the trunk it's very hard to evaluate for inclusion in the
branch. Can we get a new bug for the remaining feature work? 

Adding a feature this late in the game seems risky to me. 
Comment on attachment 131557 [details] [diff] [review]
Add File / Page Setup

No response on testing. Not gonna make 1.5.
Attachment #131557 - Flags: approval1.5? → approval1.5-
.
Assignee: composer → neil.parkwaycc.co.uk
*** Bug 240374 has been marked as a duplicate of this bug. ***
Product: Browser → Seamonkey
STM adding print preview is a low risk addition
I'm surprised that this is still hanging around. In Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9a1) Gecko/20051119 MultiZilla/1.8.1.0s SeaMonkey/1.5a, we have preview enabled for the browser, email, and address book, but still not for composer or chat. (Interestingly enough, I can't even find a print menu function for Venkman, let alone print preview...I guess nobody ever thought about making hard copies of debugger windows... ;-) )

Anyway, I've voted for this bug. I suppose if it were more important to more people, it wold have received more votes by this point in time!

Lewis
Priority: P3 → --
QA Contact: sujay → composer
Depends on: 679320
Attached patch Add print preview (obsolete) — Splinter Review
This patch:
* Creates two helpers in sidebarOverlay.js for use by the toggleAffectedChrome functions.
* Switches browser toggleAffectedChrome function to use new helpers.
* Adds PrintPreviewListener code for editors.
* Adds toggleAffectedChrome function for editors.
* Adds relevant xul/js to add print preview option to menus and print toolbar button.

The patch from bug 679320 is needed for this patch to work.
Assignee: neil → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #553643 - Flags: review?(neil)
Keywords: helpwanted
Blocks: 676991
Comment on attachment 553643 [details] [diff] [review]
Add print preview

>+  commandTable.registerCommand("cmd_printpreview",   nsPrintPreviewCommand);
[Bah, why did mailnews have do do this one in lower case?]

>+  getNavToolbox: function () {
>+    return document.getElementById("sidebar-parent");
EditorToolbox, no?

>+<!ENTITY printPreviewCmd.accesskey "v">
Revert currently uses this access key. I couldn't think up an easy way around this; so far my best idea is Rever&t and E&xport to Text.

>+function SidebarHide_ReturnState() {
This looks a little ugly. I came up with the following idea:
function SidebarGetState() {
  if (sidebar_is_hidden())
    return "hidden";
  if (sidebar_is_collapsed())
    return "collapsed";
  return "visible";
}

function SidebarSetState(aState) {
  document.getElementById("sidebar-box").hidden = aState != "visible";
  document.getElementById("sidebar-splitter").hidden = aState == "hidden";
}
Then you can call SidebarSetState("hidden"); to hide the sidebar.
Changes since last version:
* Fixed accesskey conflict as suggested.
* Made helpers in sidebarOverlay.js less ugly as suggested.
* Corrected element that getNavToolbox uses.
Attachment #553643 - Attachment is obsolete: true
Attachment #553786 - Flags: review?(neil)
Attachment #553643 - Flags: review?(neil)
Comment on attachment 553786 [details] [diff] [review]
Add print preview with no acceskey conflicts and less ugliness [Checked in: Comment 44]

>     // restoring normal mode (i.e., leaving print preview mode)
>-    if (gChromeState.sidebar == "was-collapsed" ||
>-        gChromeState.sidebar == "was-visible")
>-      document.getElementById("sidebar-splitter").hidden = false;
>-    if (gChromeState.sidebar == "was-visible")
>-      document.getElementById("sidebar-box").hidden = false;
Hmm, for some reason this code doesn't actually seem to work for a collapsed sidebar. At least now we've modularised it it will make it easier to fix in a followup bug :-)
Attachment #553786 - Flags: review?(neil) → review+
Comment on attachment 553786 [details] [diff] [review]
Add print preview with no acceskey conflicts and less ugliness [Checked in: Comment 44]

As editor.js and editorOverlay.dtd are shared files, asking for additional review.
Attachment #553786 - Flags: review?(mbanner)
Blocks: 680805
(In reply to Ian Neal from comment #41)
> Comment on attachment 553786 [details] [diff] [review] [diff] [details] [review]
> Add print preview with no acceskey conflicts and less ugliness
> 
> As editor.js and editorOverlay.dtd are shared files, asking for additional
> review.

and ComposerCommands.js (which makes where you're putting things a bit more understandable).
Comment on attachment 553786 [details] [diff] [review]
Add print preview with no acceskey conflicts and less ugliness [Checked in: Comment 44]

The TB bits look fine to me. You might just want to check that you're not adding a print preview option on Mac for SM, as Mac does things differently (the print dialog itself has a preview option).
Attachment #553786 - Flags: review?(mbanner) → review+
Comment on attachment 553786 [details] [diff] [review]
Add print preview with no acceskey conflicts and less ugliness [Checked in: Comment 44]

http://hg.mozilla.org/comm-central/rev/64c8bd724634
Attachment #553786 - Attachment description: Add print preview with no acceskey conflicts and less ugliness → Add print preview with no acceskey conflicts and less ugliness [Checked in: Comment 44]
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.6
Blocks: 688970
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.