689950 - RSS attachments can't be downloaded

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Matt]

The "Save" button for RSS attachments is disabled, preventing the user from downloading them. Right-clicking on the attachment itself opens the context menu, but the "Open" and "Save" options are grayed out.

I tried opening Thunderbird in safe mode, and this bug persists, so it doesn't seem to be an add-on issue. I have the feed message view set to Original HTML and Summary. Changing these didn't help either.

Comment 1

[Joe]

I'm having the same problem.  I also tried creating a new profile with nothing but a single RSS subscription to ensure that it wasn't an issue with my profile and had the same result.  Attachments to RSS feeds can't be saved or launched.

Comment 2

[Jim Porter (:squib)]

Can you provide an example feed for me to test?

Comment 3

[Matt]

Sure thing. These are my 3 RSS feeds:

http://podcastrss.play.it/mully-and-hanley-show_mp3_32.xml
http://podcastrss.play.it/the-mcneil-and-spiegel-show_mp3_32.xml
http://www.daveramsey.com/media/audio/podcast/podcast_itunes.xml

Comment 4

[Brian]

This is a problem with TB7 under 64-bit Linux too. I've got a bunch of RSS feeds from the BBC, all of which have parts of radio programs attached. It's not possible to save these with TB7, as described above.

Comment 5

[Jim Porter (:squib)]

Attachment: Fix this

This is my fault; sorry about that. Here's a fix, though.

I'm not sure about tests for this. We don't seem to have any Mozmill tests for RSS, so that would probably be a lot of work, but I suppose I could create a MIME message with the same structure as what we store for the feed message and test that instead (i.e. just create a MIME message with an external attachment whose URL uses http).

Comment 6

[Jim Porter (:squib)]

I mentioned this on the support list, but for completeness, I'll repeat it here. I uploaded an add-on to AMO to work around the issue for folks who want to stay on 7.0: https://addons.mozilla.org/en-US/firefox/addon/rss-attachment-fix/

Comment 7

[Ludovic Hirlimann [:Usul]]

(In reply to Jim Porter (:squib) from comment #5)
> Created attachment 563579 [details] [diff] [review] [diff] [details] [review]
> Fix this
> 
> This is my fault; sorry about that. Here's a fix, though.
> 
> I'm not sure about tests for this. We don't seem to have any Mozmill tests
> for RSS, so that would probably be a lot of work, but I suppose I could

How about starting to add tests for RSS by creating one for this particular case , then we could easily expand on these in the future.

Comment 8

[Jim Porter (:squib)]

(In reply to Ludovic Hirlimann [:Usul] from comment #7)
> How about starting to add tests for RSS by creating one for this particular
> case , then we could easily expand on these in the future.

I could look at it, but I think this would be fairly complicated (at least, it would take me a while to get a good handle on all the RSS stuff). Maybe it would be better as a followup.

Comment 9

[Mark Banner (:standard8)]

There's a separate bug for RSS unit tests (or at least getting them initially set up, which I can't find at the moment), but for now we should also make sure we've got some litmus tests for saving attachments for normal mail accounts & others.

Comment 10

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/cce766c7afd7

Comment 11

[Mark Banner (:standard8)]

Checked into branches:

http://hg.mozilla.org/releases/comm-aurora/rev/c2f9f8ee398b
http://hg.mozilla.org/releases/comm-beta/rev/5f7353ab4cd2

Comment 13

[Ludovic Hirlimann [:Usul]]

(In reply to Mark Banner (:standard8) from comment #9)
> There's a separate bug for RSS unit tests (or at least getting them
> initially set up, which I can't find at the moment), but for now we should
> also make sure we've got some litmus tests for saving attachments for normal
> mail accounts & others.

We have it for normal email account. I added one for rss at https://litmus.mozilla.org/show_test.cgi?id=40443