Closed
Bug 689950
Opened 13 years ago
Closed 13 years ago
RSS attachments can't be downloaded
Categories
(Thunderbird :: Message Reader UI, defect)
Tracking
(thunderbird8+ fixed, thunderbird9+ fixed)
RESOLVED
FIXED
Thunderbird 10.0
People
(Reporter: bigchico, Assigned: squib)
References
Details
(Whiteboard: [see add-on in comment 6])
Attachments
(1 file)
513 bytes,
patch
|
standard8
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
The "Save" button for RSS attachments is disabled, preventing the user from downloading them. Right-clicking on the attachment itself opens the context menu, but the "Open" and "Save" options are grayed out. I tried opening Thunderbird in safe mode, and this bug persists, so it doesn't seem to be an add-on issue. I have the feed message view set to Original HTML and Summary. Changing these didn't help either.
I'm having the same problem. I also tried creating a new profile with nothing but a single RSS subscription to ensure that it wasn't an issue with my profile and had the same result. Attachments to RSS feeds can't be saved or launched.
Updated•13 years ago
|
Assignee | ||
Comment 2•13 years ago
|
||
Can you provide an example feed for me to test?
Sure thing. These are my 3 RSS feeds: http://podcastrss.play.it/mully-and-hanley-show_mp3_32.xml http://podcastrss.play.it/the-mcneil-and-spiegel-show_mp3_32.xml http://www.daveramsey.com/media/audio/podcast/podcast_itunes.xml
This is a problem with TB7 under 64-bit Linux too. I've got a bunch of RSS feeds from the BBC, all of which have parts of radio programs attached. It's not possible to save these with TB7, as described above.
Assignee | ||
Comment 5•13 years ago
|
||
This is my fault; sorry about that. Here's a fix, though. I'm not sure about tests for this. We don't seem to have any Mozmill tests for RSS, so that would probably be a lot of work, but I suppose I could create a MIME message with the same structure as what we store for the feed message and test that instead (i.e. just create a MIME message with an external attachment whose URL uses http).
Assignee: nobody → squibblyflabbetydoo
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #563579 -
Flags: review?(mbanner)
Assignee | ||
Comment 6•13 years ago
|
||
I mentioned this on the support list, but for completeness, I'll repeat it here. I uploaded an add-on to AMO to work around the issue for folks who want to stay on 7.0: https://addons.mozilla.org/en-US/firefox/addon/rss-attachment-fix/
Whiteboard: [see add-on in comment 6]
Comment 7•13 years ago
|
||
(In reply to Jim Porter (:squib) from comment #5) > Created attachment 563579 [details] [diff] [review] [diff] [details] [review] > Fix this > > This is my fault; sorry about that. Here's a fix, though. > > I'm not sure about tests for this. We don't seem to have any Mozmill tests > for RSS, so that would probably be a lot of work, but I suppose I could How about starting to add tests for RSS by creating one for this particular case , then we could easily expand on these in the future.
Assignee | ||
Comment 8•13 years ago
|
||
(In reply to Ludovic Hirlimann [:Usul] from comment #7) > How about starting to add tests for RSS by creating one for this particular > case , then we could easily expand on these in the future. I could look at it, but I think this would be fairly complicated (at least, it would take me a while to get a good handle on all the RSS stuff). Maybe it would be better as a followup.
Updated•13 years ago
|
Updated•13 years ago
|
Attachment #563579 -
Flags: review?(mbanner)
Attachment #563579 -
Flags: review+
Attachment #563579 -
Flags: approval-comm-beta+
Attachment #563579 -
Flags: approval-comm-aurora+
Comment 9•13 years ago
|
||
There's a separate bug for RSS unit tests (or at least getting them initially set up, which I can't find at the moment), but for now we should also make sure we've got some litmus tests for saving attachments for normal mail accounts & others.
Flags: in-litmus?(ludovic)
Comment 10•13 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/cce766c7afd7
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Target Milestone: --- → Thunderbird 10.0
Comment 11•13 years ago
|
||
Checked into branches: http://hg.mozilla.org/releases/comm-aurora/rev/c2f9f8ee398b http://hg.mozilla.org/releases/comm-beta/rev/5f7353ab4cd2
status-thunderbird8:
--- → fixed
status-thunderbird9:
--- → fixed
Comment 13•13 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #9) > There's a separate bug for RSS unit tests (or at least getting them > initially set up, which I can't find at the moment), but for now we should > also make sure we've got some litmus tests for saving attachments for normal > mail accounts & others. We have it for normal email account. I added one for rss at https://litmus.mozilla.org/show_test.cgi?id=40443
Flags: in-litmus?(ludovic) → in-litmus+
You need to log in
before you can comment on or make changes to this bug.
Description
•