Closed Bug 690522 Opened 13 years ago Closed 13 years ago

I tried to compose an email as I always do with one of my email distribution lists in my Address Book and when I highlight the list and click WRITE, nothing happens

Categories

(Thunderbird :: Address Book, defect)

7 Branch
x86
All
defect
Not set
normal

Tracking

(thunderbird8+ fixed, thunderbird9+ fixed)

RESOLVED FIXED
Thunderbird 10.0
Tracking Status
thunderbird8 + fixed
thunderbird9 + fixed

People

(Reporter: lfc, Assigned: mconley)

References

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:6.0.2) Gecko/20100101 Firefox/6.0.2
Build ID: 20110902133214

Steps to reproduce:

I tried to compose an email as I always do with one of my email distribution lists in my Address Book and when I highlight the list and click WRITE, nothing happens - it should launch a blank composition window consisting of all the emails that comprise that list. After the latest update, this is not working.

Can someone please check this out.

Thank you,

Lou


Actual results:

nothing happens - it should launch a blank composition window consisting of all the emails that comprise that list. After the latest update, this is not working.


Expected results:

it should launch a blank composition window consisting of all the emails that comprise that list. After the latest update, this is not working.
I assume the last update is Thunderbird 7.
Component: General → Address Book
QA Contact: general → address-book
Yes, the last update is Thunderbird 7.
I can see this too, confirming on linux.
"Write" on normal (single) recipient not member of a list does work fine.
Also "write" on a member of a list works.
Choosing an addressbook and pressing "write" opens a compose window with no recipient prefilled (probably correct).
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
I can confirm this bug; I get the following error message in the error console:

[Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIAbDirectory.getBoolValue]"  nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)"  location: "JS frame :: chrome://messenger/content/addressbook/abCommon.js :: AbNewMessage :: line 322"  data: no]

Arch Linux / Thunderbird 7.0.1
Can you confirm this worked with Thunderbird 6?

Which error console do you mean in Thunderbird?
(In reply to aceman from comment #5)
> Can you confirm this worked with Thunderbird 6?

Yes, it worked with Thunderbird 6. (I've just tested it myself.)

> Which error console do you mean in Thunderbird?

Yes, the Error Console in Thunderbird ("Tools -> Error Console").
Confirmed on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0a2) Gecko/20111004 Thunderbird/9.0a2

Error Console displays:

Error: uncaught exception: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIAbDirectory.getBoolValue]"  nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)"  location: "JS frame :: chrome://messenger/content/addressbook/abCommon.js :: AbNewMessage :: line 322"  data: no]

This looks like fallout from some of the extensibility work that went in for TB 7.

This line:  http://mxr.mozilla.org/comm-central/source/mail/components/addrbook/content/abCommon.js#363

is attempting to get a "HidesRecipients" bool pref, but if such a pref does not exist, getBoolPref fails, and the the error gets dumped out.
Assignee: nobody → mconley
Status: NEW → ASSIGNED
The current workaround is to manually highlight all the members of the mailing list, and click "write".

Ack, sorry for the regression here.  I'll see if I can land this for TB 8.
Also, for comment 7, I meant "getBoolValue", not "getBoolPref".
Attached patch Patch v1Splinter Review
Here's my first run at a patch, and includes a regression test.

Try builds coming in here: http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=4c038f2b8877
Comment on attachment 565596 [details] [diff] [review]
Patch v1

Not sure if I'm going to have try results for this one, since try seems a bit shaky these days.

All address book Mozmill tests pass on my Linux box with repeated runs.
Attachment #565596 - Flags: review?(mbanner)
i am sure this is a bug since :aceman reproduced it but I can't reproduced it in Windows 7 RV 7.0.1! Here's what I tried:
1. create a new mailing list called 'all-rolands' with  2 email addresses
2. saved the mailing list
3. opened the address book
4. selected 'all-rolands' and clicked Write
Result:
Compose window opened and I was able to send an email to the correct 2 email addresses
Try to open TB again and go to the mailinglist. Maybe creating the list in the same session changes that state so that the bug does not appear.
Anyway, there is a patch on the way (comment 11) so it seems the developers see the bug too.
(In reply to aceman from comment #13)
> Try to open TB again and go to the mailinglist. Maybe creating the list in
> the same session changes that state so that the bug does not appear.
> Anyway, there is a patch on the way (comment 11) so it seems the developers
> see the bug too.

Thanks! i have reproduced this problem on Mac after following your advice, couldn't reproduce it on Windows even after I closed TB and started it again, workaround: type the list name in TO: or CC: or BCC:
Attachment #565596 - Flags: review?(mbanner) → review+
Attachment #565596 - Flags: approval-comm-beta?
Attachment #565596 - Flags: approval-comm-aurora?
Committed to comm-central as:  http://hg.mozilla.org/comm-central/rev/f83d90948464
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
Attachment #565596 - Flags: approval-comm-beta?
Attachment #565596 - Flags: approval-comm-beta+
Attachment #565596 - Flags: approval-comm-aurora?
Attachment #565596 - Flags: approval-comm-aurora+
Depends on: 695312
Blocks: 761803
You need to log in before you can comment on or make changes to this bug.