Closed Bug 695312 Opened 9 years ago Closed 9 years ago

TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run during Mozmill test addrbook/test-address-book.js

Categories

(Thunderbird :: Testing Infrastructure, defect)

8 Branch
x86
All
defect
Not set
normal

Tracking

(thunderbird8 fixed)

RESOLVED FIXED
Thunderbird 8.0
Tracking Status
thunderbird8 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 file)

Since landing the fix for writing to mailing lists, we've had test failures on beta.

Turns out that this is because the test I wrote for this fix relies on Controller.eid, which I believe is only automatically available in the Mozmill version that we have in trunk / Aurora.

The solution was to write a helper function for getting the address book controller, and using augment_controller from the window helpers for it.

Patch forthcoming.
Attached patch Patch v1Splinter Review
Tests pass for me locally with this patch.
Assignee: nobody → mconley
Attachment #567731 - Flags: review?(mbanner)
Attachment #567731 - Flags: approval-comm-beta?
Comment on attachment 567731 [details] [diff] [review]
Patch v1

Looks like Standard8 isn't online yet - shifting review request.
Attachment #567731 - Flags: review?(mbanner) → review?(dbienvenu)
Attachment #567731 - Flags: review?(dbienvenu)
Attachment #567731 - Flags: review+
Attachment #567731 - Flags: approval-comm-beta?
Attachment #567731 - Flags: approval-comm-beta+
Committed to beta as http://hg.mozilla.org/releases/comm-beta/rev/85bc6150ae39
Blocks: 690522
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 8.0
You need to log in before you can comment on or make changes to this bug.