move panorama code to browser/components/tabview

RESOLVED FIXED in Firefox 10

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

Trunk
Firefox 10
Bug Flags:
in-testsuite -

Details

Attachments

(1 attachment, 1 obsolete attachment)

It's frustrating to need to wait for all the panorama test to run when running tests in browser/base/content that have nothing to do with it. We can pretty easily move the panorama code to browser/components/tabview, I think, which would solve that problem.
Created attachment 564891 [details] [diff] [review]
patch
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #564891 - Flags: review?(ttaubert)
Created attachment 564893 [details] [diff] [review]
real patch
Attachment #564891 - Attachment is obsolete: true
Attachment #564891 - Flags: review?(ttaubert)
Attachment #564893 - Flags: review?(ttaubert)
Comment on attachment 564893 [details] [diff] [review]
real patch

Review of attachment 564893 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing that!
Attachment #564893 - Flags: review?(ttaubert) → review+
https://hg.mozilla.org/integration/fx-team/rev/bdd575bda8ab
Whiteboard: [fixed-in-fx-team]
I accidentally also pushed this to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2326508537f8

Let's see what happens!
Flags: in-testsuite-
Target Milestone: --- → Firefox 10
I backed this out of fx-team, since it also landed on inbound with some minor changes do to a merge requirement:

https://hg.mozilla.org/integration/fx-team/rev/36e6eb27d0c2

I think HG fubared the backout with removals+additions :(
Whiteboard: [fixed-in-fx-team]

Comment 7

6 years ago
mbrubeck pushed a followup to inbound to resolve bustage:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94f2fa9f97b8

Comment 8

6 years ago
Even after the followup, this is still believed to be the cause of:
{
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug595518.js | Test timed out
}
(eg https://tbpl.mozilla.org/php/getParsedLog.php?id=6713613&tree=Mozilla-Inbound)

However due to 12 pushes in a row being either red or containing permaoranges, it's not entirely clear what the cause was.

Discussions on #developers between myself, mbrubeck, callek & others, came to the conclusion that we either needed to clean slate hg revert -r last known inbound green (which would have backed this out anyway), or have one last attempt by backing out this bug using hg backout in the hope hg backout wouldn't mess up the renames. The latter was performed using mercurial 1.9.2, but mercurial has unfortunately still not coped with them. The only consolation being that a complete revert to 12+ pushes prior to tip, would have lost the renames regardless.

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a589eefb2dad
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed12a4461eeb
https://hg.mozilla.org/integration/mozilla-inbound/rev/2db24d928e6c
https://hg.mozilla.org/integration/mozilla-inbound/rev/a589eefb2dad

When this relands, feel free to exclude the tweak you made to bug 689884 if that makes things simpler, since if left it will done by bug 692625 anyway.
Target Milestone: Firefox 10 → ---
Depends on: 695320
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb1d7530ea96
Target Milestone: --- → Firefox 10
https://hg.mozilla.org/mozilla-central/rev/eb1d7530ea96
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.