Last Comment Bug 695320 - TabView::init fails to handle session store window state changes that hide/show the toolbar
: TabView::init fails to handle session store window state changes that hide/sh...
Status: RESOLVED FIXED
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Panorama (show other bugs)
: Trunk
: All All
: -- normal
: Firefox 10
Assigned To: :Gavin Sharp [email: gavin@gavinsharp.com]
:
Mentors:
Depends on:
Blocks: 692130
  Show dependency treegraph
 
Reported: 2011-10-18 07:24 PDT by :Gavin Sharp [email: gavin@gavinsharp.com]
Modified: 2016-04-12 14:00 PDT (History)
3 users (show)
gavin.sharp: in‑testsuite+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.15 KB, patch)
2011-10-18 07:31 PDT, :Gavin Sharp [email: gavin@gavinsharp.com]
ttaubert: review+
Details | Diff | Review

Description :Gavin Sharp [email: gavin@gavinsharp.com] 2011-10-18 07:24:54 PDT
This was brought up by the browser/components/privatebrowsing/test/browser/browser_privatebrowsing_popupmode.js test once I attempted to land bug 692130 - the move to components meant the tabview tests now ran after the private browsing tests. That popupmode tests switching a window from being a popup to not being a popup and back, using ss.setWindowState().

Thanks to http://hg.mozilla.org/mozilla-central/rev/ed6776b1ac0d , setWindowState ends up calling TabView::init again to have the keyboard shortcut disabled correctly. Unfortunately, this only works for the transition from not-popup->popup, and not vice-versa. That results in the shortcut being broken in that window after the browser_privatebrowsing_popupmode test, which causes browser_tabview_bug595518.js to fail.

I propose we fix the code, since while browser_privatebrowsing_popupmode is doing something quite unusual, it's not easy to fix (using another window is complicated because of PB mode) and not something entirely unreasonable to expect to work (given behavior of setWindowState and its attempt to half-support that).
Comment 1 :Gavin Sharp [email: gavin@gavinsharp.com] 2011-10-18 07:31:17 PDT
Created attachment 567742 [details] [diff] [review]
patch
Comment 2 Tim Taubert [:ttaubert] 2011-10-20 03:18:06 PDT
Comment on attachment 567742 [details] [diff] [review]
patch

Review of attachment 567742 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Comment 3 :Gavin Sharp [email: gavin@gavinsharp.com] 2011-10-20 10:59:09 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/160410d0608c
Comment 4 Marco Bonardo [::mak] 2011-10-21 02:12:29 PDT
https://hg.mozilla.org/mozilla-central/rev/160410d0608c

Note You need to log in before you can comment on or make changes to this bug.