Closed Bug 692295 Opened 13 years ago Closed 7 years ago

nsWindowsShellService's ShortcutMaintenance can be removed ~ 6/12

Categories

(Firefox :: Shell Integration, defect)

Product:
Firefox
Component:
Shell Integration
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: jimm, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file, 1 obsolete file)

patch rev1
9.73 KB, patch
jimm
: review+
Details | Diff | Splinter Review 
Taskbar app registration is being upgraded in bug 577867 to use a more constant id. The code in ShortcutMaintenance upgrades this id when we do a major upgrade which will not be needed after bug 577867 lands *and* most of our users upgrade to that version.
Note that this affects Thunderbird too.

Should we do this? I think we should keep the code so that we do it one last time.
(In reply to Siddharth Agarwal [:sid0] from comment #1)
> Note that this affects Thunderbird too.
> 
> Should we do this? I think we should keep the code so that we do it one last
> time.

Note, per the bug title, 6/2012 is the target date of this work. By then active users should be upgraded.
No longer depends on: 577867
Depends on: 577867
Jim, are you still planning on fixing this bug? If not, just un-assign it from yourself. Thanks
Flags: needinfo?(jmathies)
Attached patch patch rev1 (obsolete) — — Splinter Review 
Assignee: jmathies → robert.strong.bugs
Status: NEW → ASSIGNED
Flags: needinfo?(jmathies)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch rev1
        — 
          — Splinter Review
      

    


  
My repo wasn't current

        Attachment #8875884 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 8875894 [details] [diff] [review]
patch rev1

Try is almost complete and it looks fine. I'll land this after the merge since we are currently in a soft freeze.

Jim, are you ok with reviewing this? The additional includes I removed were added for clearing prefetch files which was removed a long time ago.

        Attachment #8875894 -
        Flags: review?(jmathies)

    
    

    
  
Matt, just a heads up that this will be removed in the near future and that the helper.exe command line option can be removed.
Flags: needinfo?(mhowell)

    
  

        Attachment #8875894 -
        Flags: review?(jmathies) → review+

    
    

    
  
Thanks; filed bug 1371687.
Flags: needinfo?(mhowell)

    
    

    
  
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c26e57c1899
Remove nsWindowsShellService's ShortcutMaintenance method and calls now that it is no longer needed. r=jimm

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/1c26e57c1899
Status: ASSIGNED → RESOLVED
Closed: 7 years ago

          status-firefox56:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: