nsWindowsShellService's ShortcutMaintenance can be removed ~ 6/12

RESOLVED FIXED in Firefox 56

Status

()

defect
RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: jimm, Assigned: rstrong)

Tracking

(Blocks 2 bugs)

Trunk
Firefox 56
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

8 years ago
Taskbar app registration is being upgraded in bug 577867 to use a more constant id. The code in ShortcutMaintenance upgrades this id when we do a major upgrade which will not be needed after bug 577867 lands *and* most of our users upgrade to that version.
Note that this affects Thunderbird too.

Should we do this? I think we should keep the code so that we do it one last time.
(Reporter)

Comment 2

8 years ago
(In reply to Siddharth Agarwal [:sid0] from comment #1)
> Note that this affects Thunderbird too.
> 
> Should we do this? I think we should keep the code so that we do it one last
> time.

Note, per the bug title, 6/2012 is the target date of this work. By then active users should be upgraded.
No longer depends on: 577867
Depends on: 577867
Jim, are you still planning on fixing this bug? If not, just un-assign it from yourself. Thanks
Flags: needinfo?(jmathies)
Posted patch patch rev1 (obsolete) — Splinter Review
Assignee: jmathies → robert.strong.bugs
Status: NEW → ASSIGNED
Flags: needinfo?(jmathies)
Posted patch patch rev1Splinter Review
My repo wasn't current
Attachment #8875884 - Attachment is obsolete: true
Comment on attachment 8875894 [details] [diff] [review]
patch rev1

Try is almost complete and it looks fine. I'll land this after the merge since we are currently in a soft freeze.

Jim, are you ok with reviewing this? The additional includes I removed were added for clearing prefetch files which was removed a long time ago.
Attachment #8875894 - Flags: review?(jmathies)
Matt, just a heads up that this will be removed in the near future and that the helper.exe command line option can be removed.
Flags: needinfo?(mhowell)
(Reporter)

Updated

2 years ago
Attachment #8875894 - Flags: review?(jmathies) → review+
Thanks; filed bug 1371687.
Flags: needinfo?(mhowell)

Comment 11

2 years ago
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c26e57c1899
Remove nsWindowsShellService's ShortcutMaintenance method and calls now that it is no longer needed. r=jimm

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1c26e57c1899
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.