692370 - PGO builds don't appear in self-serve under the rev

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Phil Ringnalda (:philor)]

I was going to say of bug 692301 that it wasn't quite critical severity, since like most tbpl bobbles you could just look in self-serve to see what the status of the build was, and look at the log on stage if it wasn't green, but as https://build.mozilla.org/buildapi/self-serve/mozilla-central/rev/4a69b3fdd602 says, "pgo build? what pgo build? got some tests, but no build."

Comment 1

[Chris AtLee [:catlee]]

So the problem here looks like the PGO builds aren't getting triggered with a branch set in their sourcestamp. Looking at the scheduling code now.

Comment 2

[Chris AtLee [:catlee]]

The pgo build scheduler is missing a branch setting; patch coming shortly.

Comment 3

[Chris AtLee [:catlee]]

Attachment: Add branch name to pgo scheduler

Comment 4

[Chris AtLee [:catlee]]

they're there now!

https://build.mozilla.org/buildapi/self-serve/mozilla-central/build/5885490

Comment 5

[Phil Ringnalda (:philor)]

I hate to be a greedy pest, but as that link says, revision: null, and while it's nice that https://build.mozilla.org/buildapi/self-serve/mozilla-central with "pgo-build" in the filter shows lots of pgo-builds, all with empty revisions, what I actually mean when I say self-serve is "the Win PGO build in https://tbpl.mozilla.org/?tree=Mozilla-Aurora&rev=c0c7322521b7 is hosed, I want to either click tbpl's rebuild button, or the link to https://build.mozilla.org/buildapi/self-serve/mozilla-aurora/rev/c0c7322521b7 and be able to retrigger it there, but since there's no rev, there's no /rev/ and tbpl's rebuild request just fails with '(could not find build)'."

Comment 6

[Chris AtLee [:catlee]]

So, I'm not sure how TBPL is finding the jobs in self-serve, but I'm going to say this is blocked by 691675, since the implementation of that will most likely provide a revision via the scheduler, which will then be exposed via self-serve.

Comment 7

[Phil Ringnalda (:philor)]

tbpl finds them on the floor of a hotdog factory, in http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/file/tip/js/MachineResult.js#l115 where it looks for the buildid of the first build of the same type on that rev, so it does the same thing I do, opens the self-serve page for that rev and scans for "pgo-build".

Comment 8

[Phil Ringnalda (:philor)]

A revision would certainly be nice, since when we had the PGO-only regression that we never have, never having them being the reason we could get away with periodic PGO, I thought I was being all cunning by using https://build.mozilla.org/buildapi/self-serve/mozilla-inbound instead of the rev URL, to find and retrigger the PGO build, but of course without a revision it's not a retrigger, it's a "create a brand new build on whatever happens to be tip right now."

Comment 9

[Chris AtLee [:catlee]]

over to jhford to get the scheduling fixed (we need to schedule the jobs with an actual revision in the sourcestamp)

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

I am putting this bug back in the pool.  I am also unsure how to do this

Comment 12

[Chris AtLee [:catlee]]

Fixed by bug 691675.