691675 - Only do a PGO build if there are checkins on a branch

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement, P2)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

Since the patch for bug 658313 was written, a new feature for nightlies was implemented.  This feature is to only build if there have been changes since the last nightly.  Lets use this logic on PGO builds as well.  Once this is done, we might be ok to enable these periodic PGO builds on more branches.

Comment 3

[Chris AtLee [:catlee]]

Attachment: Use SpecificNightly scheduler for PGO builds

Use the SpecificNightly scheduler for PGO builds that selects the latest revision on a branch to build, and will only build it once.

Comment 4

[John Hopkins (:jhopkins)]

Comment on attachment 628332 [details] [diff] [review]
Use SpecificNightly scheduler for PGO builds

Looks reasonable.  One thing you might check is what happens if there's no last change on a branch (if that can happen).

Comment 5

[Chris AtLee [:catlee]]

Comment on attachment 628332 [details] [diff] [review]
Use SpecificNightly scheduler for PGO builds

If there's no last change on a branch, the functions return None and no PGO build is scheduled.

Comment 6

[Aki Sasaki (not active)]

This went went into production today.