694817 - Pare down webrtc package to the parts we actually need to have

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

the WebRTC drop from Google includes many things we don't expect to use, or duplicate code we have n Mozilla elsewhere (like libvpx)

Pare them out of our libxul linking

-> me, but others will be involved too

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Turn off webrtc's internal video renderer and protobuf

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

We don't need the internal renderer for a Mozilla build of webrtc.  We *do* need the capture modules, I believe, since we've set up getUserMedia() to use them.  I think protobuf wasn't actually getting built anyways (just for tests), but no reason to leave it enabled.

This patch may also sever our reliance on d3dx9.dll (see bug 772457)

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 640915 [details] [diff] [review]
Turn off webrtc's internal video renderer and protobuf

Did a build of m-c with the bug 691234 patches (getUserMedia) and this, and ran my simple "does getusermedia work" test.

Comment 4

[Timothy B. Terriberry (:derf)]

Comment on attachment 640915 [details] [diff] [review]
Turn off webrtc's internal video renderer and protobuf

Review of attachment 640915 [details] [diff] [review]:
-----------------------------------------------------------------

Longer term, do we want to upstream our configuration in a "build_with_gecko" configuration (like the "build_with_chromium" one) instead of patching the .gypi files directly?

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Turn off webrtc's internal video renderer and protobuf (take 2)

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Turn off webrtc's internal video renderer and protobuf (take 2)

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 641055 [details] [diff] [review]
Turn off webrtc's internal video renderer and protobuf (take 2)

Good point; we use build_with_mozilla in a bunch of other places, and this is a good spot to use it.  Also set the stand-alone settings back to the default.

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

I've done test builds and verified the internal renderer doesn't get put in the Makefile.

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Turn off webrtc's internal video renderer and protobuf (take 2)
https://hg.mozilla.org/integration/mozilla-inbound/rev/991e039721e3

Leaving open as there's more to do

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/991e039721e3