Pare down webrtc package to the parts we actually need to have

RESOLVED FIXED

Status

()

Core
Audio/Video
RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
the WebRTC drop from Google includes many things we don't expect to use, or duplicate code we have n Mozilla elsewhere (like libvpx)

Pare them out of our libxul linking

-> me, but others will be involved too
Blocks: 688178
(Assignee)

Comment 1

5 years ago
Created attachment 640915 [details] [diff] [review]
Turn off webrtc's internal video renderer and protobuf
(Assignee)

Comment 2

5 years ago
We don't need the internal renderer for a Mozilla build of webrtc.  We *do* need the capture modules, I believe, since we've set up getUserMedia() to use them.  I think protobuf wasn't actually getting built anyways (just for tests), but no reason to leave it enabled.

This patch may also sever our reliance on d3dx9.dll (see bug 772457)
See Also: → bug 772457
(Assignee)

Comment 3

5 years ago
Comment on attachment 640915 [details] [diff] [review]
Turn off webrtc's internal video renderer and protobuf

Did a build of m-c with the bug 691234 patches (getUserMedia) and this, and ran my simple "does getusermedia work" test.
Attachment #640915 - Flags: review?(tterribe)
Comment on attachment 640915 [details] [diff] [review]
Turn off webrtc's internal video renderer and protobuf

Review of attachment 640915 [details] [diff] [review]:
-----------------------------------------------------------------

Longer term, do we want to upstream our configuration in a "build_with_gecko" configuration (like the "build_with_chromium" one) instead of patching the .gypi files directly?
Attachment #640915 - Flags: review?(tterribe) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 641053 [details] [diff] [review]
Turn off webrtc's internal video renderer and protobuf (take 2)
(Assignee)

Updated

5 years ago
Attachment #640915 - Attachment is obsolete: true
(Assignee)

Comment 6

5 years ago
Created attachment 641055 [details] [diff] [review]
Turn off webrtc's internal video renderer and protobuf (take 2)
(Assignee)

Updated

5 years ago
Attachment #641053 - Attachment is obsolete: true
(Assignee)

Comment 7

5 years ago
Comment on attachment 641055 [details] [diff] [review]
Turn off webrtc's internal video renderer and protobuf (take 2)

Good point; we use build_with_mozilla in a bunch of other places, and this is a good spot to use it.  Also set the stand-alone settings back to the default.
Attachment #641055 - Flags: review?(tterribe)
(Assignee)

Updated

5 years ago
Attachment #641055 - Flags: review?(tterribe) → review?(ted.mielczarek)
(Assignee)

Comment 8

5 years ago
I've done test builds and verified the internal renderer doesn't get put in the Makefile.
Attachment #641055 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 9

5 years ago
Turn off webrtc's internal video renderer and protobuf (take 2)
https://hg.mozilla.org/integration/mozilla-inbound/rev/991e039721e3

Leaving open as there's more to do
Whiteboard: [leave open]
https://hg.mozilla.org/mozilla-central/rev/991e039721e3
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Whiteboard: [leave open]
You need to log in before you can comment on or make changes to this bug.