695233 - Flag the use of Components in Jetpack addons since it's being deprecated.

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect, P2)

Description

[Rob Hudson [:robhudson]]

Re: https://bugzilla.mozilla.org/show_bug.cgi?id=663541

It was originally agreed upon that checking for this in amo-validator would be good, but after reading the referenced bug closely I'm not sure.

We'd have to be able to detect the difference between use of Components if they haven't used require("chrome") vs if they have.  For example:

// OK, and recommended to make transition easier
var {Components} = require("chrome");
Components.classes...; // <- don't warn

// Not OK, Components will go away soon
Components.classes...; // <- do warn

Comment 1

[Matt Basta [:basta]]

My suggestion is to mark Components as a dangerous global in all Jetpack add-ons. Since it's deprecated, it should be a warning, like the "dangerous" flag produces.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

We're also warning whenever require("chrome") is present. Is the problem that 2 warnings will show up? I'm not too concerned about that.

Comment 3

[Rob Hudson [:robhudson]]

The problem I was seeing was that it would be difficult to do it "right".  But we can flag the use of Components to throw a warning and the developer can at least be notified of its deprecation and know for themselves if they've used `var {Components} = require("chrome");` they can safely ignore the warnings.

Comment 4

[Matt Basta [:basta]]

This requires that we differentiate between used and overridden globals, which is what's going to happen with bug 724997.

Comment 5

[Matt Basta [:basta]]

Done:

https://github.com/mozilla/amo-validator/commit/fb82464