Closed Bug 695446 Opened 10 years ago Closed 10 years ago
Password manager/Form Fill
* need a few more things from gcp/door hanger patch
OS: Mac OS X → Android
Priority: -- → P1
Hardware: x86 → ARM
Assignee: nobody → mark.finkle
Summary: Password manager → Password manager/Form Fill
Whiteboard: [birch] [ux needed]
This patch does some basic stuff: * Removes Fennec specific LoginManager.js component. We can use desktop (non-e10s) now. * Inits the login-manager in BrowserApp.startup (it uses lazy DB access, so the DB is not touched until really needed) * Removes Fennec specific LoginManagerPrompter.idl file. We can use desktop (non-e10s) now. * Removes some "&" access key stuff from the strings file. Using this patch, the LoginManager works using prompts (dialogs) for confirmations. I plan to add DoorHanger support next. If a webpage has more than 1 user login saved, the password is auto-entered when the username is manually entered. We should be able to add support for picking the login username from a list as well.
Comment on attachment 569387 [details] [diff] [review] WIP 1 No sense leaving this sit. I can add Doorhanger support in a new bug. Better to land this using Prompts and get bugs filed for feature issues. >+pref("signon.debug", true); I will revert this change
Attachment #569387 - Flags: review?(mbrubeck)
Comment on attachment 569387 [details] [diff] [review] WIP 1 >+++ b/mobile/locales/en-US/chrome/overrides/passwordmgr.properties >-notNowButtonText = &Not Now >+notNowButtonText = Not Now >-neverForSiteButtonText = Ne&ver for This Site >+neverForSiteButtonText = Never >-rememberButtonText = &Remember >+rememberButtonText = Remember We should change the string IDs if we want localizers to get rid of the ampersands in other locales too.
Attachment #569387 - Flags: review?(mbrubeck) → review+
pushed with pref reverted and string entities changed: https://hg.mozilla.org/projects/birch/rev/c775f204ec05 Filed bug 697659 for using Doorhangers Note: If a webpage has more than 1 user login saved, the password is auto-entered only after a username is manually entered into the username field (and focus leaves the username field)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified with: Aurora 11.0a2 (2012-01-08) HTC Desire Z (Android 2.3) Nightly 12.0a1 (2012-01-08) HTc Desire Z (Android 2.3) For only 1 user login saved, username and password fields are pre-populated. For more than 1 user, password is auto-entered if username is manually entered. If username is selected from the auto-complete suggestion list, password is not automatically entered. This issue is tracked in another bug. (Bug 716515 - Password not filled if username selected from autocomplete suggestions) )
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.