Closed Bug 697659 Opened 13 years ago Closed 13 years ago

Use doorhangers for Password Manager

Categories

(Firefox for Android Graveyard :: General, defect, P2)

x86
Linux
defect

Tracking

(firefox11 fixed, fennec11+)

VERIFIED FIXED
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

(Keywords: feature)

Attachments

(1 file, 1 obsolete file)

Baseline password/login manager landed using the prompt system. We need to add support for using doorhangers next.
Priority: -- → P2
Attached patch WIP 1 (obsolete) — Splinter Review
This patch makes the basic changes to LoginManagerPrompter.js to support using the new NativeWindow.doorhanger API.

The main thing yet to add is the concept of a "timeout" or "persistence" to a doorhanger. Normally, we remove doorhangers on pageload, but with password doorhangers, a page load is expected (to the login OK or invalid page) so we shouldn't dismiss the doorhanger right a way.

Will add that support to Doorhanger next.
Depends on: 700913
Attached patch patchSplinter Review
This patch converts the Fennec LoginManagerPrompter.js from using "notificationbox" API to use "doorhanger" API. I tried to change as little code as possible. We just work to get the NativeWindow object instead of the notifyBox.

I use the new persistence and timeout doorhanger features to mimic the same behavior in Fennec as found on desktop.

(I was having a problem while testing this patch. The doorhanger didn't want to dismiss after tapping a button. Updating my source tree to get the latest patches fixed that issue.)
Attachment #571244 - Attachment is obsolete: true
Attachment #574778 - Flags: review?(margaret.leibovic)
Comment on attachment 574778 [details] [diff] [review]
patch

We should probably update all the comments that talk about showing notification bars, since we don't do that anymore.
Attachment #574778 - Flags: review?(margaret.leibovic) → review+
I updated some of the "notification bar" comments to "notification doorhanger", but left the function names as is

https://hg.mozilla.org/projects/birch/rev/add4665a783d
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [QA?]
Flags: in-litmus?(fennec)
Whiteboard: [QA?] → [QA+]
Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111130 Firefox/11.0a1 Fennec/11.0a1
Device: HTC Desire Z
OS: Android 2.3

Door hangers are used for password manager.
Status: RESOLVED → VERIFIED
Flags: in-litmus?(fennec) → in-litmus+
Whiteboard: [QA+]
tracking-fennec: --- → 11+
Keywords: feature
Depends on: 718705
Depends on: 718708
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: